[Bug]: Room invites from any member and in-memory maps that only clean up on insert
還沒有人認領這個 Issue。
評估
研究方向
Two separate fixes. Start with src/api/together.rs, the Command::Invite handler: read how host/permission state is tracked for a room, then decide the smallest rule that lets the host (and only the host) invite, plus a bound on the invited list. Then open src/auth/passkeys.rs around line 25 to see how the challenge map is keyed and where entries are added, and add a sweep or a size cap. Done means an unprivileged member can no longer invite, and repeated startPasskeySignIn calls cannot grow the map without bound; a security-sensitive change like this will need a maintainer's review of the chosen policy.
由索引模型根據 Issue 內容生成。
描述
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Streaming / playback
What happened?
- Anyone in a watch-together or listening room with the
watch_togetherpermission can invite any user id (src/api/together.rsCommand::Invite), including people who got into the room through library access rather than as host. Invites grant access to that room's title even to users who can't see its library, so this hands out access the host didn't choose. Theinvitedlist also has no limit. - Passkey challenges (
src/auth/passkeys.rs:25) only drop expired entries when a new one is added.startPasskeySignInneeds no sign-in, so a flood of requests for an account with passkeys keeps up to 5 minutes' worth of challenges in memory.
Expected behavior
Only the host (or whoever the host allows) can invite, and unauthenticated requests can't grow server memory without bound.
Suggested fix
Restrict Invite to the host (or members the host allows), cap invited, and cap the challenge map size (or sweep it on a timer).
- 主要語言
- TypeScript
- 星號
- 4
- 分支
- 1
- 平均合併
- 4 小時 49 分鐘
- 30 天內合併 PR
- 5
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
tinystream-dev/tinystream 的其他 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
tinystream-dev/tinystream#132 ·
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
tinystream-dev/tinystream#131 ·
-
bug
難度 1/5 1 小時以內 新手友好度 88/100
tinystream-dev/tinystream#129 ·
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
tinystream-dev/tinystream#128 ·
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
tinystream-dev/tinystream#124 ·
查看 tinystream-dev/tinystream 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 86/100
sandbox-quantum/switch#2163 ·
維護者通常 1 天內回覆
-
automated issue report
難度 1/5 1 小時以內 新手友好度 78/100
維護者通常 1 天內回覆
-
area/dashboard kind/bug QA/dev-automation
難度 1/5 1 小時以內 新手友好度 75/100
維護者通常 1 天內回覆
-
bug pydanty:is-working
難度 2/5 1-3 小時 新手友好度 82/100
pydantic/pydantic-ai#13939 ·
維護者通常 1 天內回覆
-
self-host
難度 2/5 1-3 小時 新手友好度 70/100
funmusicplace/mirlo#2625 ·
維護者通常 1 天內回覆