[Bug]: Room invites from any member and in-memory maps that only clean up on insert

Ouverte
#117 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
rust
Domaine
backend, security

Piste de recherche

Two separate fixes. Start with src/api/together.rs, the Command::Invite handler: read how host/permission state is tracked for a room, then decide the smallest rule that lets the host (and only the host) invite, plus a bound on the invited list. Then open src/auth/passkeys.rs around line 25 to see how the challenge map is keyed and where entries are added, and add a sweep or a size cap. Done means an unprivileged member can no longer invite, and repeated startPasskeySignIn calls cannot grow the map without bound; a security-sensitive change like this will need a maintainer's review of the chosen policy.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Streaming / playback

What happened?
  • Anyone in a watch-together or listening room with the watch_together permission can invite any user id (src/api/together.rs Command::Invite), including people who got into the room through library access rather than as host. Invites grant access to that room's title even to users who can't see its library, so this hands out access the host didn't choose. The invited list also has no limit.
  • Passkey challenges (src/auth/passkeys.rs:25) only drop expired entries when a new one is added. startPasskeySignIn needs no sign-in, so a flood of requests for an account with passkeys keeps up to 5 minutes' worth of challenges in memory.
Expected behavior

Only the host (or whoever the host allows) can invite, and unauthenticated requests can't grow server memory without bound.

Suggested fix

Restrict Invite to the host (or members the host allows), cap invited, and cap the challenge map size (or sweep it on a timer).

Langage dominant
TypeScript
Étoiles
4
Forks
1
Merge moyen
4 h 49 min
PR mergées (30 j)
5

Préparer son environnement

  • Fournit un Dockerfile ou un fichier Docker Compose
  • Aucun modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de tinystream-dev/tinystream

Toutes les issues de tinystream-dev/tinystream

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.