Bug: Reaper is force-removed at interpreter exit since 4.15.0, session containers are never reaped
維護者通常 1 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 72/100
研究方向
Read the atexit registration for Reaper.delete_instance and the Reaper._container.stop() path in src/testcontainers/core/container.py, then inspect the regression tests around reaper cleanup. Reproduce with the issue's short Python command and check Docker events or the session label after waiting 15 seconds. Done when normal interpreter exit closes the socket, leaves Ryuk running long enough to reap the session containers, and the regression test passes.
由索引模型根據 Issue 內容生成。
描述
Describe the bug
Since 4.15.0, containers started by a process are left running after that process exits normally. Ryuk never reaps them.
#1017 registered Reaper.delete_instance with atexit to close the Ryuk socket before interpreter shutdown. delete_instance() also calls Reaper._container.stop(), which is remove(force=True), so the Ryuk container gets SIGKILL at the same moment the socket closes:
Ryuk only reaps a session RYUK_RECONNECTION_TIMEOUT (10s by default) after the last connection drops. Killed at exit, it never gets there. Every container of a session that ends normally without stopping its containers itself stays behind. This is the common case Ryuk exists for, e.g. a session-scoped pytest fixture that relies on Ryuk for cleanup.
docker events for the Ryuk container at interpreter exit:
start <ryuk id>
kill <ryuk id> sig=9
destroy <ryuk id>
On 4.14.2 the same script leaves nothing behind. With the process ending through os._exit(0), which skips atexit, 4.15.0 works too, and the Ryuk log shows the normal path:
Client disconnected: 172.17.0.1:49870
Timeout waiting for connection
Removed 1 container(s), 0 network(s), 0 volume(s) 0 image(s)
Expected: the process exits, Ryuk removes the session's containers about 10s later.
Actual: Ryuk is force-removed at exit, the session's containers keep running.
To Reproduce
python -c "
from testcontainers.core.container import DockerContainer
c = DockerContainer('alpine:3.20').with_command('sleep infinity').start()
print(c.get_wrapped_container().short_id)
"
sleep 15
docker ps --filter label=org.testcontainers.lang=python
# 4.14.2: empty. 4.15.0 and main: the alpine container is still Up.
Workarounds: pin testcontainers<4.15, or drop the handler after the reaper is created with atexit.unregister(Reaper.delete_instance).
Closing only the socket at exit keeps the fix from #1017 (no ResourceWarning) and lets Ryuk do its job. #1125 hits a 409 from this same atexit call when Ryuk is already being removed. Fixing this means the atexit path no longer runs into it. I'll open a PR with a fix and a regression test.
Runtime environment
- testcontainers 4.15.0, reproduced on
mainat 6146aa1 - Python 3.12.12
- macOS with Colima (Ubuntu 24.04.4 VM, Docker Engine 29.2.1)
- 主要語言
- Python
- 星號
- 2.3k
- 分支
- 395
- PR 合併指標
- 30 天內沒有已合併 PR
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
testcontainers/testcontainers-python 的其他 Issue
-
Bug: HttpWaitStrategy ignores response predicates for accepted HTTP error statuses可能已有人在做 @PranavMulakala 於 24 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 85/100
testcontainers/testcontainers-python#1143 ·
維護者通常 1 天內回覆
-
Bug: LogMessageWaitStrategy: a container that exits before its message raises without its logs, and __enter__ then removes the container可能已有人在做 @granzer69 於 25 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
testcontainers/testcontainers-python#1138 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 67/100
testcontainers/testcontainers-python#1086 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
testcontainers/testcontainers-python#578 · 5 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 35/100
testcontainers/testcontainers-python#1137 ·
維護者通常 1 天內回覆
查看 testcontainers/testcontainers-python 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 82/100
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 2 天內回覆
-
audit-reference-check
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
site-bug triage
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 77/100
canonical/paas-charm#407 · 1 則留言 ·
維護者通常 5 天內回覆