Bug: Reaper is force-removed at interpreter exit since 4.15.0, session containers are never reaped

Ouverte
#1,140 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@pantafive y travaille déjà.

Depuis le 22/10/2026.

  • #1141 par @pantafive — ouverte

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
72/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
docker, python
Domaine
backend, testing

Piste de recherche

Read the atexit registration for Reaper.delete_instance and the Reaper._container.stop() path in src/testcontainers/core/container.py, then inspect the regression tests around reaper cleanup. Reproduce with the issue's short Python command and check Docker events or the session label after waiting 15 seconds. Done when normal interpreter exit closes the socket, leaves Ryuk running long enough to reap the session containers, and the regression test passes.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Describe the bug

Since 4.15.0, containers started by a process are left running after that process exits normally. Ryuk never reaps them.

#1017 registered Reaper.delete_instance with atexit to close the Ryuk socket before interpreter shutdown. delete_instance() also calls Reaper._container.stop(), which is remove(force=True), so the Ryuk container gets SIGKILL at the same moment the socket closes:

https://github.com/testcontainers/testcontainers-python/blob/6146aa1/src/testcontainers/core/container.py#L544

Ryuk only reaps a session RYUK_RECONNECTION_TIMEOUT (10s by default) after the last connection drops. Killed at exit, it never gets there. Every container of a session that ends normally without stopping its containers itself stays behind. This is the common case Ryuk exists for, e.g. a session-scoped pytest fixture that relies on Ryuk for cleanup.

docker events for the Ryuk container at interpreter exit:

start   <ryuk id>
kill    <ryuk id> sig=9
destroy <ryuk id>

On 4.14.2 the same script leaves nothing behind. With the process ending through os._exit(0), which skips atexit, 4.15.0 works too, and the Ryuk log shows the normal path:

Client disconnected: 172.17.0.1:49870
Timeout waiting for connection
Removed 1 container(s), 0 network(s), 0 volume(s) 0 image(s)

Expected: the process exits, Ryuk removes the session's containers about 10s later.
Actual: Ryuk is force-removed at exit, the session's containers keep running.

To Reproduce

python -c "
from testcontainers.core.container import DockerContainer
c = DockerContainer('alpine:3.20').with_command('sleep infinity').start()
print(c.get_wrapped_container().short_id)
"
sleep 15
docker ps --filter label=org.testcontainers.lang=python
# 4.14.2: empty. 4.15.0 and main: the alpine container is still Up.

Workarounds: pin testcontainers<4.15, or drop the handler after the reaper is created with atexit.unregister(Reaper.delete_instance).

Closing only the socket at exit keeps the fix from #1017 (no ResourceWarning) and lets Ryuk do its job. #1125 hits a 409 from this same atexit call when Ryuk is already being removed. Fixing this means the atexit path no longer runs into it. I'll open a PR with a fix and a regression test.

Runtime environment

  • testcontainers 4.15.0, reproduced on main at 6146aa1
  • Python 3.12.12
  • macOS with Colima (Ubuntu 24.04.4 VM, Docker Engine 29.2.1)
Langage dominant
Python
Étoiles
2.3k
Forks
395
Métriques de merge des PR
Aucune PR mergée en 30 j

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de testcontainers/testcontainers-python

Toutes les issues de testcontainers/testcontainers-python

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.