Containers without a resources section run with no CPU or memory limit
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 35/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- docker, go, typescript
- 領域
- devops, infrastructure
研究方向
Start with apps/api/src/modules/deployments/domain/container-plan.ts and agent/internal/actions/container_spec.go to trace how resource values reach Docker and placement. Read SPEC and the tests covering deployment plans and containers; the issue calls for a decision on default limits versus mandatory declarations before implementation. Done means containers always have CPU and memory limits, placement reserves those same values, SPEC documents the defaults, and a test covers an application without resources.
由索引模型根據 Issue 內容生成。
描述
What
An application without a resources section gets no CPU or memory limit. The deployment plan produces cpuMillis: 0 and memoryBytes: 0 (apps/api/src/modules/deployments/domain/container-plan.ts), the agent passes them to Docker as "no limit" (agent/internal/actions/container_spec.go), and placement reserves nothing for it.
One application can then starve the others on the same server, by accident or on purpose. The process limit and log rotation do not cover CPU and memory.
Found by a security audit of the repository on 8 November 2026, still true on main.
Decision needed
- Default limits for an application that declares none. Suggested: 1 CPU and 512 MiB, overridable in
shipkeep.yml. - Whether declaring
resourcesbecomes mandatory instead. - Later: quotas per environment, and capacity kept back for the node's own services (agent, Caddy, Docker).
Done when
- A container is never created without a CPU and a memory limit.
- Placement reserves the same values it enforces.
- SPEC states the defaults, and a test covers an application without
resources.
- 主要語言
- TypeScript
- 星號
- 2
- 分支
- 1
- 平均合併
- 7 小時 17 分鐘
- 30 天內合併 PR
- 197
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
shipkeepdev/shipkeep 的其他 Issue
-
good first issue
難度 2/5 1-3 小時 新手友好度 84/100
shipkeepdev/shipkeep#295 ·
維護者通常 1 天內回覆
-
good first issue priority:P2 track:control-plane
難度 2/5 1-3 小時 新手友好度 78/100
shipkeepdev/shipkeep#212 ·
維護者通常 1 天內回覆
-
enhancement good first issue priority:P3 track:web
難度 2/5 1-3 小時 新手友好度 85/100
shipkeepdev/shipkeep#144 ·
維護者通常 1 天內回覆
-
documentation good first issue priority:P3 track:control-plane
難度 2/5 1-3 小時 新手友好度 78/100
shipkeepdev/shipkeep#143 ·
維護者通常 1 天內回覆
-
enhancement good first issue priority:P3 track:control-plane
難度 2/5 1-3 小時 新手友好度 85/100
shipkeepdev/shipkeep#142 ·
維護者通常 1 天內回覆
查看 shipkeepdev/shipkeep 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
vercel-labs/ui#540 ·
維護者通常 1 天內回覆
-
accepted ai-dev ai-implementing
難度 2/5 1-3 小時 新手友好度 74/100
維護者通常 1 天內回覆
-
normalizePropName strips `#` characters from Figma property names instead of only the `#id` suffix未關閉
難度 2/5 1-3 小時 新手友好度 72/100
figma/code-connect#419 ·
-
難度 2/5 1-3 小時 新手友好度 78/100
-
Negative values skip k/M abbreviation and medium decimal format on line, stacked-area, and tooltip未關閉
難度 2/5 1-3 小時 新手友好度 84/100
britecharts/britecharts#1255 ·
維護者通常 1 天內回覆