Containers without a resources section run with no CPU or memory limit

Abierto
  • ¿Algo no está bien?
#301 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
docker, go, typescript
Área
devops, infrastructure

Línea de trabajo

Start with apps/api/src/modules/deployments/domain/container-plan.ts and agent/internal/actions/container_spec.go to trace how resource values reach Docker and placement. Read SPEC and the tests covering deployment plans and containers; the issue calls for a decision on default limits versus mandatory declarations before implementation. Done means containers always have CPU and memory limits, placement reserves those same values, SPEC documents the defaults, and a test covers an application without resources.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs-decision

What

An application without a resources section gets no CPU or memory limit. The deployment plan produces cpuMillis: 0 and memoryBytes: 0 (apps/api/src/modules/deployments/domain/container-plan.ts), the agent passes them to Docker as "no limit" (agent/internal/actions/container_spec.go), and placement reserves nothing for it.

One application can then starve the others on the same server, by accident or on purpose. The process limit and log rotation do not cover CPU and memory.

Found by a security audit of the repository on 8 November 2026, still true on main.

Decision needed

  • Default limits for an application that declares none. Suggested: 1 CPU and 512 MiB, overridable in shipkeep.yml.
  • Whether declaring resources becomes mandatory instead.
  • Later: quotas per environment, and capacity kept back for the node's own services (agent, Caddy, Docker).

Done when

  • A container is never created without a CPU and a memory limit.
  • Placement reserves the same values it enforces.
  • SPEC states the defaults, and a test covers an application without resources.
Lenguaje dominante
TypeScript
Estrellas
2
Forks
1
Merge medio
7 h 17 min
PR fusionados (30 d)
197

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de shipkeepdev/shipkeep

Todos los issues de shipkeepdev/shipkeep

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.