Playwright container fails `devEngines` check again because its image does not pin Node.js

已關閉
  • 哪裡不對？
#782 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

已經有一個關聯 PR 被合併了。

  • #785 來自 @bedrich-schindler —— 已合併

評估

難度
4/5
預估耗時
1-2 天
新手友好度
25/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
docker, nodejs, playwright, typescript
領域
devops, testing

研究方向

The Node.js version comes from the Playwright base image used in docker/playwright/Dockerfile, and CI pins its own version in .github/workflows/playwright.yml. Start by comparing the node version the playwright service reports with the devEngines.runtime range, then decide how to pin it, since the issue lists three options and the choice is open. Done means npm run test:playwright-ct:all passes inside the playwright service on a Node version allowed by devEngines.

由索引模型根據 Issue 內容生成。

描述

bug maintenance

Problem

Running component tests locally in the devcontainer fails before any test starts:

$ npm run test:playwright-ct:all
npm error code EBADDEVENGINES
npm error EBADDEVENGINES Invalid devEngines.runtime
npm error EBADDEVENGINES Invalid semver version "^22.23.0 || ^24.17.0" does not match "v26.13.0" for "runtime"

This also blocks npm run test:playwright-ct:all-with-update and the checks
in the /commit skill. The tests themselves pass when started without npm.

Cause

Same root cause as #738, which was closed by aligning versions rather than by
pinning Node.js in the playwright service.

Source Node.js
devEngines.runtime ^22.23.0 || ^24.17.0
node service (node:24.22.1) v24.22.1
playwright service (playwright:v1.64.1) v26.13.0
CI (actions/setup-node) 24.17

docker/playwright/Dockerfile takes Node.js from the Playwright image, which
has deb.nodesource.com/node_26.x configured.

Not explained yet: utils/docker/Dockerfile.noble at the Playwright v1.64.1
tag still has ARG NODE_VERSION=24, and the node binary in the image is dated
2026-10-28, after the update to this image on 2026-10-26. The tag may have been
republished, so the Node.js version can change without any change in this
repository. v1.64.1 and v1.64.1-noble currently resolve to the same digest,
so switching to -noble would not help.

Why CI passes

.github/workflows/playwright.yml runs actions/setup-node, which puts
Node.js 24.17 ahead of the image's Node.js. The local playwright service has
no such step. CI also still uses playwright:v1.63.0-noble, while
@playwright/test is on ~1.64.1.

Steps to reproduce

  1. docker compose up -d --build
  2. docker compose exec -T devcontainer npm run test:playwright-ct:all

Expected behavior

Component tests run locally in the playwright service, on a Node.js version
allowed by devEngines, however the upstream image changes.

Possible solutions

  1. Install pinned Node.js and npm in docker/playwright/Dockerfile, e.g. copy
    them from the node image in a multi-stage build, as proposed in #738.
  2. Keep Node.js and npm versions in one place so that the services and workflows
    cannot drift apart.
  3. Add ^26 to devEngines.runtime. This is the smallest change, but it allows
    Node.js 26 for all development and the problem returns with the next upstream
    change.
主要語言
TypeScript
星號
23
分支
10
平均合併
5 天 14 小時
30 天內合併 PR
9

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

react-ui-org/react-ui 的其他 Issue

查看 react-ui-org/react-ui 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。