Playwright container fails `devEngines` check again because its image does not pin Node.js

Abierto
  • ¿Algo no está bien?
#782 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
docker, nodejs, playwright, typescript
Área
devops, testing

Línea de trabajo

The Node.js version comes from the Playwright base image used in docker/playwright/Dockerfile, and CI pins its own version in .github/workflows/playwright.yml. Start by comparing the node version the playwright service reports with the devEngines.runtime range, then decide how to pin it, since the issue lists three options and the choice is open. Done means npm run test:playwright-ct:all passes inside the playwright service on a Node version allowed by devEngines.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug maintenance

Problem

Running component tests locally in the devcontainer fails before any test starts:

$ npm run test:playwright-ct:all
npm error code EBADDEVENGINES
npm error EBADDEVENGINES Invalid devEngines.runtime
npm error EBADDEVENGINES Invalid semver version "^22.23.0 || ^24.17.0" does not match "v26.13.0" for "runtime"

This also blocks npm run test:playwright-ct:all-with-update and the checks
in the /commit skill. The tests themselves pass when started without npm.

Cause

Same root cause as #738, which was closed by aligning versions rather than by
pinning Node.js in the playwright service.

Source Node.js
devEngines.runtime ^22.23.0 || ^24.17.0
node service (node:24.22.1) v24.22.1
playwright service (playwright:v1.64.1) v26.13.0
CI (actions/setup-node) 24.17

docker/playwright/Dockerfile takes Node.js from the Playwright image, which
has deb.nodesource.com/node_26.x configured.

Not explained yet: utils/docker/Dockerfile.noble at the Playwright v1.64.1
tag still has ARG NODE_VERSION=24, and the node binary in the image is dated
2026-10-28, after the update to this image on 2026-10-26. The tag may have been
republished, so the Node.js version can change without any change in this
repository. v1.64.1 and v1.64.1-noble currently resolve to the same digest,
so switching to -noble would not help.

Why CI passes

.github/workflows/playwright.yml runs actions/setup-node, which puts
Node.js 24.17 ahead of the image's Node.js. The local playwright service has
no such step. CI also still uses playwright:v1.63.0-noble, while
@playwright/test is on ~1.64.1.

Steps to reproduce

  1. docker compose up -d --build
  2. docker compose exec -T devcontainer npm run test:playwright-ct:all

Expected behavior

Component tests run locally in the playwright service, on a Node.js version
allowed by devEngines, however the upstream image changes.

Possible solutions

  1. Install pinned Node.js and npm in docker/playwright/Dockerfile, e.g. copy
    them from the node image in a multi-stage build, as proposed in #738.
  2. Keep Node.js and npm versions in one place so that the services and workflows
    cannot drift apart.
  3. Add ^26 to devEngines.runtime. This is the smallest change, but it allows
    Node.js 26 for all development and the problem returns with the next upstream
    change.
Lenguaje dominante
TypeScript
Estrellas
23
Forks
10
Merge medio
5 d 12 h
PR fusionados (30 d)
9

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

  • Sin Dockerfile ni archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de react-ui-org/react-ui

Todos los issues de react-ui-org/react-ui

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.