Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Assertion `year >= 1' failed in 'days_before_year'` when unpickling datetime with year 0

未關閉
#160,358 4 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
68/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
python
領域
backend

研究方向

Start in Modules/_datetimemodule.c, where datetime objects are reconstructed from pickle state, and inspect the related datetime tests. Reproduce the report with the supplied corrupted pickle bytes in a development build, then check that loading rejects year 0 with the expected ValueError while valid dates still work.

由索引模型根據 Issue 內容生成。

描述

extension-modules type-crash
Crash report

_datetimemodule.c does not validate that MINYEAR <= year <= MAXYEAR when reconstructing a datetime.datetime object from serialized bytes (unpickling).

This allows instantiating an invalid datetime object with year == 0. Subsequent calls to methods such as .toordinal() hit the C-level assertion assert(year >= 1) in days_before_year(), crashing the interpreter process with SIGABRT in debug / -X dev builds.

Steps to Reproduce

Run the following script with ./python -X dev:

import datetime
import pickle

dt = datetime.datetime(2023, 10, 1)
data = pickle.dumps(dt)

# Replace year 2023 (0x07E7) with 0 (0x0000)
corrupted_data = data.replace(b'\x07\xe7', b'\x00\x00')

obj = pickle.loads(corrupted_data)
obj.toordinal()
Actual Behavior

The process aborts due to an assertion failure:

python: ./Modules/_datetimemodule.c:477: int days_before_year(int): Assertion `year >= 1' failed.
Fatal Python error: Aborted

Current thread 0x00007f8943602400 [python] (most recent call first):
  File "<python-input-0>", line 11 in <module>
  File "/home/boss/projects/oss/cpython/main/Lib/_pyrepl/console.py", line 231 in runcode
  File "/home/boss/projects/oss/cpython/main/Lib/_pyrepl/console.py", line 288 in runsource
  File "/home/boss/projects/oss/cpython/main/Lib/code.py", line 324 in push
  File "/home/boss/projects/oss/cpython/main/Lib/_pyrepl/simple_interact.py", line 149 in run_multiline_interactive_console
  File "/home/boss/projects/oss/cpython/main/Lib/_pyrepl/main.py", line 58 in interactive_console

Current thread's C stack trace (most recent call first):
  Binary file "./python", at __interceptor_backtrace+0x4c [0x55a217378b2c]
  Binary file "./python", at _Py_DumpStack+0x10c [0x55a21803e9c4]
  Binary file "./python", at +0x1a523c1 [0x55a2180b83c1]
  Binary file "/usr/lib/libc.so.6", at +0x3e6f0 [0x7f894323e6f0]
  Binary file "/usr/lib/libc.so.6", at +0x9a11c [0x7f894329a11c]
  Binary file "/usr/lib/libc.so.6", at gsignal+0x20 [0x7f894323e5d0]
  Binary file "/usr/lib/libc.so.6", at abort+0x26 [0x7f8943225685]
  Binary file "/usr/lib/libc.so.6", at +0x26704 [0x7f8943226704]
  Binary file "/usr/lib/libc.so.6", at __assert_fail+0xc2 [0x7f89432361f2]
  Binary file "./python", at +0x1ab4039 [0x55a21811a039]
  Binary file "./python", at +0x115f759 [0x55a2177c5759]
  Binary file "./python", at +0x111c356 [0x55a217782356]
  Binary file "./python", at _Py_VectorCallInstrumentation_StackRefSteal+0x180 [0x55a217c96a58]
  Binary file "./python", at +0x1671568 [0x55a217cd7568]
  Binary file "./python", at _PyEval_EvalFrameDefault+0x4a1 [0x55a217c9a059]
  Binary file "./python", at PyEval_EvalCode+0x2d9 [0x55a217c956e1]
  Binary file "./python", at +0x1621beb [0x55a217c87beb]
  Binary file "./python", at _Py_BuiltinCallFastWithKeywords_StackRef+0x155 [0x55a217c9773d]
  Binary file "./python", at +0x16bcdf4 [0x55a217d22df4]
  Binary file "./python", at _PyEval_EvalFrameDefault+0x4a1 [0x55a217c9a059]
  Binary file "./python", at +0x162fc40 [0x55a217c95c40]
  Binary file "./python", at +0x111f20a [0x55a21778520a]
  Binary file "./python", at +0x1a1c6ca [0x55a2180826ca]
  Binary file "./python", at +0x1a1ae13 [0x55a218080e13]
  Binary file "./python", at Py_RunMain+0xd79 [0x55a21807f051]
  Binary file "./python", at +0x1a19cf9 [0x55a21807fcf9]
  Binary file "./python", at Py_BytesMain+0xd5 [0x55a21807ffbd]
  Binary file "/usr/lib/libc.so.6", at +0x27781 [0x7f8943227781]
  Binary file "/usr/lib/libc.so.6", at __libc_start_main+0x89 [0x7f89432278b9]
  Binary file "./python", at _start+0x25 [0x55a217328fa5]
fish: Job 1, './python -X dev' terminated by signal SIGABRT (Abort)
Expected Behavior

pickle.loads() should validate year against MINYEAR (1) and MAXYEAR (9999) during state unpacking and raise ValueError: year 0 is out of range, consistent with the standard datetime(year, month, day) constructor.

Environment
  • CPython version: 3.16.0a1+dev (heads/main:ad101c3b307)
  • OS: Linux
  • Build: CC=clang CXX=clang++ LDFLAGS='-fuse-ld=lld' ./configure --with-tail-call-interp --with-pydebug --with-address-sanitizer --with-undefined-behavior-sanitizer
CPython versions tested on:

CPython main branch, 3.16, 3.15, 3.14, 3.13, 3.12, 3.11

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

Python 3.16.0a1+dev (heads/main:ad101c3b307, Oct 22 2026, 23:57:40) [Clang 23.1.3 ]

主要語言
Python
星號
77.7k
分支
38.3k
平均合併
11 小時 58 分鐘
30 天內合併 PR
672

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。