Under Proton, mad() can be split into a multiply and an add, so wg_div / pd_div3 are 1 ULP off (upstream fix proposed)
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 15/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- cpp
研究方向
The payload names build_dx12.py, which strips precise marks from the division shaders, and clean/dx12/README.md, which documents the Windows driver's fused mad() behaviour. It also names native_helpers color_divide and native_direct_test check as the ULP measurements. The root cause and the proposed fix live upstream in dxil-spirv#365, so no change in this repository is clearly requested; confirm with the maintainer what, if anything, belongs here before starting.
由索引模型根據 Issue 內容生成。
描述
Under Proton, WrongGPU's exact arithmetic is not exact everywhere. The cause is in the D3D12-to-Vulkan translation, not in WrongGPU, and a fix is proposed upstream: HansKristian-Work/dxil-spirv#365. This issue records what we found, for reference.
What happens
dxil-spirv translates mad() (DXIL FMad) to a SPIR-V Fma. It marks the Fma NoContraction only when the FMad carries dx.precise. Without that mark, RADV's compiler (ACO) may split the Fma into a multiply and an add. In wg_div, mad(-bs, y, 1.0f) became s_mul_f32 + s_sub_f32, and the remainder steps became v_mul_f32 + v_sub_f32. AMD's Windows driver keeps every non-precise mad() fused (clean/dx12/README.md), and wg_div and pd_div3 depend on that.
Measured on an RX 9070 XT (RADV) under GE-Proton 11-11, with vkd3d-proton 5b1089c8 + dxil-spirv#362:
native_helperscolor_divideagainst IEEE division (NumPy): 44,010 of 1,802,240 results 1 ULP off (51 of 110 divisors).native_direct_test check: the direct and staged routes differ by 1 inpost.historyfrom frame 3 (reset frame, exposure mode 0, pre-exposure 1.375).
In game, a difference this size is not visible. It matters for bit-exact comparisons run under Proton.
Fixes
- Upstream, dxil-spirv#365: every FMad's
FmagetsNoContraction. With it,color_dividehas 0 wrong results and the two routes give the same bits on all 8 frames. A timing A/B of Model M's frame showed +0.18%, inside the noise. In Cyberpunk, RR's frame time did not change. It reaches players once a vkd3d-proton with it ships in Proton. - Interim, no rebuild: vkd3d-proton's shader quirk. Create a text file with this line:
Then start the game with0000000000000000-ffffffffffffffff FORCE_NOCONTRACT_MATHVKD3D_SHADER_QUIRKS=<path to that file> %command%.color_dividethen also has 0 wrong results; Model M's frame A/B was +0.52%, inside the noise. Note that this applies to every shader in the game, not only WrongGPU's. I have not measured what it costs the game's own rendering.
Not a fix: precise
Marking the divisions' mad() calls precise would give dxil-spirv the dx.precise mark it needs. But build_dx12.py removes these marks on purpose, because AMD's Windows driver splits a precise mad(). Keeping them would trade the Proton problem for the same problem on Windows, so the fix belongs in the translation layer.
🤖 Generated with Claude Code
- 主要語言
- C++
- 星號
- 12
- 分支
- 2
- 平均合併
- 3 小時 10 分鐘
- 30 天內合併 PR
- 171
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
phantoslayer21/wronggpu 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 88/100
phantoslayer21/wronggpu#275 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
phantoslayer21/wronggpu#274 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 88/100
phantoslayer21/wronggpu#241 ·
維護者通常 1 天內回覆
-
bug build
難度 2/5 1-3 小時 新手友好度 74/100
phantoslayer21/wronggpu#234 ·
維護者通常 1 天內回覆
-
bug build
難度 2/5 1-3 小時 新手友好度 80/100
phantoslayer21/wronggpu#233 ·
維護者通常 1 天內回覆
查看 phantoslayer21/wronggpu 的全部 Issue
相似的 Issue
-
ai_p2
難度 2/5 1-3 小時 新手友好度 80/100
ClickHouse/ClickHouse#132519 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
juce-framework/JUCE#1810 ·
-
難度 1/5 1 小時以內 新手友好度 82/100
petercorke/robotics-toolbox-python#952 ·
維護者通常 1 天內回覆
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit status未關閉func:engine type:bug
難度 2/5 1-3 小時 新手友好度 72/100
NatronGitHub/Natron#1276 ·
維護者通常 1 天內回覆
-
難度 1/5 1-3 小時 新手友好度 77/100
維護者通常 1 天內回覆