Under Proton, mad() can be split into a multiply and an add, so wg_div / pd_div3 are 1 ULP off (upstream fix proposed)

Ouverte
#150 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
15/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
cpp

Piste de recherche

The payload names build_dx12.py, which strips precise marks from the division shaders, and clean/dx12/README.md, which documents the Windows driver's fused mad() behaviour. It also names native_helpers color_divide and native_direct_test check as the ULP measurements. The root cause and the proposed fix live upstream in dxil-spirv#365, so no change in this repository is clearly requested; confirm with the maintainer what, if anything, belongs here before starting.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: linux area: runtime

Under Proton, WrongGPU's exact arithmetic is not exact everywhere. The cause is in the D3D12-to-Vulkan translation, not in WrongGPU, and a fix is proposed upstream: HansKristian-Work/dxil-spirv#365. This issue records what we found, for reference.

What happens

dxil-spirv translates mad() (DXIL FMad) to a SPIR-V Fma. It marks the Fma NoContraction only when the FMad carries dx.precise. Without that mark, RADV's compiler (ACO) may split the Fma into a multiply and an add. In wg_div, mad(-bs, y, 1.0f) became s_mul_f32 + s_sub_f32, and the remainder steps became v_mul_f32 + v_sub_f32. AMD's Windows driver keeps every non-precise mad() fused (clean/dx12/README.md), and wg_div and pd_div3 depend on that.

Measured on an RX 9070 XT (RADV) under GE-Proton 11-11, with vkd3d-proton 5b1089c8 + dxil-spirv#362:

  • native_helpers color_divide against IEEE division (NumPy): 44,010 of 1,802,240 results 1 ULP off (51 of 110 divisors).
  • native_direct_test check: the direct and staged routes differ by 1 in post.history from frame 3 (reset frame, exposure mode 0, pre-exposure 1.375).

In game, a difference this size is not visible. It matters for bit-exact comparisons run under Proton.

Fixes

  1. Upstream, dxil-spirv#365: every FMad's Fma gets NoContraction. With it, color_divide has 0 wrong results and the two routes give the same bits on all 8 frames. A timing A/B of Model M's frame showed +0.18%, inside the noise. In Cyberpunk, RR's frame time did not change. It reaches players once a vkd3d-proton with it ships in Proton.
  2. Interim, no rebuild: vkd3d-proton's shader quirk. Create a text file with this line:
    0000000000000000-ffffffffffffffff FORCE_NOCONTRACT_MATH
    
    Then start the game with VKD3D_SHADER_QUIRKS=<path to that file> %command%. color_divide then also has 0 wrong results; Model M's frame A/B was +0.52%, inside the noise. Note that this applies to every shader in the game, not only WrongGPU's. I have not measured what it costs the game's own rendering.

Not a fix: precise

Marking the divisions' mad() calls precise would give dxil-spirv the dx.precise mark it needs. But build_dx12.py removes these marks on purpose, because AMD's Windows driver splits a precise mad(). Keeping them would trade the Proton problem for the same problem on Windows, so the fix belongs in the translation layer.

🤖 Generated with Claude Code

Langage dominant
C++
Étoiles
12
Forks
2
Merge moyen
3 h 10 min
PR mergées (30 j)
171

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de phantoslayer21/wronggpu

Toutes les issues de phantoslayer21/wronggpu

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.