[BUG] before hooks do not receive the evaluation context returned by earlier before hooks
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 78/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- python
研究方向
從 OpenFeatureClient._establish_hooks_and_provider 和 _hook_support._execute_hooks_unchecked 開始,接著追蹤 _run_before_hooks_and_update_context 以及 before_hooks 的歸約流程。確保每個後續的 before hook 都能接收到先前的貢獻,同時保留 provider 最終合併後的 context。新增一個使用不同層級的兩個 hook 的回歸案例,檢查第二個 hook 觀察到的內容以及 provider 接收到的內容。
由索引模型根據 Issue 內容生成。
描述
Observed behaviour
Requirement 4.3.4 says:
Any
evaluation contextreturned from abeforehook MUST be passed to subsequentbefore
hooks (viaHookContext).
Each hook receives a HookContext built before any hook ran, so a hook never sees what an earlier
hook contributed.
The final merge into the evaluation context is correct — the provider does receive every hook's
contribution, so 3.2.2
and 4.3.5 are satisfied.
Only the propagation half is missing.
Reproducer
Against main (bd3b1e6):
from openfeature import api
from openfeature.client import OpenFeatureClient
from openfeature.evaluation_context import EvaluationContext
from openfeature.flag_evaluation import FlagEvaluationOptions
from openfeature.hook import Hook, HookContext
from openfeature.provider.in_memory_provider import InMemoryFlag, InMemoryProvider
observed = {}
class ContributingHook(Hook):
"""Adds one attribute, and records what it could see when it ran."""
def __init__(self, name, adds):
self.name = name
self.adds = adds
def before(self, hook_context: HookContext, hints):
observed[self.name] = dict(hook_context.evaluation_context.attributes)
return EvaluationContext(attributes=self.adds)
class RecordingProvider(InMemoryProvider):
def resolve_boolean_details(self, flag_key, default_value, evaluation_context=None):
observed["provider"] = dict(evaluation_context.attributes) if evaluation_context else {}
return super().resolve_boolean_details(flag_key, default_value, evaluation_context)
api.set_provider(RecordingProvider({"flag": InMemoryFlag("on", {"on": True, "off": False})}))
client: OpenFeatureClient = api.get_client()
client.add_hooks([ContributingHook("hook_a", {"from_hook_a": "a"})])
# hook_b is an invocation hook, so it runs after the client hook (API -> client -> invocation).
client.get_boolean_details(
"flag",
False,
evaluation_context=EvaluationContext(attributes={"from_invocation": "i"}),
flag_evaluation_options=FlagEvaluationOptions(
hooks=[ContributingHook("hook_b", {"from_hook_b": "b"})]
),
)
print("hook_a saw :", observed["hook_a"])
print("hook_b saw :", observed["hook_b"])
print("provider :", observed["provider"])
Output:
hook_a saw : {'from_invocation': 'i'}
hook_b saw : {'from_invocation': 'i'}
provider : {'from_invocation': 'i', 'from_hook_a': 'a', 'from_hook_b': 'b'}
hook_b should have seen from_hook_a: a. The provider line shows the final merge is fine.
Cause
OpenFeatureClient._establish_hooks_and_provider constructs one HookContext per hook up front,
all from the same merged_eval_context:
merged_hooks_and_context = [
(
hook,
HookContext(
flag_key=flag_key,
flag_type=flag_type,
default_value=default_value,
evaluation_context=merged_eval_context,
client_metadata=client_metadata,
provider_metadata=provider_metadata,
hook_data={},
),
)
for hook in chain(get_hooks(), self.hooks, evaluation_hooks, provider.get_provider_hooks())
]
_hook_support._execute_hooks_unchecked then iterates those pairs without ever updating one:
return [
getattr(hook, hook_method.value)(hook_context=hook_context, **kwargs)
for (hook, hook_context) in hooks_and_context
if hook.supports_flag_value_type(flag_type)
]
before_hooks reduces the results correctly (reduce(lambda a, b: a.merge(b), filtered_hooks)),
which is why the provider still gets everything — but that accumulation is never fed back into the
hook contexts.
The docstring on _run_before_hooks_and_update_context cites 4.3.4 while implementing only the
merge half.
Suggested fix
Accumulate as the hooks run and refresh the context handed to each subsequent hook, rather than
collecting results and merging once at the end. Roughly:
def before_hooks(flag_type, hooks_and_context, hints=None):
accumulated = EvaluationContext()
for hook, hook_context in hooks_and_context:
if not hook.supports_flag_value_type(flag_type):
continue
hook_context.evaluation_context = hook_context.evaluation_context.merge(accumulated)
result = hook.before(hook_context=hook_context, hints=hints)
if result is not None:
accumulated = accumulated.merge(result)
return accumulated
HookContext is a plain mutable class (__init__-assigned attributes, not frozen), so assigning
evaluation_context in place works; rebuilding the context per hook is equally fine. dotnet-sdk does
the latter (WithNewEvaluationContext applied to every pending hook context); ruby-sdk does the
former.
Cross-language note
Surveyed 2026-09-14 — js-sdk, java-sdk, dotnet-sdk and ruby-sdk all propagate correctly.
go-sdk had a related but distinct bug (results replaced rather than merged), reported as
go-sdk#549 and fixed by
go-sdk#569. php-sdk has the same propagation gap
as this one.
Given four SDKs have now been found wanting on one half or the other, this seems like a good
candidate for a shared e2e/TCK case: two before hooks at different levels, each returning a distinct
key; assert both reach the provider and that the second hook observed the first's key. Asserting
only the merged result would miss this bug entirely.
- 主要語言
- Python
- 星號
- 111
- 分支
- 44
- 平均合併
- 2 小時 37 分鐘
- 30 天內合併 PR
- 14
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
open-feature/python-sdk 的其他 Issue
-
question
難度 4/5 3-5 天 新手友好度 38/100
open-feature/python-sdk#627 ·
-
v0.9.0
難度 5/5 一週以上 新手友好度 25/100
open-feature/python-sdk#618 ·
-
難度 4/5 3-5 天 新手友好度 55/100
open-feature/python-sdk#615 ·
-
open-feature/python-sdk#584 · 已指派 1 人 ·
-
multi-provider
難度 5/5 一週以上 新手友好度 25/100
open-feature/python-sdk#568 ·
查看 open-feature/python-sdk 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 75/100
-
hcocena 未關閉policies-accepted pre-review precheck-passed
難度 1/5 1 小時以內 新手友好度 88/100
Bioconductor/BiocContributions#214 · 5 則留言 ·
-
難度 1/5 1 小時以內 新手友好度 92/100
TencentCloud/Octop#1169 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
521xueweihan/HelloGitHub#3778 ·
-
The version checker's trailing attribute region has no control for a less-than inside a quoted value 未關閉area: dashboard area: tests bug perceived difficulty: 2 python
難度 2/5 1-3 小時 新手友好度 84/100
Nitjsefnie-Harness-Commons/daedalus#1105 · 1 則留言 ·