Set-MgRequestContext: expose RetryUnprocessedMutationsOnly so POST and PATCH aren't resent after a 504

未關閉
#3,917 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 7 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
56/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
csharp, powershell

研究方向

Start by tracing IRequestContext, RequestContext, Set-MgRequestContext, and the RetryHandlerOption construction in GraphHttpClientFactory; check the related Get-MgRequestContext documentation and existing tests. Confirm the target SDK versions and that the resolved Kiota HTTP client library supports the option. Done when the setting can be configured through the request context, defaults to false, and the cmdlet and documentation reflect it.

由索引模型根據 Issue 內容生成。

描述

Is your feature request related to a problem? Please describe the problem.

The Graph PowerShell SDK retries a POST after a 504 Gateway Timeout, which can repeat its side effect. With sendMail, one Invoke-MgGraphRequest call can deliver the same email up to four times while the caller sees one error. The reproduction and investigation are in microsoft/kiota-dotnet#851.

Kiota has since added an opt-in setting for this, RetryHandlerOption.RetryUnprocessedMutationsOnly (microsoft/kiota-dotnet#864, merged and expected in kiota-dotnet 2.2.0). When it's on, POST and PATCH are retried only after a 429 or 503, and other responses, including a 504, go back to the caller. It defaults to off.

PowerShell users can't turn it on yet, because Set-MgRequestContext only exposes MaxRetry, RetryDelay, RetriesTimeLimit and ClientTimeout. The only workaround today is Set-MgRequestContext -MaxRetry 0 around each send. That setting is process-wide, so while a send is in flight it also turns off retries for every other Graph request in the process, and two overlapping sends in different runspaces can undo each other's setting.

Describe the solution you'd like.

Expose the setting through the request context:

  • add bool RetryUnprocessedMutationsOnly to IRequestContext, defaulting to false in RequestContext
  • add a -RetryUnprocessedMutationsOnly switch to Set-MgRequestContext, following the existing BoundParameters pattern
  • pass it into the RetryHandlerOption that GraphHttpClientFactory already builds from the request context
  • update the Set-MgRequestContext and Get-MgRequestContext docs
Set-MgRequestContext -RetryUnprocessedMutationsOnly
Additional context?

This needs Microsoft.Kiota.Http.HttpClientLibrary 2.2.0 or later, which the Authentication module currently gets through Microsoft.Graph.Core.

Open questions:

  1. Should this target V2, V3 (#3874), or both?
  2. Is a direct reference to Kiota 2.2.0 acceptable, or should this wait for a Microsoft.Graph.Core release that requires it?

I'm happy to open the PR once 2.2.0 ships.

主要語言
C#
星號
911
分支
236
平均合併
9 天 18 小時
30 天內合併 PR
33

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

microsoftgraph/msgraph-sdk-powershell 的其他 Issue

查看 microsoftgraph/msgraph-sdk-powershell 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。