beacon: raise the custody group count for attached validators (fulu validator custody)
維護者通常 6 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 35/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- rust
研究方向
Start with crates/net/rpc/src/beacon/validator.rs to trace validator indices from beacon_committee_subscriptions and prepare_beacon_proposer. Then read bin/ethlambda/src/beacon.rs and the custody paths listed in the issue to see how the startup count is used. Done means attached validators affect the custody count and the count is advertised consistently; the issue describes additional persistence, runtime update, and backfill work.
由索引模型根據 Issue 內容生成。
描述
Problem
ethlambda beacon does not implement fulu validator custody. It custodies and advertises whatever --custody-group-count says (default CUSTODY_REQUIREMENT = 4), regardless of how many validators are attached to it.
Fulu validator.md ("Validator custody") says a node with validators attached custodies get_validators_custody_requirement(state, validator_indices) groups. That is the attached validators' total effective balance divided by BALANCE_PER_ADDITIONAL_CUSTODY_GROUP (32 ETH), with a floor of VALIDATOR_CUSTODY_REQUIREMENT (8) and a cap of NUMBER_OF_CUSTODY_GROUPS (128). A node with 4096 ETH or more attached must therefore be a supernode.
Observed in a kurtosis test enclave: with 128 validators attached, ethlambda logged custody_group_count=4, while Lighthouse in the same network reported 128. A network laid out on the assumption that every validating node stores at least 8 groups is short on column custody wherever ethlambda runs the validators.
What the code does today (at 0ea6e214)
validator_custody_requirementandbalance_per_additional_custody_groupare parsed intoConfigand then dropped.first_config_differencedestructures both as_, and nothing else reads them.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/bin/ethlambda/src/main.rs#L1884-L1890- The custody set is computed once at startup, in
wire_params, from the CLI value, and kept for the life of the process.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/bin/ethlambda/src/beacon.rs#L211-L220 - The node does not record which validators are attached.
beacon_committee_subscriptionsparsesvalidator_indexbut never reads it, andprepare_beacon_proposerkeeps the indices only as keys of the fee-recipient map.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/rpc/src/beacon/validator.rs#L285-L299
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/rpc/src/beacon/validator.rs#L348-L358 - MetaData v3 always answers
custody_group_count = CUSTODY_REQUIREMENT, even when--custody-group-countis set higher. The ENR'scgcdoes carry the flag's value, so the two disagree on any node started with a non-default count.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/p2p/src/beacon/handler.rs#L124-L148 GET /eth/v1/node/identityreportsseq_number,attnetsandsyncnetsundermetadata, but notcustody_group_count.AdvertisedMetaDatahas no field for it.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/rpc/src/beacon/node.rs#L117-L130
What the spec asks for (fulu validator.md)
- Advertise the higher count in MetaData
custody_group_countand in the ENR'scgc. - Adjust it dynamically, without operator input, as the attached validators' effective balances change.
- On an increase, advertise the new count immediately. Backfill MAY follow.
earliest_available_slotin Status v2 should reflect what the node can actually serve, and may move lower as backfill progresses. - On a decrease, keep custodying and advertising the previous (highest) count, and persist it across restarts.
Rough scope
- Track attached validator indices from validator client calls (
beacon_committee_subscriptions,prepare_beacon_proposer), with an expiry so that a detached validator client stops counting. - Once per epoch, compute
get_validators_custody_requirementand take the larger of the flag, that requirement, and the persisted highest count. Store the highest count in the data directory. - Make the custody set changeable at runtime. Today it is fixed in
BeaconWireand in the chain actor at spawn, and these paths read it: data-column subnet subscriptions, the availability check, req/resp serving, and the engine's custody columns. - When the count changes, bump the MetaData
seq_numberand the ENR. The ENR has the same known gap as the fork digest: ethrex'sDiscoveryServercannot replace the record it serves at runtime, socgcwould stay at its startup value until a restart. - Make MetaData v3 report the real count, and add
custody_group_countto/eth/v1/node/identity. - After an increase, keep
earliest_available_slothonest until backfill completes.
Steps 5 and 1 are small and independent, so they could land first.
- 主要語言
- Rust
- 星號
- 86
- 分支
- 34
- 平均合併
- 9 天 20 小時
- 30 天內合併 PR
- 77
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
lambdaclass/ethlambda 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 76/100
lambdaclass/ethlambda#850 ·
維護者通常 6 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
lambdaclass/ethlambda#777 · 1 個 reaction ·
維護者通常 6 天內回覆
-
Run all gossip validation tests可能重新可做 @dicethedev 於 9 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 62/100
lambdaclass/ethlambda#725 · 2 則留言 ·
維護者通常 6 天內回覆
-
Handle malformed DB data可能重新可做 @dicethedev 於 115 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
lambdaclass/ethlambda#529 · 4 則留言 ·
維護者通常 6 天內回覆
-
Document architectural choices可能重新可做 @dicethedev 於 115 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 68/100
lambdaclass/ethlambda#521 · 2 則留言 ·
維護者通常 6 天內回覆
查看 lambdaclass/ethlambda 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 88/100
bytecodealliance/wrpc#1785 ·
維護者通常 1 天內回覆
-
2 advisory ignore entries no longer match anything (`quick-xml` already patched in `Cargo.lock`)未關閉
難度 1/5 1 小時以內 新手友好度 85/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
longbridge/nsh#2758 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 84/100
antithesishq/bombadil#473 ·
維護者通常 2 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 72/100
libracoder/kiri#669 ·
維護者通常 1 天內回覆