beacon: raise the custody group count for attached validators (fulu validator custody)
I maintainer di solito rispondono entro 6 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 35/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- rust
- Ambito
- distributed-systems, networking
Direzione di ricerca
Start with crates/net/rpc/src/beacon/validator.rs to trace validator indices from beacon_committee_subscriptions and prepare_beacon_proposer. Then read bin/ethlambda/src/beacon.rs and the custody paths listed in the issue to see how the startup count is used. Done means attached validators affect the custody count and the count is advertised consistently; the issue describes additional persistence, runtime update, and backfill work.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
ethlambda beacon does not implement fulu validator custody. It custodies and advertises whatever --custody-group-count says (default CUSTODY_REQUIREMENT = 4), regardless of how many validators are attached to it.
Fulu validator.md ("Validator custody") says a node with validators attached custodies get_validators_custody_requirement(state, validator_indices) groups. That is the attached validators' total effective balance divided by BALANCE_PER_ADDITIONAL_CUSTODY_GROUP (32 ETH), with a floor of VALIDATOR_CUSTODY_REQUIREMENT (8) and a cap of NUMBER_OF_CUSTODY_GROUPS (128). A node with 4096 ETH or more attached must therefore be a supernode.
Observed in a kurtosis test enclave: with 128 validators attached, ethlambda logged custody_group_count=4, while Lighthouse in the same network reported 128. A network laid out on the assumption that every validating node stores at least 8 groups is short on column custody wherever ethlambda runs the validators.
What the code does today (at 0ea6e214)
validator_custody_requirementandbalance_per_additional_custody_groupare parsed intoConfigand then dropped.first_config_differencedestructures both as_, and nothing else reads them.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/bin/ethlambda/src/main.rs#L1884-L1890- The custody set is computed once at startup, in
wire_params, from the CLI value, and kept for the life of the process.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/bin/ethlambda/src/beacon.rs#L211-L220 - The node does not record which validators are attached.
beacon_committee_subscriptionsparsesvalidator_indexbut never reads it, andprepare_beacon_proposerkeeps the indices only as keys of the fee-recipient map.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/rpc/src/beacon/validator.rs#L285-L299
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/rpc/src/beacon/validator.rs#L348-L358 - MetaData v3 always answers
custody_group_count = CUSTODY_REQUIREMENT, even when--custody-group-countis set higher. The ENR'scgcdoes carry the flag's value, so the two disagree on any node started with a non-default count.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/p2p/src/beacon/handler.rs#L124-L148 GET /eth/v1/node/identityreportsseq_number,attnetsandsyncnetsundermetadata, but notcustody_group_count.AdvertisedMetaDatahas no field for it.
https://github.com/lambdaclass/ethlambda/blob/0ea6e214930dcfc44422e5e4eb9a2866d32f1fec/crates/net/rpc/src/beacon/node.rs#L117-L130
What the spec asks for (fulu validator.md)
- Advertise the higher count in MetaData
custody_group_countand in the ENR'scgc. - Adjust it dynamically, without operator input, as the attached validators' effective balances change.
- On an increase, advertise the new count immediately. Backfill MAY follow.
earliest_available_slotin Status v2 should reflect what the node can actually serve, and may move lower as backfill progresses. - On a decrease, keep custodying and advertising the previous (highest) count, and persist it across restarts.
Rough scope
- Track attached validator indices from validator client calls (
beacon_committee_subscriptions,prepare_beacon_proposer), with an expiry so that a detached validator client stops counting. - Once per epoch, compute
get_validators_custody_requirementand take the larger of the flag, that requirement, and the persisted highest count. Store the highest count in the data directory. - Make the custody set changeable at runtime. Today it is fixed in
BeaconWireand in the chain actor at spawn, and these paths read it: data-column subnet subscriptions, the availability check, req/resp serving, and the engine's custody columns. - When the count changes, bump the MetaData
seq_numberand the ENR. The ENR has the same known gap as the fork digest: ethrex'sDiscoveryServercannot replace the record it serves at runtime, socgcwould stay at its startup value until a restart. - Make MetaData v3 report the real count, and add
custody_group_countto/eth/v1/node/identity. - After an increase, keep
earliest_available_slothonest until backfill completes.
Steps 5 and 1 are small and independent, so they could land first.
- Lingua principale
- Rust
- Stelle
- 86
- Fork
- 34
- Merge medio
- 9g 20h
- PR unite (30g)
- 77
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di lambdaclass/ethlambda
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
lambdaclass/ethlambda#850 ·
I maintainer di solito rispondono entro 6 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
lambdaclass/ethlambda#777 · 1 reazione ·
I maintainer di solito rispondono entro 6 giorni
-
Run all gossip validation testsForse di nuovo libera @dicethedev l’ha presa 9 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
lambdaclass/ethlambda#725 · 2 commenti ·
I maintainer di solito rispondono entro 6 giorni
-
Handle malformed DB dataForse di nuovo libera @dicethedev l’ha presa 115 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
lambdaclass/ethlambda#529 · 4 commenti ·
I maintainer di solito rispondono entro 6 giorni
-
Document architectural choicesForse di nuovo libera @dicethedev l’ha presa 115 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
lambdaclass/ethlambda#521 · 2 commenti ·
I maintainer di solito rispondono entro 6 giorni
Tutte le issue di lambdaclass/ethlambda
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
bytecodealliance/wrpc#1785 ·
I maintainer di solito rispondono entro 1 giorno
-
2 advisory ignore entries no longer match anything (`quick-xml` already patched in `Cargo.lock`)Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
longbridge/nsh#2758 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
antithesishq/bombadil#473 ·
I maintainer di solito rispondono entro 2 giorni
-
bench/api.sh exec test fails with curl exit 52, and --ignore-failure still records the timingsApertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
libracoder/kiri#669 ·
I maintainer di solito rispondono entro 1 giorno