`gh stack view` silently ignores positional arguments, including a valid different stack number
還沒有人認領這個 Issue。
評估
研究方向
從 gh stack view 命令的引數解析開始,重現 issue 中的兩個命令,包括它們的結束狀態和輸出。檢查 gh stack checkout 如何處理 stack 編號,然後為有效和無效的位置引數新增涵蓋測試。完成的標準是該命令不再靜默忽略這些引數:它應該明確拒絕這些引數,或一致地支援 stack 選取。
由索引模型根據 Issue 內容生成。
描述
Summary
gh stack view accepts no positional argument, but supplying one is silently discarded instead of rejected. The harmful case is passing a valid stack number that isn't the current one — you get a different stack's contents, with that stack's number in the header, and no indication your argument was ignored.
On a branch belonging to stack #6, asking for stack #3 (which exists):
$ gh stack view --short 3
Stack #6 <-- rendered #6, not the #3 that was requested
├ stack-b-two ○ #5
» stack-b-one ○ #4 (current)
└ main
$ gh stack view --short garbage999
Stack #6 <-- also silently succeeds
├ stack-b-two ○ #5
» stack-b-one ○ #4 (current)
└ main
Exit status is 0 in both cases.
Why this matters
The output carries a stack number in its header, so it reads as authoritative. Anyone comparing two stacks — or scripting against view — can act on the wrong one without any signal. It is also a natural mistake to make, because gh stack checkout does take a stack number, so the two commands look like they share a selector.
Reproduction
In a repo with two stacks:
git switch <a-branch-in-stack-B>
gh stack view --short <stack-A-number> # shows stack B
gh stack view --short garbage999 # shows stack B
Public repo with two stacks set up for this: https://github.com/xn/gh-stack-repro
Expected
Either error with unknown argument "3" (the usual gh behaviour for unexpected positionals), or accept a stack selector here the way gh stack checkout does. The latter would also give a non-interactive escape hatch for the ambiguity in #415.
Environment
gh2.97.0gh-stackv0.1.0- git 2.50.1
- macOS 26.4.1, darwin/arm64
- 主要語言
- Go
- 星號
- 1.5k
- 分支
- 73
- 平均合併
- 1 天 8 小時
- 30 天內合併 PR
- 7
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
github/gh-stack 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 85/100
-
難度 1/5 1 小時以內 新手友好度 92/100
-
feature request topic: cli - general
難度 2/5 1-3 小時 新手友好度 68/100
-
feature request topic: auto-merge
難度 2/5 1-3 小時 新手友好度 68/100
-
bug topic: docs
難度 1/5 1 小時以內 新手友好度 68/100
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 60/100
github/gh-aw-mcpg#13748 ·
-
agentic-workflows
難度 2/5 1-3 小時 新手友好度 65/100
-
needs-triage
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 65/100
-
難度 2/5 1-3 小時 新手友好度 75/100
googleapis/librarian#7670 · 2 則留言 ·