Retrying within rescue will chain errors and fail to send to Sentry

未關閉
#1,942 1 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

維護者通常 2 天內回覆

@sl0thentr0py 已經在處理了。

開始於 2022年11月21日。

評估

這個 Issue 還沒有評估資料。

描述

Errors Improvement Ruby
Issue Description

I have a method that will try to perform an operation, and if it fails it will attempt it again within the rescue block, up to 20 times, then raises an exception.

What ends up happening is that sentry will end up capturing the chain of 20 exceptions, and each exception will include the entire stack trace when it happened, so it will generate an enormous stack trace. The SDK will then try to crop the stack trace, but fail because while cutting each exception down to 250 frames, we are still left with a total of over 1000 frames and the envelope will be too large to send.

Reproduction Steps
class Chainer
  def chain_errors(n=20)
    raise StandardError.new("Been launched #{n} times")
  rescue StandardError => e
    if n == 0
      Sentry.capture_exception(e)
    else
      chain_errors(n - 1)
    end
  end
end

Then I launch a ruby console and call Chainer.new.chain_errors, which fails and Chainer.new.chain_errors 2, which succeeds

Expected Behavior

I would expect Sentry to perform some sort of logging, either by removing most of the exceptions or by cropping all stack traces further so the error would end up on sentry (maybe this could be a setting). I would also expect that, if that fails, it would throw an error that explains the problem better

Actual Behavior

Sentry will give up after removing the breadcrumbs and cropping the stack traces, and throw a message without much information on the error into the rails logs:
Envelope item [event] is still oversized after size reduction: {event_id: 34, level: 7, timestamp: 22, release: 48, environment: 12, server_name: 14, modules: 11411, message: 2, user: 2, tags: 52, contexts: 993, extra: 2, fingerprint: 2, transaction: 52, transaction_info: 17, platform: 6, sdk: 40, type: 7, threads: 94, exception: 283677}

Ruby Version

2.7.5

SDK Version

5.5.0

Integration and Its Version

No response

Sentry Config

No response

主要語言
Ruby
星號
990
分支
552
平均合併
2 天 16 小時
30 天內合併 PR
29

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

getsentry/sentry-ruby 的其他 Issue

查看 getsentry/sentry-ruby 的全部 Issue

相似的 Issue

更多 Ruby Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。