Let apps choose how the client IP on events is determined
維護者通常 2 天內回覆
@sl0thentr0py 已經在處理了。
開始於 2026年11月4日。
評估
這個 Issue 還沒有評估資料。
描述
Problem Statement
With send_default_pii (data_collection.user_info in 7.x), Event#rack_env= sets user[:ip_address] from Utils::RealIp. It puts Client-IP and X-Real-IP first, then X-Forwarded-For from the right, then REMOTE_ADDR, and takes the first address that isn't a trusted proxy.
Some platforms pass those headers through from the client. Heroku's router, for one, appends the address it saw to X-Forwarded-For and passes Client-IP and X-Real-IP on as the client sent them. A client that sends Client-IP: 198.51.100.2 gets that address on its events, and the address the router saw is never used. trusted_proxies can't help: it only removes the listed proxies' addresses from those candidates, and the Client-IP value is whatever the client wrote, not a proxy, so it stays first.
real_ip.rb says spoofing "only makes data inaccurate, not insecure", and accuracy is the problem here: on such a platform the IP on an event is whatever the client chose. Only the app knows its topology, and so which header to read: the last X-Forwarded-For entry on Heroku, Fly-Client-IP on Fly.io, CF-Connecting-IP behind Cloudflare.
The only way we found that keeps the SDK's own rules is to override the private Event#calculate_real_ip_from_rack(env):
module ClientIP
private
def calculate_real_ip_from_rack(env)
env["HTTP_X_FORWARDED_FOR"]&.split(",")&.last&.strip # Heroku
end
end
Sentry::Event.prepend(ClientIP)
The SDK still decides when an event gets an address, and keeps one set with Sentry.set_user (#2350). But the method is private: a rename quietly brings back the header-based address, and a new argument makes every event from a web request fail to build, so capture_event drops it. The public alternatives fall short. A global event processor has to repeat the SDK's rules for each version, and in 5.x it also receives LogEvents, which have no request. Sentry.set_user(ip_address: ...) is replaced by any later set_user call in the app.
Solution Brainstorm
A supported way for the app to supply the address, called where calculate_real_ip_from_rack is today, so the SDK's checks stay as they are. For example, a callable:
Sentry.init do |config|
config.send_default_pii = true
# Called with the Rack env when the SDK adds the user's IP address
config.real_ip = ->(env) { env["HTTP_X_FORWARDED_FOR"]&.split(",")&.last&.strip }
end
That would also cover #2592: an app whose clients are on a private network could return their address without changing how trusted_proxies and LOCAL_ADDRESSES work for everyone else. A narrower option that picks the headers RealIp reads would fix the precedence, but not #2592.
We checked sentry-ruby 5.25, 5.28, 6.7 and 7.2, which all work out the address this way.
- 主要語言
- Ruby
- 星號
- 990
- 分支
- 552
- 平均合併
- 2 天 16 小時
- 30 天內合併 PR
- 29
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
getsentry/sentry-ruby 的其他 Issue
-
Bug Ruby
難度 2/5 1-3 小時 新手友好度 76/100
getsentry/sentry-ruby#3211 · 1 則留言 ·
維護者通常 2 天內回覆
-
Events dropped client-side for size are only logged at debug level and not recorded as lost可能已有人在做 @sentry-junior 今天認領。 未關閉Bug Junior: repro Ruby
難度 2/5 1-3 小時 新手友好度 76/100
getsentry/sentry-ruby#3209 · 2 則留言 · 1 個 reaction ·
維護者通常 2 天內回覆
-
with_child_span drops spans when blocks exit via break, return, or throw可能已有人在做 @itsrayeedscodespace 於 1 天前認領。 未關閉Bug Ruby Traces Waiting for: Product Owner
難度 2/5 1-3 小時 新手友好度 38/100
getsentry/sentry-ruby#3206 · 1 則留言 ·
維護者通常 2 天內回覆
-
breaking change Next Major
難度 2/5 1-3 小時 新手友好度 58/100
getsentry/sentry-ruby#3176 · 1 則留言 ·
維護者通常 2 天內回覆
-
With `register_error_subscriber`, view errors are reported twice: the wrapper by the middleware, and its cause by the error subscriber可能已有人在做 @sl0thentr0py 於 13 天前認領。 未關閉Bug Ruby
難度 4/5 1-2 天 新手友好度 57/100
getsentry/sentry-ruby#3166 · 1 則留言 · 已指派 1 人 ·
維護者通常 2 天內回覆
查看 getsentry/sentry-ruby 的全部 Issue
相似的 Issue
-
enhancement
難度 2/5 1-3 小時 新手友好度 66/100
internetee/registry#2984 ·
維護者通常 6 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
ecosyste-ms/issues#862 ·
維護者通常 1 天內回覆
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configured可能已有人在做 @mimosa 今天認領。 未關閉bug
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 67/100
riscv/riscv-unified-db#2829 ·
維護者通常 1 天內回覆
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
難度 2/5 1-3 小時 新手友好度 82/100
rubyforgood/casa#7404 ·
維護者通常 1 天內回覆