[coverage] Conformance findings: TELEMETRY-001,TELEMETRY-002,TELEMETRY-005
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 52/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- nodejs, sql, typescript
研究方向
先從 issue 中對 TelemetryEvent 和 emitStatementComplete 的參照開始,接著檢查 driver 程式碼以及 coverage PR 中列出的 xfail 測試。針對 thrift 和 sea 分別重現 TELEMETRY-001、TELEMETRY-002 與 TELEMETRY-005 案例。完成的標準是:終端事件回報傳遞格式與壓縮,而錯誤 telemetry 使用不含 SQL 衍生文字的已清理類別。
由索引模型根據 Issue 內容生成。
描述
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-nodejs. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-nodejs) is fixed, then flips green as a tripwire.
Findings
- TELEMETRY-001 [thrift, sea]: the terminal statement.complete telemetry event never populates resultFormat or compressed, so the inline-Arrow delivery shape and uncompressed payload are never reported
- failing test:
TELEMETRY-001 — successful sync execute emits exactly one terminal event with operation metadata [thrift], TELEMETRY-001 — successful sync execute emits exactly one terminal event with operation metadata [sea](see the coverage PR diff undertests/)
- failing test:
- TELEMETRY-002 [thrift, sea]: statement error telemetry copies the raw server error message and JS stack verbatim, leaking SQL-derived identifiers (sensitive_table) out of the customer process instead of a sanitized error category
- failing test:
TELEMETRY-002 — failed statement emits sanitized error telemetry without SQL text [thrift], TELEMETRY-002 — failed statement emits sanitized error telemetry without SQL text [sea](see the coverage PR diff undertests/)
- failing test:
- TELEMETRY-005 [thrift, sea]: for a CloudFetch/external-links result the terminal event still reports no resultFormat/compressed, so EXTERNAL_LINKS delivery and server-declared compression are indistinguishable from an inline result
- failing test:
TELEMETRY-005 — telemetry reports external-links delivery and compression [thrift], TELEMETRY-005 — telemetry reports external-links delivery and compression [sea](see the coverage PR diff undertests/)
- failing test:
- TELEMETRY-002: statement error telemetry copies the raw server error message and JS stack verbatim into errorMessage/errorStack, leaking SQL-derived identifiers (table/column names, and any literals the server quotes) out of the customer process; the error descriptor should be sanitized to an aggregatable category/name
- TELEMETRY-001: the terminal statement.complete telemetry event never populates resultFormat or compressed (both are declared on TelemetryEvent and accepted by emitStatementComplete), so the result-delivery shape of an inline result (INLINE_ARROW, uncompressed) is never reported and downstream delivery-shape aggregates are blind
- TELEMETRY-005: for a CloudFetch/external-links result the terminal statement.complete event still reports no resultFormat/compressed, so EXTERNAL_LINKS delivery and the server-declared LZ4_FRAME compression are never distinguishable from an inline result in telemetry
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-sql-kernel/pull/272 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-nodejs; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1389
- 主要語言
- TypeScript
- 星號
- 37
- 分支
- 51
- 平均合併
- 5 小時 56 分鐘
- 30 天內合併 PR
- 9
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
databricks/databricks-sql-nodejs 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
databricks/databricks-sql-nodejs#526 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
databricks/databricks-sql-nodejs#503 ·
維護者通常 1 天內回覆
-
engineer-bot
難度 2/5 1-3 小時 新手友好度 64/100
databricks/databricks-sql-nodejs#274 · 1 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 68/100
databricks/databricks-sql-nodejs#525 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 35/100
databricks/databricks-sql-nodejs#524 ·
維護者通常 1 天內回覆
查看 databricks/databricks-sql-nodejs 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 67/100
ehmpathy/rhachet-roles-bhrain#586 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 65/100
OHDSI/Data2Evidence#3496 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
apache/rocketmq-dashboard#5594 ·
維護者通常 3 天內回覆
-
react-doctor severity:warning tech-debt
難度 1/5 1 小時以內 新手友好度 88/100
digidem/comapeo-cloud-app#418 ·
維護者通常 1 天內回覆