Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

`UpdateApp` masks `compute_size` unconditionally while `omitempty` drops it from the body

未關閉
#6,400 4 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

維護者通常 1 天內回覆

@andrewnester 已經在處理了。

開始於 2026年8月28日。

評估

這個 Issue 還沒有評估資料。

描述

DABs Question

CLI version: v1.14.0 (also present on v1.13.0)
Engine: direct

Summary

The CLI sends a fixed update_mask on every UpdateApp call, independent of what the bundle declares or what actually changed. compute_size is always in it. But the SDK field is compute_size,omitempty, so when the bundle does not declare a compute size the field is absent from the request body — the request asks the backend to update a field it does not supply.

Evidence

Both halves are captured requests, not inference. Taken with --debug and DATABRICKS_DEBUG_TRUNCATE_BYTES=20000 (the default truncation hides the tail where update_mask lives).

With compute_size: MEDIUM declared — value present, mask lists it:

{
  "app": {
    "compute_size": "MEDIUM",
    "description": "...",
    "name": "<app>",
    "resources": [ ... ],
    "source_code_path": ""
  },
  "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,forward_user_access_token,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
}

With the declaration removed — same bundle, same target, only that line deleted. The body now has no compute_size key at all, and the mask is byte-identical, still naming it:

{
  "app": {
    "description": "...",
    "name": "<app>",
    "resources": [ ... ],
    "source_code_path": ""
  },
  "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,forward_user_access_token,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
}

So the mask is a fixed list rather than being derived from what the request actually carries.

The direct engine's own embedded resources.generated.yml already classifies the field as a backend default:

  apps:
    backend_defaults:
      # Backend sets it "MEDIUM" when not specified in the config
      - field: compute_size

So the CLI knows compute_size is a backend default for diffing, and still masks it for update. compute_min_instances and compute_max_instances are in the mask on the same terms and are worth checking alongside it.

Why plan cannot show this

bundle plan correctly reports compute_size as {"action":"skip","reason":"backend_default"}. The differ is not what is inconsistent — the update payload is, and plan never renders a payload. Any bug of this shape is invisible to the documented pre-deploy gate.

Suggested fix

Build the update_mask from the fields actually present in the serialised body, or drop backend_defaults fields from the mask when the config does not declare them — the same treatment PR #5042 gave deploy-only fields.

What we are NOT claiming

We have not observed the backend mishandling the masked-but-absent field. The undeclared payload above was captured on v1.14.0, where the request is rejected with a 400 on an unrelated field (source_code_path, reported separately) before the backend acts on the mask — so what this service does with "update compute_size" plus no value is untested here.

Nor is this the explanation for the Unexpectedly failed to update app's compute size errors, which is where the tempting story leads. Three consecutive deploys on 2026-08-27 with compute_size declared and present in the body produced a Lakebase grant timeout (deadline exceeded after 998000000ns), then that compute-size message, then a clean success — same config, minutes apart. That reads as a flaky async update path, not as this payload bug, and an earlier internal write-up that claimed otherwise was withdrawn on this evidence.

This report is about payload correctness only: the mask names a field the request does not carry.

主要語言
Go
星號
405
分支
250
平均合併
1 天 11 小時
30 天內合併 PR
236

環境準備

  • 提供 Dockerfile 或 Docker Compose 檔案
  • 有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

databricks/cli 的其他 Issue

查看 databricks/cli 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。