Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

`UpdateApp` masks `compute_size` unconditionally while `omitempty` drops it from the body

Đang mở
  • Có gì không ổn?
#6,400 4 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@andrewnester đang làm issue này rồi.

Từ ngày 28/8/2026.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

DABs Question

CLI version: v1.14.0 (also present on v1.13.0)
Engine: direct

Summary

The CLI sends a fixed update_mask on every UpdateApp call, independent of what the bundle declares or what actually changed. compute_size is always in it. But the SDK field is compute_size,omitempty, so when the bundle does not declare a compute size the field is absent from the request body — the request asks the backend to update a field it does not supply.

Evidence

Both halves are captured requests, not inference. Taken with --debug and DATABRICKS_DEBUG_TRUNCATE_BYTES=20000 (the default truncation hides the tail where update_mask lives).

With compute_size: MEDIUM declared — value present, mask lists it:

{
  "app": {
    "compute_size": "MEDIUM",
    "description": "...",
    "name": "<app>",
    "resources": [ ... ],
    "source_code_path": ""
  },
  "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,forward_user_access_token,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
}

With the declaration removed — same bundle, same target, only that line deleted. The body now has no compute_size key at all, and the mask is byte-identical, still naming it:

{
  "app": {
    "description": "...",
    "name": "<app>",
    "resources": [ ... ],
    "source_code_path": ""
  },
  "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,forward_user_access_token,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
}

So the mask is a fixed list rather than being derived from what the request actually carries.

The direct engine's own embedded resources.generated.yml already classifies the field as a backend default:

  apps:
    backend_defaults:
      # Backend sets it "MEDIUM" when not specified in the config
      - field: compute_size

So the CLI knows compute_size is a backend default for diffing, and still masks it for update. compute_min_instances and compute_max_instances are in the mask on the same terms and are worth checking alongside it.

Why plan cannot show this

bundle plan correctly reports compute_size as {"action":"skip","reason":"backend_default"}. The differ is not what is inconsistent — the update payload is, and plan never renders a payload. Any bug of this shape is invisible to the documented pre-deploy gate.

Suggested fix

Build the update_mask from the fields actually present in the serialised body, or drop backend_defaults fields from the mask when the config does not declare them — the same treatment PR #5042 gave deploy-only fields.

What we are NOT claiming

We have not observed the backend mishandling the masked-but-absent field. The undeclared payload above was captured on v1.14.0, where the request is rejected with a 400 on an unrelated field (source_code_path, reported separately) before the backend acts on the mask — so what this service does with "update compute_size" plus no value is untested here.

Nor is this the explanation for the Unexpectedly failed to update app's compute size errors, which is where the tempting story leads. Three consecutive deploys on 2026-08-27 with compute_size declared and present in the body produced a Lakebase grant timeout (deadline exceeded after 998000000ns), then that compute-size message, then a clean success — same config, minutes apart. That reads as a flaky async update path, not as this payload bug, and an earlier internal write-up that claimed otherwise was withdrawn on this evidence.

This report is about payload correctness only: the mask names a field the request does not carry.

Ngôn ngữ chính
Go
Star
405
Fork
250
Merge trung bình
1 ngày 11 giờ
Pull request đã merge (30 ngày)
236

Chuẩn bị môi trường

  • Có Dockerfile hoặc tệp Docker Compose
  • Có mẫu pull request
  • Không có hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của databricks/cli

Tất cả issue của databricks/cli

Issue tương tự

Thêm issue về Go

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.