Dart: analysis_options `include:` in list form or an explicit rule list is "no lint set"; Flutter integration tests under example/integration_test are not tests

未關閉
#258 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
55/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
dart, python
領域
devtools, testing

研究方向

The three false negatives all come from checks in project_validator/ecosystems/dart.py: the LINT_SET regex near lines 149-150 (which does not recognise the dart-lang team lint set or the list form of include:), and the test-path regex at line 73 (which does not match integration_test/). Start by reproducing each case with a small analysis_options.yaml or example/integration_test/ fixture and the existing Dart tests. Done means the three repositories cited in the issue pass those checks without loosening the existing negative cases.

由索引模型根據 Issue 內容生成。

描述

dart-lang/http's root options include the dart-lang team lint set (which includes lints/recommended) and enable the strict modes, yet compiler-warnings FAILs "missing a lint set in analysis_options.yaml"; bloc's root file spells out ~200 rules with no include:, and its package files use the Dart 3 list form of include:, which the single-line regex ^include:\s*package: misses. http's Flutter plugins (cronet_http, ok_http) keep their tests in example/integration_test/*_test.dart and CI runs them on an emulator → "no tests found".

Evidence from the corpus audit

dart-lang/http / compiler-warnings
  • kind: FALSE_NEGATIVE
  • actual: FAIL: Dart: missing Dart analyzer settings: a lint set in analysis_options.yaml
  • expected: PASS: the root analysis_options.yaml includes the dart-lang team lint set (which itself includes
    lints/recommended) and enables the three strict modes, and every workflow runs dart analyze.
  • evidence: analysis_options.yaml:1: include: package:dart_flutter_team_lints/analysis_options.yaml;
    analysis_options.yaml:5-7: strict-casts: true / strict-raw-types: true / strict-inference: true;
    validator project_validator/ecosystems/dart.py:149-150: the LINT_SET regex only knows
    lints/recommended|flutter_lints/flutter|very_good_analysis/analysis_options|lint/...|pedantic/analysis_options.
  • repro: analysis_options.yaml with include: package:dart_flutter_team_lints/analysis_options.yaml + a workflow
    step run: dart analyze --fatal-infos.
  • confidence: high
felangel/bloc / compiler-warnings
  • kind: FALSE_NEGATIVE
  • actual: FAIL: Dart: missing Dart analyzer settings: a lint set in analysis_options.yaml
  • expected: PASS (or at least not "missing"): the root options file has no include: but spells out ~200 lint rules
    plus the strict modes; the package files include a lint set with the list form of include: (Dart 3.x), which the
    single-line regex ^include:\s*package: does not match.
  • evidence: analysis_options.yaml:8-10: strict-casts: true / strict-inference: true / strict-raw-types: true;
    analysis_options.yaml:22-24: linter: / rules: / - always_declare_return_types (and ~200 more);
    packages/bloc/analysis_options.yaml:1-3: include: / - package:bloc_lint/recommended.yaml /
    - ../../analysis_options.yaml.
  • repro: analysis_options.yaml containing include:\n - package:lints/recommended.yaml (list form).
  • confidence: medium
dart-lang/http / tests-run
  • kind: FALSE_NEGATIVE
  • actual: FAIL: Dart: pkgs/cronet_http: no tests found (test(), testWidgets() or group() calls in test/**/*_test.dart);
    pkgs/ok_http: no tests found (...)
  • expected: PASS for both: the Flutter plugins' tests are integration tests in example/integration_test/*_test.dart
    and CI runs them on an emulator.
  • evidence: pkgs/cronet_http/example/integration_test/client_test.dart, pkgs/ok_http/example/integration_test/client_test.dart
    (5 files) exist; .github/workflows/cronet.yml:119: script: cd pkgs/cronet_http/example && flutter test --dart-define=cronetHttpNoPlay=${{ matrix.cronetHttpNoPlay }} --timeout=1200s integration_test/;
    .github/workflows/okhttp.yaml:68: script: cd pkgs/ok_http/example && flutter test --timeout=1200s integration_test/;
    validator project_validator/ecosystems/dart.py:73: path=re.compile(r"(?:^|/)test/.+_test\.dart$") (does not
    match integration_test/). The script: input of reactivecircus/android-emulator-runner is neither read nor
    reported as unread (strict run lists only the dart-lang/ecosystem reusable workflows).
  • repro: example/integration_test/a_test.dart with testWidgets(, and a step
    uses: reactivecircus/android-emulator-runner@<sha> with script: cd example && flutter test integration_test/.
  • confidence: high

Found by the regression-corpus audit (235 real repositories, one or more per ecosystem profile; corpus and expected results in corpus/). Evidence is quoted from the audited checkouts at the commits pinned in corpus/projects.toml; <checkouts>/<owner>__<repo> is such a checkout.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ByTXNqDWdM7HzezrFtEvQt

主要語言
Python
星號
4
分支
1
平均合併
10 小時 41 分鐘
30 天內合併 PR
79

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

cpp-best-practices/project_validator 的其他 Issue

查看 cpp-best-practices/project_validator 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。