Dart: analysis_options `include:` in list form or an explicit rule list is "no lint set"; Flutter integration tests under example/integration_test are not tests

Aperta
  • Qualcosa non va?
#258 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
dart, python
Ambito
devtools, testing

Direzione di ricerca

The three false negatives all come from checks in project_validator/ecosystems/dart.py: the LINT_SET regex near lines 149-150 (which does not recognise the dart-lang team lint set or the list form of include:), and the test-path regex at line 73 (which does not match integration_test/). Start by reproducing each case with a small analysis_options.yaml or example/integration_test/ fixture and the existing Dart tests. Done means the three repositories cited in the issue pass those checks without loosening the existing negative cases.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

dart-lang/http's root options include the dart-lang team lint set (which includes lints/recommended) and enable the strict modes, yet compiler-warnings FAILs "missing a lint set in analysis_options.yaml"; bloc's root file spells out ~200 rules with no include:, and its package files use the Dart 3 list form of include:, which the single-line regex ^include:\s*package: misses. http's Flutter plugins (cronet_http, ok_http) keep their tests in example/integration_test/*_test.dart and CI runs them on an emulator → "no tests found".

Evidence from the corpus audit

dart-lang/http / compiler-warnings
  • kind: FALSE_NEGATIVE
  • actual: FAIL: Dart: missing Dart analyzer settings: a lint set in analysis_options.yaml
  • expected: PASS: the root analysis_options.yaml includes the dart-lang team lint set (which itself includes
    lints/recommended) and enables the three strict modes, and every workflow runs dart analyze.
  • evidence: analysis_options.yaml:1: include: package:dart_flutter_team_lints/analysis_options.yaml;
    analysis_options.yaml:5-7: strict-casts: true / strict-raw-types: true / strict-inference: true;
    validator project_validator/ecosystems/dart.py:149-150: the LINT_SET regex only knows
    lints/recommended|flutter_lints/flutter|very_good_analysis/analysis_options|lint/...|pedantic/analysis_options.
  • repro: analysis_options.yaml with include: package:dart_flutter_team_lints/analysis_options.yaml + a workflow
    step run: dart analyze --fatal-infos.
  • confidence: high
felangel/bloc / compiler-warnings
  • kind: FALSE_NEGATIVE
  • actual: FAIL: Dart: missing Dart analyzer settings: a lint set in analysis_options.yaml
  • expected: PASS (or at least not "missing"): the root options file has no include: but spells out ~200 lint rules
    plus the strict modes; the package files include a lint set with the list form of include: (Dart 3.x), which the
    single-line regex ^include:\s*package: does not match.
  • evidence: analysis_options.yaml:8-10: strict-casts: true / strict-inference: true / strict-raw-types: true;
    analysis_options.yaml:22-24: linter: / rules: / - always_declare_return_types (and ~200 more);
    packages/bloc/analysis_options.yaml:1-3: include: / - package:bloc_lint/recommended.yaml /
    - ../../analysis_options.yaml.
  • repro: analysis_options.yaml containing include:\n - package:lints/recommended.yaml (list form).
  • confidence: medium
dart-lang/http / tests-run
  • kind: FALSE_NEGATIVE
  • actual: FAIL: Dart: pkgs/cronet_http: no tests found (test(), testWidgets() or group() calls in test/**/*_test.dart);
    pkgs/ok_http: no tests found (...)
  • expected: PASS for both: the Flutter plugins' tests are integration tests in example/integration_test/*_test.dart
    and CI runs them on an emulator.
  • evidence: pkgs/cronet_http/example/integration_test/client_test.dart, pkgs/ok_http/example/integration_test/client_test.dart
    (5 files) exist; .github/workflows/cronet.yml:119: script: cd pkgs/cronet_http/example && flutter test --dart-define=cronetHttpNoPlay=${{ matrix.cronetHttpNoPlay }} --timeout=1200s integration_test/;
    .github/workflows/okhttp.yaml:68: script: cd pkgs/ok_http/example && flutter test --timeout=1200s integration_test/;
    validator project_validator/ecosystems/dart.py:73: path=re.compile(r"(?:^|/)test/.+_test\.dart$") (does not
    match integration_test/). The script: input of reactivecircus/android-emulator-runner is neither read nor
    reported as unread (strict run lists only the dart-lang/ecosystem reusable workflows).
  • repro: example/integration_test/a_test.dart with testWidgets(, and a step
    uses: reactivecircus/android-emulator-runner@<sha> with script: cd example && flutter test integration_test/.
  • confidence: high

Found by the regression-corpus audit (235 real repositories, one or more per ecosystem profile; corpus and expected results in corpus/). Evidence is quoted from the audited checkouts at the commits pinned in corpus/projects.toml; <checkouts>/<owner>__<repo> is such a checkout.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ByTXNqDWdM7HzezrFtEvQt

Lingua principale
Python
Stelle
4
Fork
1
Merge medio
10h 41m
PR unite (30g)
79

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cpp-best-practices/project_validator

Tutte le issue di cpp-best-practices/project_validator

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.