Text and button items of one compact row draw at different heights: reset 'font: inherit' resets line-height, no shared item primitive

未關閉
#1,335 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
54/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
typescript
領域
design, frontend

研究方向

Start by reading styles/reset.css and the existing Chip, Badge, StatusChip, and Button implementations to understand the kit’s item patterns. Then check the theming guide and layout test setup; the issue calls for a shared text and button item primitive with a test showing both variants align, plus documentation of the font: inherit ordering. Done means the variants share a text top in the layout test and the shorthand behavior is documented.

由索引模型根據 Issue 內容生成。

描述

area:theme bug

What happens

Items of one compact row that mix element types, a text <span> and <button> actions (a status bar: Spaces: 2, UTF-8, LF, JSON), draw their text at different heights. Seen in Atlas Desktop's editor status bar: UTF-8 (a <span>) was 3.25 px higher than the buttons (WebKit, Range.getBoundingClientRect().top: 8.98 vs 12.23 for an 18px box, 11.5px font).

Root cause

Two kit behaviours combine, and the kit has nothing that owns the shape:

  1. styles/reset.css:1 (installed 4.6.0): button,input,select,textarea{font:inherit}. font is a shorthand and resets line-height, so every button takes its parent's line-height instead of the UA's normal. In a compact row (line-height: 1) a button's line box is the font height, and the UA centres a button's content vertically in its box; a <span> has no such centring and puts the line at the top of its box. In a fixed-height item (height: 18px) the two differ by (height - line box) / 2.
  2. An app that writes line-height: 18px before font: inherit (the natural order when starting from the reset) silently loses the first: the same shorthand-resets-longhand trap, one level up. Atlas did exactly that.

The kit ships no primitive for "one box for text and action items in a row" (Chip is a pill with its own height tokens, Badge/StatusChip are not actionable, Button brings padding and min touch height), so each app writes the box by hand and gets this wrong.

Minimal reproduction

<style>
  .row { display: flex; align-items: center; line-height: 1; font-size: 11.5px }
  .item { display: block; height: 18px; line-height: 18px; padding: 0 6px; border: 0; background: none; font: inherit }
</style>
<div class="row"><button class="item">Spaces: 2</button><span class="item">UTF-8</span></div>

WebKit: the button's text top is 12.23, the span's 8.98 (the font shorthand cancels line-height: 18px).

Expected

Either a documented, tested primitive (e.g. InlineItem / StatusBarItem: button and span variants, display: inline-flex; align-items: center; height; line-height after font), or at least a note in the theming guide about font: inherit in the reset and compact rows.

Proposed fix

Add the primitive to the kit with a layout test (both variants have the same text top), and keep reset.css as it is but document the shorthand/longhand order. If preferred, change the reset to font-family: inherit; font-size: inherit; font-weight: inherit so a button keeps line-height: normal... (breaking for apps relying on the inherit; hence the primitive/doc option first).

Workaround in Atlas

codeatlasdev/atlas#504: one StatusItem.svelte primitive (span or button, shared box, line-height after font) used by every status bar item including the language-server trigger; statusBaseline.test.ts pins it. Documented with the removal condition in docs/desktop.md ("UI kit workarounds").

主要語言
TypeScript
星號
6
分支
3
平均合併
5 小時 21 分鐘
30 天內合併 PR
378

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

codeatlasdev/ui 的其他 Issue

查看 codeatlasdev/ui 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。