Text and button items of one compact row draw at different heights: reset 'font: inherit' resets line-height, no shared item primitive
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 54/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- typescript
Línea de trabajo
Start by reading styles/reset.css and the existing Chip, Badge, StatusChip, and Button implementations to understand the kit’s item patterns. Then check the theming guide and layout test setup; the issue calls for a shared text and button item primitive with a test showing both variants align, plus documentation of the font: inherit ordering. Done means the variants share a text top in the layout test and the shorthand behavior is documented.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What happens
Items of one compact row that mix element types, a text <span> and <button> actions (a status bar: Spaces: 2, UTF-8, LF, JSON), draw their text at different heights. Seen in Atlas Desktop's editor status bar: UTF-8 (a <span>) was 3.25 px higher than the buttons (WebKit, Range.getBoundingClientRect().top: 8.98 vs 12.23 for an 18px box, 11.5px font).
Root cause
Two kit behaviours combine, and the kit has nothing that owns the shape:
styles/reset.css:1(installed 4.6.0):button,input,select,textarea{font:inherit}.fontis a shorthand and resetsline-height, so every button takes its parent'sline-heightinstead of the UA'snormal. In a compact row (line-height: 1) a button's line box is the font height, and the UA centres a button's content vertically in its box; a<span>has no such centring and puts the line at the top of its box. In a fixed-height item (height: 18px) the two differ by(height - line box) / 2.- An app that writes
line-height: 18pxbeforefont: inherit(the natural order when starting from the reset) silently loses the first: the same shorthand-resets-longhand trap, one level up. Atlas did exactly that.
The kit ships no primitive for "one box for text and action items in a row" (Chip is a pill with its own height tokens, Badge/StatusChip are not actionable, Button brings padding and min touch height), so each app writes the box by hand and gets this wrong.
Minimal reproduction
<style>
.row { display: flex; align-items: center; line-height: 1; font-size: 11.5px }
.item { display: block; height: 18px; line-height: 18px; padding: 0 6px; border: 0; background: none; font: inherit }
</style>
<div class="row"><button class="item">Spaces: 2</button><span class="item">UTF-8</span></div>
WebKit: the button's text top is 12.23, the span's 8.98 (the font shorthand cancels line-height: 18px).
Expected
Either a documented, tested primitive (e.g. InlineItem / StatusBarItem: button and span variants, display: inline-flex; align-items: center; height; line-height after font), or at least a note in the theming guide about font: inherit in the reset and compact rows.
Proposed fix
Add the primitive to the kit with a layout test (both variants have the same text top), and keep reset.css as it is but document the shorthand/longhand order. If preferred, change the reset to font-family: inherit; font-size: inherit; font-weight: inherit so a button keeps line-height: normal... (breaking for apps relying on the inherit; hence the primitive/doc option first).
Workaround in Atlas
codeatlasdev/atlas#504: one StatusItem.svelte primitive (span or button, shared box, line-height after font) used by every status bar item including the language-server trigger; statusBaseline.test.ts pins it. Documented with the removal condition in docs/desktop.md ("UI kit workarounds").
- Lenguaje dominante
- TypeScript
- Estrellas
- 6
- Forks
- 3
- Merge medio
- 5 h 21 min
- PR fusionados (30 d)
- 378
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de codeatlasdev/ui
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
codeatlasdev/ui#1340 ·
Los mantenedores suelen responder en 1 día
-
area:a11y area:components bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
codeatlasdev/ui#1336 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
codeatlasdev/ui#1329 ·
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
codeatlasdev/ui#1292 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
area:components enhancement good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
codeatlasdev/ui#1198 ·
Los mantenedores suelen responder en 1 día
Todos los issues de codeatlasdev/ui
Issues similares
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 86/100
sandbox-quantum/switch#2163 ·
Los mantenedores suelen responder en 1 día
-
automated issue report
Dificultad 1/5 Menos de una hora Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
area/dashboard kind/bug QA/dev-automation
Dificultad 1/5 Menos de una hora Aptitud para principiantes 75/100
Los mantenedores suelen responder en 1 día
-
bug pydanty:is-working
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
pydantic/pydantic-ai#13939 ·
Los mantenedores suelen responder en 1 día
-
self-host
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
funmusicplace/mirlo#2625 ·
Los mantenedores suelen responder en 1 día