Script loader retry rejection is unhandled even after readiness resolves

未關閉
#10,483 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍

研究方向

Start with packages/shared/src/loadClerkJsScript.ts, especially the JS and UI loader sections cited in the issue, and compare how their readiness and retry promises settle. Run the linked three-file reproduction with pnpm repro js late-success, pnpm repro ui late-success, and pnpm repro js failure. Done means the readiness deadline and late recovery behavior are preserved, terminal failures do not create detached unhandled rejections, and genuine failure causes remain useful.

由索引模型根據 Issue 內容生成。

描述

Preliminary Checks
  • Reviewed the SDK source and the documentation for <ClerkFailed>.
  • Searched existing issues and pull requests for failed_to_load_clerk_js, loadClerkJsScript, and script/promise rejection reports.
  • This investigation has not also been sent to Clerk support or Discord.
  • This is a reproducible SDK bug report, not a general support question.
Reproduction

https://gist.github.com/ezhong0/340ae2483c3ccb40cc5865171c2b4858

A standalone three-file reproduction using the real published @clerk/shared package, fake DOM objects, and fake timers. It makes no network requests and requires no real Clerk application, browser, or credentials. The unhandledRejection listener observes the bug; it is not proposed as an application workaround.

Publishable key

pk_test_cHJvYmUuY2xlcmsuYWNjb3VudHMuZGV2JA==

This is a synthetic, parseable key for probe.clerk.accounts.dev, not a real application key. Script events are simulated locally.

Description

loadClerkJSScript / its loadClerkJsScript alias start a readiness promise and a script-load/retry promise, but return only readiness. The retry chain's catch throws into a detached promise. Consequently, a caller that handles both fulfillment and rejection of the returned promise can still receive an unhandled failed_to_load_clerk_js rejection. This also occurs after the returned promise has already resolved when another script makes Clerk available while the original retries remain outstanding.

The same pattern is present in loadClerkUIScript, producing failed_to_load_clerk_ui.

Current source inspected at 6c1b46a403e6883066cad1f9d8da9ef77364c940:

Steps to reproduce:

  1. Download the three gist files into an empty directory.
  2. Run pnpm install --ignore-scripts.
  3. Run pnpm repro js late-success or pnpm repro ui late-success.
  4. For the no-recovery case, run pnpm repro js failure.

The late-success scenario simulates the Clerk global becoming available at 100ms while each pending script attempt reports an error at 200ms. Fake time advances far enough to settle the existing retry budget and readiness timeout. Both handlers are attached to the returned operation immediately.

Expected behavior:

Once readiness resolves, the operation stays successful and remaining script failures do not generate unhandled rejections. If Clerk never becomes ready, the returned operation rejects without a second, detached rejection.

Actual behavior with unmodified @clerk/shared 4.43.0:

{"kind":"js","scenario":"late-success","result":"resolved","attempts":6,"unhandled":["failed_to_load_clerk_js"]}
{"kind":"ui","scenario":"late-success","result":"resolved","attempts":6,"unhandled":["failed_to_load_clerk_ui"]}
{"kind":"js","scenario":"failure","result":"failed_to_load_clerk_js","attempts":6,"unhandled":["failed_to_load_clerk_js"]}

The JS case was also reproduced against 3.47.7. This report concerns promise ownership; it does not assert that the SDK causes the underlying network failure.

Follow-up investigation and correction to the proposed fix (2026-10-28):

The detached rejection also reproduces in a real browser with real HTTP 404 responses and real timers, using the published 3.47.7 loader through the actual @clerk/clerk-react 5.61.8 provider. The provider reaches status error and renders ClerkFailed after catching/logging the readiness timeout, but a separate failed_to_load_clerk_js still reaches window.unhandledrejection. This does not require an application-supplied duplicate provider or a fake DOM.

A separate browser case in both 3.47.7 and 4.43.0 used a successful second script response to create the expected Clerk global while the original script requests failed. The returned readiness promise resolved; the original retry chain subsequently produced the unhandled rejection. This proves the loader sequence, not successful real-account authentication or the cause of any external network outage.

I am withdrawing the simple Promise.race([loadPromise, scriptPromise]) proposal as a ready-to-use fix. Further testing exposed a semantic regression: retries can finish before the readiness deadline, while another script can still make Clerk available before that deadline. In an isolated 3.47.7 comparison with readiness at 10 seconds and a 15-second deadline, the original loader resolved at 10 seconds, but the race patch rejected at approximately 6.5 seconds and could not recover. The earlier checks covered readiness before retry exhaustion and missed this ordering.

An upstream fix should preserve the readiness deadline/recovery contract, own the retry rejection, and retain useful error/cause reporting for genuine terminal failures. Simply consuming the global rejection can also affect observability because the React provider handles the returned rejection with console.error; consumers may monitor runtime errors separately from console logs.

Opening this for maintainer guidance on those semantics before contributing a source PR. A compatible shared 3.x backport would also help applications on Next.js SDK 6.x. The issue remains the detached rejection, not a claim that the SDK causes underlying network delivery failures.

Environment
  • Ubuntu 24.04.4 LTS, x86_64
  • Node 24.22.0
  • pnpm 10.33.0
  • @clerk/shared 4.43.0 (standalone reproduction)
  • @sinonjs/fake-timers 15.4.0
  • No browser: synthetic DOM and timers, invoking the published SDK export
主要語言
TypeScript
星號
1.8k
分支
492
平均合併
1 天 7 小時
30 天內合併 PR
357

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

clerk/javascript 的其他 Issue

查看 clerk/javascript 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。