<SignIn />: the reset password code step renders an empty, focusable back button with no accessible name

未關閉 適合新手
  • 哪裡不對？
#10,708 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
85/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
react, typescript
領域
accessibility, authentication

研究方向

閱讀 packages/ui/src/components/SignIn/SignInFactorOneForgotPasswordCard.tsx，並追蹤它如何向驗證碼卡片提供 props。Issue 指出缺少 backLinkLabel，並建議使用本地化的返回按鈕標籤；檢查 VerificationCodeCard.tsx 中的相關程式碼以及登入密碼重設流程。重設驗證碼步驟具有可存取的返回按鈕名稱，且按鈕名稱相關的無障礙違規已解決，即為完成。

由索引模型根據 Issue 內容生成。

描述

Preliminary Checks
Reproduction

https://upward-hare-2386.accounts.dev/sign-in

Publishable key

pk_test_dXB3YXJkLWhhcmUtMjM4Ni5jbGVyay5hY2NvdW50cy5kZXYk

Description

The reproduction is the hosted Account Portal of a brand-new development application, created only for this report and left on Clerk's default settings (email + password). It has no appearance, no localization and no custom CSS. Test user: [email protected].

Steps to reproduce:

  1. Open the sign-in page above and enter [email protected].
  2. On the password step, click Forgot password?
  3. Click Reset your password.
  4. On the Reset password code step, press Tab from Continue, or run axe on the card.

Expected behavior:

A labelled "Back" button, or no button at all.

Actual behavior:

An empty ghost button is rendered below Continue:

<button class="cl-formButtonReset cl-button 🔒️ cl-internal-sbng93" data-variant="ghost" data-color="primary"></button>
  • It is 400×14 px, focusable (tabIndex 0) and the next Tab stop after Continue. When focused, it shows as an empty bar.
  • It has no text and no aria-label. axe 4.11 reports button-name (critical, WCAG 4.1.2).
  • Clicking it works: it goes back to the Forgot Password? screen. So it is a real action that is missing its label, not a leftover element.

Cause (from the source on main):

  • Since #7626, VerificationCodeCard renders a formButtonReset button whenever onBackLinkClicked is passed. Its text comes from the optional backLinkLabel prop that the same PR added.
  • SignInFactorOne passes onBackLinkClicked to SignInFactorOneForgotPasswordCard for both reset_password_phone_code and reset_password_email_code.
  • Neither SignInFactorOneForgotPasswordCard nor SignInFactorOneCodeForm sets backLinkLabel. Before #7626 the card ignored onBackLinkClicked, so nothing was rendered on this step. Since then, the button is rendered empty.
  • Only SmsCodeFlowScreen passes a label today. The open PR #10396 adds backLinkLabel={localizationKeys('backButton')} to UVFactorOneCodeForm for the same reason, but it does not touch the sign-in reset password step.

Possible fix: pass a label, e.g. backLinkLabel={localizationKeys('backButton')}, from SignInFactorOneForgotPasswordCard. As a safeguard, VerificationCodeCard could render the button only when a label is present.

Environment
Hosted Account Portal, development instance with default settings
ClerkJS 6.41.0, @clerk/ui 1.42.0 (window.Clerk.version / window.Clerk.uiVersion)
Chromium 153.0.8010.12 via Playwright 1.63.0, en-US
Same code in @clerk/ui 1.42.4 (latest on npm) and on main (f6d8807c28cf0d31662f3926ae7370cc69e8d554)
Also seen in a Next.js app on @clerk/ui 1.38.0 with the es-ES localization
主要語言
TypeScript
星號
1.8k
分支
492
平均合併
1 天 6 小時
30 天內合併 PR
367

環境準備

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

clerk/javascript 的其他 Issue

查看 clerk/javascript 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。