Make fields from com.amazonaws.serverless.proxy.model.AwsProxyRequest optional to set

未關閉
  • 哪裡不對？
#1,495 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
35/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
aws, java, spring-boot
領域
api, backend

研究方向

從 com.amazonaws.serverless.proxy.model.AwsProxyRequest 以及 AwsProxyHttpServletRequestReader.readRequest 中的驗證開始。將 issue 中最小的 GET 和 POST 初始化範例與目前的 request model 和 context 處理進行比較。當呼叫端不需要 dummy 欄位或物件即可建構所示的 requests，同時有效的 API Gateway requests 仍能正常運作時，即視為完成。

由索引模型根據 Issue 內容生成。

描述

When using AWS Serverless Java Container with Spring Boot 3 and Lambda SnapStart with priming with I tested this type of priming implementation WebRequestPriming

Unfortunately I have to set so many fields of the com.amazonaws.serverless.proxy.model.AwsProxyRequest with dummy values and even create dummy objects like AwsProxyRequestContext and ApiGatewayRequestIdentity (see the method getAwsProxyRequest) in order not to get errors like:

at
com.amazonaws.serverless.exceptions.InvalidRequestEventException: The incoming event is not a valid request from Amazon API Gateway or an Application Load Balancer com.amazonaws.serverless.proxy.internal.servlet.AwsProxyHttpServletRequestReader.readRequest(AwsProxyHttpServletRequestReader.java:48)

or

java.lang.NullPointerException: Cannot invoke "com.amazonaws.serverless.proxy.model.ApiGatewayRequestIdentity.getAccessKey()" because the return value of "com.amazonaws.serverless.proxy.model.AwsProxyRequestContext.getIdentity()" is null

Here is the complete code I had to write in order to make it work:

private static AwsProxyRequest getAwsProxyRequest () {
	final AwsProxyRequest awsProxyRequest = new AwsProxyRequest ();
	awsProxyRequest.setHttpMethod("GET");
	awsProxyRequest.setPath("/products/0");
	//awsProxyRequest.setResource("/products/{id}");
	awsProxyRequest.setPathParameters(Map.of("id","0"));
	final AwsProxyRequestContext awsProxyRequestContext = new AwsProxyRequestContext();
	final ApiGatewayRequestIdentity apiGatewayRequestIdentity= new ApiGatewayRequestIdentity();
	apiGatewayRequestIdentity.setApiKey("blabla");
	awsProxyRequestContext.setIdentity(apiGatewayRequestIdentity);
	awsProxyRequest.setRequestContext(awsProxyRequestContext);
	return awsProxyRequest;		
}

For my use case this will be enough to do the priming like this:

  final AwsProxyRequest awsProxyRequest = new AwsProxyRequest ();
  awsProxyRequest.setHttpMethod("GET");
  awsProxyRequest.setPathParameters(Map.of("id","0"));

Others, that priming Post request would only like to set the body like this:

  final AwsProxyRequest awsProxyRequest = new AwsProxyRequest ();
  awsProxyRequest.setHttpMethod("POST");
  awsProxyRequest.setBody("bla");

Many field should be optional to set to easily construct such objects or please provide static factory methods for it to save on the boilerplate code.

Compare it with how easy it is to implement the same type of SnapStart priming with

  1. Spring Cloud Function AWS Adapter

see my implementation of the method getAPIGatewayProxyRequestEventAsJson here AmazonAPIGatewayPrimingResource

as I only do

    final APIGatewayProxyRequestEvent proxyRequestEvent = new APIGatewayProxyRequestEvent ();
	proxyRequestEvent.setHttpMethod("GET");
	proxyRequestEvent.setPathParameters(Map.of("id","0"));
  1. Quarkus 3, see my implementation of the method getAwsProxyRequest here AmazonAPIGatewayPrimingResource

as I only do the same as above:

    final APIGatewayProxyRequestEvent proxyRequestEvent = new APIGatewayProxyRequestEvent ();
	proxyRequestEvent.setHttpMethod("GET");
	proxyRequestEvent.setPathParameters(Map.of("id","0"));
主要語言
Java
星號
1.6k
分支
575
平均合併
1 天 15 小時
30 天內合併 PR
12

環境準備

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

aws/serverless-java-container 的其他 Issue

查看 aws/serverless-java-container 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。