Make fields from com.amazonaws.serverless.proxy.model.AwsProxyRequest optional to set

Aberta
  • Algo errado?
#1,495 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
35/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Estagnada
Stack de tecnologia
aws, java, spring-boot
Domínio
api, backend

Direção de pesquisa

Comece com com.amazonaws.serverless.proxy.model.AwsProxyRequest e a validação em AwsProxyHttpServletRequestReader.readRequest. Compare os exemplos mínimos de preparação de GET e POST na issue com o modelo de request atual e o tratamento de contexto. A tarefa estará concluída quando os chamadores puderem construir os requests mostrados sem campos ou objetos fictícios e os requests válidos do API Gateway continuarem funcionando.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

When using AWS Serverless Java Container with Spring Boot 3 and Lambda SnapStart with priming with I tested this type of priming implementation WebRequestPriming

Unfortunately I have to set so many fields of the com.amazonaws.serverless.proxy.model.AwsProxyRequest with dummy values and even create dummy objects like AwsProxyRequestContext and ApiGatewayRequestIdentity (see the method getAwsProxyRequest) in order not to get errors like:

at
com.amazonaws.serverless.exceptions.InvalidRequestEventException: The incoming event is not a valid request from Amazon API Gateway or an Application Load Balancer com.amazonaws.serverless.proxy.internal.servlet.AwsProxyHttpServletRequestReader.readRequest(AwsProxyHttpServletRequestReader.java:48)

or

java.lang.NullPointerException: Cannot invoke "com.amazonaws.serverless.proxy.model.ApiGatewayRequestIdentity.getAccessKey()" because the return value of "com.amazonaws.serverless.proxy.model.AwsProxyRequestContext.getIdentity()" is null

Here is the complete code I had to write in order to make it work:

private static AwsProxyRequest getAwsProxyRequest () {
	final AwsProxyRequest awsProxyRequest = new AwsProxyRequest ();
	awsProxyRequest.setHttpMethod("GET");
	awsProxyRequest.setPath("/products/0");
	//awsProxyRequest.setResource("/products/{id}");
	awsProxyRequest.setPathParameters(Map.of("id","0"));
	final AwsProxyRequestContext awsProxyRequestContext = new AwsProxyRequestContext();
	final ApiGatewayRequestIdentity apiGatewayRequestIdentity= new ApiGatewayRequestIdentity();
	apiGatewayRequestIdentity.setApiKey("blabla");
	awsProxyRequestContext.setIdentity(apiGatewayRequestIdentity);
	awsProxyRequest.setRequestContext(awsProxyRequestContext);
	return awsProxyRequest;		
}

For my use case this will be enough to do the priming like this:

  final AwsProxyRequest awsProxyRequest = new AwsProxyRequest ();
  awsProxyRequest.setHttpMethod("GET");
  awsProxyRequest.setPathParameters(Map.of("id","0"));

Others, that priming Post request would only like to set the body like this:

  final AwsProxyRequest awsProxyRequest = new AwsProxyRequest ();
  awsProxyRequest.setHttpMethod("POST");
  awsProxyRequest.setBody("bla");

Many field should be optional to set to easily construct such objects or please provide static factory methods for it to save on the boilerplate code.

Compare it with how easy it is to implement the same type of SnapStart priming with

  1. Spring Cloud Function AWS Adapter

see my implementation of the method getAPIGatewayProxyRequestEventAsJson here AmazonAPIGatewayPrimingResource

as I only do

    final APIGatewayProxyRequestEvent proxyRequestEvent = new APIGatewayProxyRequestEvent ();
	proxyRequestEvent.setHttpMethod("GET");
	proxyRequestEvent.setPathParameters(Map.of("id","0"));
  1. Quarkus 3, see my implementation of the method getAwsProxyRequest here AmazonAPIGatewayPrimingResource

as I only do the same as above:

    final APIGatewayProxyRequestEvent proxyRequestEvent = new APIGatewayProxyRequestEvent ();
	proxyRequestEvent.setHttpMethod("GET");
	proxyRequestEvent.setPathParameters(Map.of("id","0"));
Linguagem predominante
Java
Estrelas
1.6k
Forks
575
Merge médio
1d 15h
PRs com merge (30d)
12

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de aws/serverless-java-container

Todas as issues de aws/serverless-java-container

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.