[Testing]: Match ReplayChildren lifecycle and wire representation
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Read base.py, operation_state.py, invoker.py, and the response serializers in model.py to trace how ReplayChildren moves through checkpoint processing and serialized responses. Start with the two named replay_children_service_parity tests and cover START plus SUCCEED/FAIL with omitted, true, and false closing options. Done means the invocation, state, and checkpoint responses agree while START omits the field and core serialization remains unchanged.
由索引模型根據 Issue 內容生成。
描述
Split from PR #795 — match replay state to the service, reference commit f8ac9b4; baseline main is d7ae95571c44b18c2a2efdef9a308b1c916c5049. This issue owns one independently implementable slice of that PR. Start a focused branch from current main and port only this slice, rather than stacking on the full PR.
Problem and reproduction
The local checkpoint processor can retain ContextOptions.ReplayChildren on START, and generic core serialization omits false/absent values where the local service's terminal-state response needs an explicit false. The processor, invocation payload, state response, and checkpoint response can consequently disagree about the flag's meaning or presence.
START a context with ReplayChildren: true, then separately test SUCCEED and FAIL with closing options omitted, true, false, and unspecified. Inspect the in-memory operation and serialized Lambda invocation/state/checkpoint payloads. START must not advertise retention; terminal updates must represent the closing choice consistently.
Scope and implementation
- Record true only on SUCCEED/FAIL when the closing update explicitly requests true; other closing cases record false. Ignore the flag on START.
- Add a testing-service projection that omits
ReplayChildrenfrom STARTED context responses and includes a boolean for completed contexts. - Apply that projection to Lambda invocation JSON,
GetDurableExecutionStateResponse, andCheckpointUpdatedExecutionState. Preserve the existing timestamp representation on each path. - Keep core
Operationconversion and its generic serialization API unchanged. This is a local-service projection, not a new SDK option or a replay-filtering implementation.
Primary code: base.py, operation_state_to_dict in operation_state.py, invoker.py, and the two response serializers in model.py.
Acceptance criteria
- START with retention options produces no
ReplayChildrenwire field and does not persist true. - SUCCEED/FAIL produce true only for explicit true, and false for omitted/false/unspecified closing options.
- Invocation JSON, state responses, and checkpoint responses agree, with JSON timestamps preserved where required.
- Non-context operations and core's own serialization contracts are unchanged; no mutation of the supplied
Operationoccurs during projection. - Cover memory/filesystem round-trips and a public child-context workflow that naturally needs retained children, without depending on descendant filtering.
- Document flag lifecycle/presence separately from which descendants are visible.
Reference tests
Port test_replay_children_is_recorded_only_by_closing_update and test_lambda_invocation_projects_close_false_and_start_absence, adapting the latter to a simple unfiltered fixture so it needs only this fix.
Independence
Implement directly on main. No pruning function, callback changes, or history-error fix is required. Coordinate the shared operation_state.py file with the replay-visibility issue, but neither PR requires the other to merge first. This is narrower than closed #477, which fixed core serialization dropping fields altogether; do not reopen or undo that fix. Temporary feature-branch CI filters from #795 are outside this slice.
Validation and evidence
Add a regression that fails on main without this fix and passes with this slice alone. Run from the repository root:
hatch run dev-testing:test
hatch run dev-testing:typecheck
hatch run dev-testing:js-examples
Use the repository's CI-pinned Hatch version (1.16.5 at the reference) and Node.js 22+ for the JS harness; run hatch fmt --check from packages/aws-durable-execution-sdk-python-testing. Use public-handler integration tests for cross-component behavior and both memory/filesystem stores where relevant. List changed test expectations and their reasons in the implementing PR.
The service-parity expectations are carried forward from #795. This split does not independently verify them against deployed AWS Lambda; cite service evidence or mark the external assumption unverified before claiming deployed-service qualification. Shared conformance work belongs to #796 / conformance PR #131; coordinate new requirements there.
Related issues in this split
- 主要語言
- Python
- 星號
- 59
- 分支
- 32
- 平均合併
- 1 天 5 小時
- 30 天內合併 PR
- 76
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
aws/aws-durable-execution-sdk-python 的其他 Issue
-
needs-triage
難度 2/5 1-3 小時 新手友好度 82/100
aws/aws-durable-execution-sdk-python#977 ·
維護者通常 1 天內回覆
-
[AgentCore session] Remove the unused session timeout可能已有人在做 @srivilliamsai 今天認領。 未關閉needs-triage
難度 2/5 1-3 小時 新手友好度 77/100
aws/aws-durable-execution-sdk-python#970 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement needs-triage
難度 2/5 1-3 小時 新手友好度 72/100
aws/aws-durable-execution-sdk-python#952 ·
維護者通常 1 天內回覆
-
[AgentCore session] W4: Document sessions in the worker README可能已有人在做 @ParidelPooya 於 3 天前認領。 未關閉enhancement needs-triage
難度 1/5 1-3 小時 新手友好度 76/100
aws/aws-durable-execution-sdk-python#950 ·
維護者通常 1 天內回覆
-
[AgentCore session] W3: Add the session ID and job count to worker logs可能已有人在做 @ParidelPooya 於 3 天前認領。 未關閉enhancement needs-triage
難度 2/5 1-3 小時 新手友好度 68/100
aws/aws-durable-execution-sdk-python#949 ·
維護者通常 1 天內回覆
查看 aws/aws-durable-execution-sdk-python 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 73/100
維護者通常 1 天內回覆
-
Unused loot bag group names left in dreamcraft en_US.lang可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉Status: Triage Suggestion
難度 1/5 1 小時以內 新手友好度 90/100
GTNewHorizons/GT-New-Horizons-Modpack#27789 ·
維護者通常 1 天內回覆
-
bug frontend sev-5
難度 2/5 1-3 小時 新手友好度 83/100
-
core good first issue
難度 2/5 1-3 小時 新手友好度 65/100
-
b4b code health next
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆