[Testing]: Match ReplayChildren lifecycle and wire representation
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 48/100
Piste de recherche
Read base.py, operation_state.py, invoker.py, and the response serializers in model.py to trace how ReplayChildren moves through checkpoint processing and serialized responses. Start with the two named replay_children_service_parity tests and cover START plus SUCCEED/FAIL with omitted, true, and false closing options. Done means the invocation, state, and checkpoint responses agree while START omits the field and core serialization remains unchanged.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Split from PR #795 — match replay state to the service, reference commit f8ac9b4; baseline main is d7ae95571c44b18c2a2efdef9a308b1c916c5049. This issue owns one independently implementable slice of that PR. Start a focused branch from current main and port only this slice, rather than stacking on the full PR.
Problem and reproduction
The local checkpoint processor can retain ContextOptions.ReplayChildren on START, and generic core serialization omits false/absent values where the local service's terminal-state response needs an explicit false. The processor, invocation payload, state response, and checkpoint response can consequently disagree about the flag's meaning or presence.
START a context with ReplayChildren: true, then separately test SUCCEED and FAIL with closing options omitted, true, false, and unspecified. Inspect the in-memory operation and serialized Lambda invocation/state/checkpoint payloads. START must not advertise retention; terminal updates must represent the closing choice consistently.
Scope and implementation
- Record true only on SUCCEED/FAIL when the closing update explicitly requests true; other closing cases record false. Ignore the flag on START.
- Add a testing-service projection that omits
ReplayChildrenfrom STARTED context responses and includes a boolean for completed contexts. - Apply that projection to Lambda invocation JSON,
GetDurableExecutionStateResponse, andCheckpointUpdatedExecutionState. Preserve the existing timestamp representation on each path. - Keep core
Operationconversion and its generic serialization API unchanged. This is a local-service projection, not a new SDK option or a replay-filtering implementation.
Primary code: base.py, operation_state_to_dict in operation_state.py, invoker.py, and the two response serializers in model.py.
Acceptance criteria
- START with retention options produces no
ReplayChildrenwire field and does not persist true. - SUCCEED/FAIL produce true only for explicit true, and false for omitted/false/unspecified closing options.
- Invocation JSON, state responses, and checkpoint responses agree, with JSON timestamps preserved where required.
- Non-context operations and core's own serialization contracts are unchanged; no mutation of the supplied
Operationoccurs during projection. - Cover memory/filesystem round-trips and a public child-context workflow that naturally needs retained children, without depending on descendant filtering.
- Document flag lifecycle/presence separately from which descendants are visible.
Reference tests
Port test_replay_children_is_recorded_only_by_closing_update and test_lambda_invocation_projects_close_false_and_start_absence, adapting the latter to a simple unfiltered fixture so it needs only this fix.
Independence
Implement directly on main. No pruning function, callback changes, or history-error fix is required. Coordinate the shared operation_state.py file with the replay-visibility issue, but neither PR requires the other to merge first. This is narrower than closed #477, which fixed core serialization dropping fields altogether; do not reopen or undo that fix. Temporary feature-branch CI filters from #795 are outside this slice.
Validation and evidence
Add a regression that fails on main without this fix and passes with this slice alone. Run from the repository root:
hatch run dev-testing:test
hatch run dev-testing:typecheck
hatch run dev-testing:js-examples
Use the repository's CI-pinned Hatch version (1.16.5 at the reference) and Node.js 22+ for the JS harness; run hatch fmt --check from packages/aws-durable-execution-sdk-python-testing. Use public-handler integration tests for cross-component behavior and both memory/filesystem stores where relevant. List changed test expectations and their reasons in the implementing PR.
The service-parity expectations are carried forward from #795. This split does not independently verify them against deployed AWS Lambda; cite service evidence or mark the external assumption unverified before claiming deployed-service qualification. Shared conformance work belongs to #796 / conformance PR #131; coordinate new requirements there.
Related issues in this split
- Langage dominant
- Python
- Étoiles
- 59
- Forks
- 32
- Merge moyen
- 1 j 5 h
- PR mergées (30 j)
- 76
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de aws/aws-durable-execution-sdk-python
-
needs-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
aws/aws-durable-execution-sdk-python#977 ·
Les mainteneurs répondent en général sous 1 jour
-
[AgentCore session] Remove the unused session timeoutPeut-être pris @srivilliamsai l’a pris aujourd’hui. Ouverteneeds-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 77/100
aws/aws-durable-execution-sdk-python#970 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
enhancement needs-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
aws/aws-durable-execution-sdk-python#952 ·
Les mainteneurs répondent en général sous 1 jour
-
[AgentCore session] W4: Document sessions in the worker READMEPeut-être pris @ParidelPooya l’a pris il y a 3 jours. Ouverteenhancement needs-triage
Difficulté 1/5 1-3 heures Accessibilité débutants 76/100
aws/aws-durable-execution-sdk-python#950 ·
Les mainteneurs répondent en général sous 1 jour
-
[AgentCore session] W3: Add the session ID and job count to worker logsPeut-être pris @ParidelPooya l’a pris il y a 3 jours. Ouverteenhancement needs-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
aws/aws-durable-execution-sdk-python#949 ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de aws/aws-durable-execution-sdk-python
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 73/100
Les mainteneurs répondent en général sous 1 jour
-
Unused loot bag group names left in dreamcraft en_US.langPeut-être pris Une pull request liée à cette issue est ouverte ou déjà fusionnée. OuverteStatus: Triage Suggestion
Difficulté 1/5 Moins d'une heure Accessibilité débutants 90/100
GTNewHorizons/GT-New-Horizons-Modpack#27789 ·
Les mainteneurs répondent en général sous 1 jour
-
bug frontend sev-5
Difficulté 2/5 1-3 heures Accessibilité débutants 83/100
-
core good first issue
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
-
b4b code health next
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
ESCOMP/CTSM#4330 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour