Source release: ship only the top-level LICENSE and NOTICE, not the subdirectory copies
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 35/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- docker
- 領域
- build-system, release
研究方向
Start with no-release.txt and the listed Dockerfiles, especially oplugins-op/Dockerfile, streamer/Dockerfile, admin-api/Dockerfile, and the runtime image Dockerfiles. Trace how source archives and image builds consume the license files, then verify that the source tarball contains only the intended top-level files while image builds still receive their required licensing files.
由索引模型根據 Issue 內容生成。
描述
The 0.9.0-incubating-RC7 source release (apache-openserverless-0.9.0-incubating-src.tar.gz) contains the top-level LICENSE, NOTICE and DISCLAIMER, plus 85 more LICENSE/NOTICE/DISCLAIMER files in subdirectories. They come from the submodules and from each runtime image directory:
- one set per submodule:
admin-api/,build/,cli/,devcontainer/,oplugins/,oplugins-op/,runtimes/,streamer/,testing/; - one set per runtime image:
runtimes/runtime/{go,java,nodejs,python}/*/andruntimes/experimental/*/; build/openwhisk/LICENSE.txt,NOTICE.txtandlicenses/LICENSE-spray.txt(from the vendored OpenWhisk sources);cli/tests/oplugins/LICENSE(test data).
Together they run to about 94,000 lines (runtimes/LICENSE alone is 37,204 lines).
Please ship only the top-level LICENSE and NOTICE in the source release, and leave the subdirectory ones out (e.g. via no-release.txt).
Why
For the source release, the top-level LICENSE and NOTICE are the ones that count. The subdirectory files mostly describe something else: the container images built from each directory, which bundle OS packages, language runtimes and dependencies that are not in the source release. Shipping them in the source tarball is confusing for users and reviewers, who cannot tell which file applies to what. It also means the same facts are maintained in many places, and they have already drifted apart. In RC7:
oplugins/LICENSEandoplugins-op/LICENSEstate that the source distribution "is licensed in its entirety under the Apache License, Version 2.0". The top-levelLICENSEcorrectly lists MIT, ISC and BSD-3-Clause code in the source (the pre-built JavaScript bundles), and there is more that is not yet listed (#260).- 20 of the subdirectory
LICENSE/NOTICEfiles refer readers to aWARNfile, butno-release.txtremoves everyWARNfile from the source release. - 19 of the subdirectory
NOTICEfiles sayCopyright 2024 The Apache Software Foundation; the top-levelNOTICEand 8 others sayCopyright 2024-2026. oplugins-op/LICENSEsays the operator bundlesgradlew/gradlew.batandConcurrentMapBackedCache.scala; neither exists underoplugins-op/.- Third-party content that should be attributed (cert-manager #263, Kvrocks #262, Milvus #260) is missing from the subdirectory files as well as the top-level ones. So there are two places to fix instead of one, and no place that is complete.
With only the top-level files, there is one place to review and keep correct for each release.
Things to handle
- Image builds use these files. 26 Dockerfiles
COPYtheir directory'sDISCLAIMER LICENSE NOTICEinto the image (e.g.oplugins-op/Dockerfile:152,streamer/Dockerfile:30,admin-api/Dockerfile:47, everyruntimes/runtime/*/*/Dockerfile,build/standalone/Dockerfile:47). The images do need their ownLICENSE/NOTICE(as convenience binaries), so dropping the files from the source tarball needs one of:- generate the image
LICENSE/NOTICEat image build time (they are largely derived from the image contents anyway); or - keep them in git but outside the source release, and have the image build (CI) supply them; or
- if they must stay in the source tree, rename them (e.g.
LICENSE-image,NOTICE-image) and add a first line saying they describe the container image, not the source, so they are not mistaken for the source release's licensing.
- generate the image
- The top-level
LICENSEpoints atbuild/openwhisk/licenses/LICENSE-spray.txt. Either keep that one file, or inline the Spray licence text in the top-levelLICENSE. The Spray licence is Apache-2.0, already reproduced there. build/openwhisk/LICENSE.txt/NOTICE.txtare the vendored OpenWhisk project's own files. The top-levelNOTICEalready carries the OpenWhisk attribution, so they can go too.- Optional: the same applies to the 27 subdirectory
DISCLAIMERfiles, which duplicate the top-levelDISCLAIMER.
Related: #260, #262, #263, #267.
- 主要語言
- Python
- 星號
- 576
- 分支
- 29
- 平均合併
- 7 小時 7 分鐘
- 30 天內合併 PR
- 5
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
apache/openserverless 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 85/100
apache/openserverless#269 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 84/100
apache/openserverless#267 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 8/100
apache/openserverless#273 · 2 則留言 ·
維護者通常 1 天內回覆
-
難度 4/5 1-2 天 新手友好度 42/100
apache/openserverless#271 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement
難度 5/5 一週以上 新手友好度 25/100
apache/openserverless#215 ·
維護者通常 1 天內回覆
查看 apache/openserverless 的全部 Issue
相似的 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 68/100
Deltares/imod-python#1940 ·
維護者通常 1 天內回覆
-
effort: low prio: low ready
難度 1/5 1 小時以內 新手友好度 82/100
digitalfabrik/integreat-cms#4621 ·
維護者通常 5 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 88/100
ioos/compliance-checker#1375 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆