Top-level LICENSE/NOTICE: bundled JavaScript copyright notices belong in LICENSE, and several are inaccurate
還沒有人認領這個 Issue。
評估
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 新手友好度
- 84/100
- Issue 類型
- 文件
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- javascript
研究方向
先從涵蓋 PRE-BUILT JAVASCRIPT 的頂層 LICENSE 和 NOTICE 區段開始，接著將列出的套件版權行與所隨附版本中的上游 LICENSE 檔案進行比較。檢查參照的 bundle：oplugins/util/upload.js 和 oplugins/admin/usage/usage.js，以確認套件範圍。完成的標準是：修正後的上游聲明位於 LICENSE 中套件項目的旁邊，並且包含 MinIO 在內的 bundled-JavaScript 區段已從 NOTICE 中移除。
由索引模型根據 Issue 內容生成。
描述
In the 0.9.0-incubating-RC7 source release, the copyright notices of the npm packages embedded in the pre-built JavaScript bundles (oplugins/util/upload.js, oplugins/admin/usage/usage.js) are in the top-level NOTICE rather than in LICENSE, and several of them do not match the upstream packages.
1. The notices are in NOTICE instead of LICENSE
The top-level LICENSE section "BUNDLED COMPONENTS -- PRE-BUILT JAVASCRIPT" lists each package by name and version, and reproduces the MIT, ISC and BSD-3-Clause licence texts once each. It does not include the packages' copyright lines. Those licences require "the above copyright notice" to be kept with the permission notice, so the copyright lines belong with the licence texts in LICENSE.
Instead, the copyright lines are in the top-level NOTICE (lines 69-162, about 90 lines: MinIO, the 24 MIT packages, the ISC and BSD-3-Clause packages, and yaml).
The ASF licensing guide says this is the wrong place:
Under normal circumstances, there is no need to modify
NOTICEto mention a bundled dependency [under a permissive licence].Do not add anything to
NOTICEwhich is not legally required.
https://infra.apache.org/licensing-howto.html#permissive-deps and https://infra.apache.org/licensing-howto.html#mod-notice
It also notes that the copyright notices embedded in BSD and MIT licences do not need to be duplicated in NOTICE.
The MinIO entry in NOTICE is not needed either: minio-js 8.0.1 is Apache-2.0 but ships no NOTICE file, so there is nothing to propagate.
2. Copyright lines that differ from upstream
Checked against each package's own LICENSE at the bundled version (via unpkg):
| Package (version) | Top-level NOTICE says | Upstream LICENSE says |
|---|---|---|
| fast-xml-parser (4.5.0) | Copyright (c) 2021 Natural Intelligence | Copyright (c) 2017 Amit Kumar Gupta |
| mime-db (1.52.0) | Copyright (c) 2014 Jonathan Ong | Copyright (c) 2014 Jonathan Ong; Copyright (c) 2015-2022 Douglas Christopher Wilson |
| mime-types (2.1.35) | Copyright (c) 2014 Jonathan Ong | Copyright (c) 2014 Jonathan Ong; Copyright (c) 2015 Douglas Christopher Wilson |
| readable-stream (3.6.2), string_decoder (1.3.0) | Copyright Joyent, Inc. and other Node contributors | Copyright Node.js contributors. All rights reserved.; Copyright Joyent, Inc. and other Node contributors. All rights reserved. |
| sax (1.4.1) | Copyright (c) Isaac Z. Schlueter and Contributors | Copyright (c) 2010-2024 Isaac Z. Schlueter and Contributors; Copyright (c) 2010-2024 Mathias Bynens |
| stream-chain (2.2.5) | Copyright (c) 2005-2024, Eugene Lazutkin | Copyright 2019 Eugene Lazutkin |
| stream-json (1.8.0) | Copyright (c) 2005-2024, Eugene Lazutkin | Copyright (c) 2005-2018, Eugene Lazutkin |
| decode-uri-component (0.2.2) | Copyright (c) Sam Verschueren | Copyright (c) 2017, Sam Verschueren |
The others match, or differ only in omitted e-mail addresses. block-stream2 2.1.0 has no copyright line in its LICENSE, so "Copyright (c) James Halliday" (its package.json author) is a reasonable choice.
Suggested fix
- In the top-level
LICENSE"PRE-BUILT JAVASCRIPT" section, put each package's upstream copyright line(s) next to its name, corrected as in the table above. The licence texts already there can stay. - Remove the bundled-JavaScript section (lines 69-162) from the top-level
NOTICE, including the MinIO entry.
Related: #260.
- 主要語言
- Python
- 星號
- 577
- 分支
- 29
- 平均合併
- 3 天 17 小時
- 30 天內合併 PR
- 4
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
apache/openserverless 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 85/100
apache/openserverless#269 ·
-
難度 5/5 一週以上 新手友好度 25/100
apache/openserverless#277 ·
-
難度 5/5 一週以上 新手友好度 20/100
apache/openserverless#274 ·
-
難度 5/5 一週以上 新手友好度 8/100
apache/openserverless#273 · 2 則留言 ·
-
難度 4/5 1-2 天 新手友好度 42/100
apache/openserverless#271 · 8 則留言 ·
查看 apache/openserverless 的全部 Issue
相似的 Issue
-
難度 1/5 1-3 小時 新手友好度 85/100
WLAN-Pi/wlanpi-profiler#341 ·
維護者通常 1 天內回覆
-
Memory leak: the shared `validation_aborted_error` keeps every traceback it is raised through可能已有人在做 @Fire162 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 78/100
graphql-python/graphql-core#287 ·
-
難度 2/5 1-3 小時 新手友好度 67/100
roman-corgi/ctc-dip#160 ·
維護者通常 1 天內回覆
-
type-bug
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆
-
render_findings.py reads and writes in the host's default encoding, so findings.html breaks on a cp1252 Windows host可能已有人在做 @Aaqibhafeezkhan 今天認領。 未關閉bug good first issue mentored python size: XS up-for-grabs
難度 2/5 1-3 小時 新手友好度 75/100
dheerajjha/mcp-migrate#366 · 1 則留言 ·
維護者通常 1 天內回覆