Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

DockerToActivationFileLogStore.scala contains code derived from Akka Sink.combine without attribution

已關閉 適合新手
  • 哪裡不對？
#265 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
78/100
Issue 類型
文件
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
scala
領域
documentation

研究方向

從 build/openwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/DockerToActivationFileLogStore.scala 和頂層 LICENSE 開始。比較 OwSink.combine 與 Akka 2.6.12 Sink.combine，並檢查 #260 中的相關內容。當衍生程式碼已使用適用的 notice 文字正確標示來源，或複製的實作與註解已被獨立替換時，即表示完成。

由索引模型根據 Issue 內容生成。

描述

build/openwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/DockerToActivationFileLogStore.scala (vendored from Apache OpenWhisk, shipped in the 0.9.0-incubating-RC7 source release) contains code that its own comment says was copied from Akka:

object OwSink {

  /**
   * Combines two sinks into one sink using the given strategy. The materialized value is a Tuple2 of the materialized
   * values of either sink. Code basically copied from {@code Sink.combine}
   */
  def combine[T, U, M1, M2](first: Sink[U, M1], second: Sink[U, M2])(
    strategy: Int => Graph[UniformFanOutShape[T, U], NotUsed]): Sink[T, (M1, M2)] = {
    Sink.fromGraph(GraphDSL.create(first, second)((_, _)) { implicit b => (s1, s2) =>
      import GraphDSL.Implicits._
      val d = b.add(strategy(2))

      d ~> s1
      d ~> s2

      SinkShape(d.in)
    })
  }
}

It is adapted from Sink.combine in Akka 2.6.12 (the version OpenWhisk builds against), akka-stream/src/main/scala/akka/stream/scaladsl/Sink.scala lines 315-330, Copyright (C) 2014-2021 Lightbend Inc.

Akka 2.6.x was released under the Apache License 2.0 (Akka moved to the BSL from 2.7.0), so there is no licence conflict, but the derived code is not attributed: the file only carries the ASF header, and the top-level LICENSE does not mention Akka.

Suggested fix, either:

  1. Add a LICENSE entry noting that OwSink.combine in this file is derived from Akka 2.6.12 Sink.combine (Apache-2.0, Copyright Lightbend Inc.), and carry any applicable Akka NOTICE text; or
  2. Rewrite OwSink.combine independently and drop the "copied from" comment. It is a small GraphDSL graph; alternatively, Apache Pekko (the ASF fork of Akka 2.6) has the same Sink.combine, and deriving from Pekko would make this ASF-to-ASF.

The same code is in upstream Apache OpenWhisk. Related: #260.

主要語言
Python
星號
577
分支
29
平均合併
4 天 23 小時
30 天內合併 PR
3

環境準備

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

apache/openserverless 的其他 Issue

查看 apache/openserverless 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。