Make write.parquet.page-size-bytes and write.parquet.dict-size-bytes taking effect
維護者通常 3 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 72/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- cpp
研究方向
Start at src/iceberg/parquet/parquet_writer.cc, especially ParquetWriter::Impl::Open, and read the declarations and defaults in src/iceberg/table_properties.h. Trace WriterProperties::FromMap and the Arrow writer-property construction, then locate existing writer-property tests. Done means defaults and overrides reach the underlying writer, invalid or non-positive values are rejected before file creation, and custom settings have write/read coverage.
由索引模型根據 Issue 內容生成。
描述
The C++ Parquet writer does not apply write.parquet.page-size-bytes or write.parquet.dict-size-bytes. Both properties are already declared in TableProperties, but passing them through WriterProperties::FromMap has no effect on the underlying Parquet writer configuration.
On the current main, the ParquetWriter::Impl::Open has already configured the compression, compression level, and the row-count limit, however it builds Arrow's writer properties without setting the page or dictionary size. This prevents callers from using the standard Iceberg properties to tune these sizes.
For instance, providing the following properties should configure a 64 KiB data-page target and a 256 KiB dictionary-page limit on output parquet writer:
write.parquet.page-size-bytes=65536
write.parquet.dict-size-bytes=262144
Proposed change:
- Expose these two settings through
WriterPropertiesand apply them when constructing Arrow's Parquet writer properties. - Use the Iceberg defaults already declared in
table_properties.h: 1 MiB for data pages and 2 MiB for dictionary pages. - Reject invalid or non-positive values before creating the output file.
- Add tests for defaults, overrides, invalid values, and propagation into the underlying writer, plus write/read coverage with custom settings.
Background:
- Java resolves and validates both properties in
Parquet.WriteBuilder.Context.dataContext. - Rust applies them in
ParquetWriterBuilder::from_table_properties.
Note:
Byte-based row-group sizing (write.parquet.row-group-size-bytes) can be handled in a separate follow-up because it requires examining the buffering and flush policy.
- 主要語言
- C++
- 星號
- 230
- 分支
- 138
- 平均合併
- 4 天 2 小時
- 30 天內合併 PR
- 61
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
apache/iceberg-cpp 的其他 Issue
-
Parquet reader: fall back to positional field IDs when a file has no field IDs and no name mapping未關閉
難度 4/5 3-5 天 新手友好度 45/100
apache/iceberg-cpp#1046 ·
維護者通常 3 天內回覆
-
難度 5/5 一週以上 新手友好度 12/100
apache/iceberg-cpp#1027 · 4 則留言 ·
維護者通常 3 天內回覆
-
難度 4/5 3-5 天 新手友好度 35/100
apache/iceberg-cpp#1000 · 2 則留言 · 1 個 reaction ·
維護者通常 3 天內回覆
-
難度 5/5 一週以上 新手友好度 8/100
apache/iceberg-cpp#988 · 2 則留言 ·
維護者通常 3 天內回覆
-
難度 5/5 一週以上 新手友好度 20/100
apache/iceberg-cpp#959 · 1 則留言 ·
維護者通常 3 天內回覆
查看 apache/iceberg-cpp 的全部 Issue
相似的 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
aristocratos/btop#1945 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 79/100
boykopovar/AnyPS5#11291 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
k2-fsa/sherpa-onnx#4100 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
Mod: Part Design Topic: User Interface
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆