Table version clause (`AT(...)`, `FOR SYSTEM_TIME AS OF`, `VERSION AS OF`) is displayed after the alias and doesn't reparse
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
The parse order is in parse_table_factor, where maybe_parse_table_version runs before maybe_parse_table_alias. The write order is in the TableFactor::Table arm of Display, which emits alias, index hints and WITH (...) before the version. Read the dialect trait methods and the existing version tests first, then check PR #2486 for overlap. Done means a round-trip check passes for the Snowflake, MsSql, Databricks and BigQuery inputs, with the position chosen per dialect.
由索引模型根據 Issue 內容生成。
描述
The parser reads the version clause before the alias and table hints, but Display writes it after them, so the output doesn't parse:
Snowflake: SELECT * FROM my_table AT(OFFSET => -60*5) AS T WHERE T.flag = 'valid'
-> displays as: SELECT * FROM my_table AS T AT(OFFSET => -60 * 5) WHERE T.flag = 'valid'
-> reparse: Expected: identifier, found: ( at Line: 1, Column: 31
MsSql: SELECT * FROM t FOR SYSTEM_TIME AS OF '2014-01-01' AS x WITH (NOLOCK)
-> displays as: SELECT * FROM t AS x WITH (NOLOCK) FOR SYSTEM_TIME AS OF '2014-01-01'
-> reparse: Expected: one of UPDATE or SHARE, found: SYSTEM_TIME at Line: 1, Column: 40
Databricks: SELECT * FROM events VERSION AS OF 123 AS e
-> displays as: SELECT * FROM events AS e VERSION AS OF 123
-> reparse: Expected: end of statement, found: VERSION at Line: 1, Column: 27
The Snowflake input is the example from https://docs.snowflake.com/en/sql-reference/constructs/at-before. SQL Server documents table_or_view_name [ FOR SYSTEM_TIME <system_time> ] [ [ AS ] table_alias ] ... [ WITH ( <table_hint> ... ) ] (https://learn.microsoft.com/en-us/sql/t-sql/queries/from-transact-sql), and Databricks puts the temporal spec in table_name, before table_alias (https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-qry-select-table-reference).
BigQuery documents the opposite order, table_name [ as_alias ] [ FOR SYSTEM_TIME AS OF ... ] (https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#from_clause), and with BigQueryDialect SELECT * FROM t AS x FOR SYSTEM_TIME AS OF '2020-01-01' is rejected (Expected: one of UPDATE or SHARE, found: SYSTEM_TIME), while the other order parses and displays as the rejected form. So the right position seems to be dialect dependent.
Parser: maybe_parse_table_version runs before maybe_parse_table_alias in parse_table_factor. Display: the TableFactor::Table arm writes alias, index hints, WITH (...), then the version. The open PR #2486 mentions this in passing and leaves it for a separate change.
Tested on main ce12f1f6 (also 0.63.0; on 0.58.0 the Databricks input is a parse error).
Found with a property-based fuzzer (round trip check); I used AI assistance for triage and verified every case above.
- 主要語言
- Rust
- 星號
- 3.5k
- 分支
- 805
- 平均合併
- 2 天 3 小時
- 30 天內合併 PR
- 116
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
apache/datafusion-sqlparser-rs 的其他 Issue
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 76/100
apache/datafusion-sqlparser-rs#2862 ·
維護者通常 1 天內回覆
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 75/100
apache/datafusion-sqlparser-rs#2861 ·
維護者通常 1 天內回覆
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 77/100
apache/datafusion-sqlparser-rs#2858 ·
維護者通常 1 天內回覆
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 82/100
apache/datafusion-sqlparser-rs#2857 ·
維護者通常 1 天內回覆
-
DuckDB Prolific Author
難度 2/5 1-3 小時 新手友好度 70/100
apache/datafusion-sqlparser-rs#2807 ·
維護者通常 1 天內回覆
查看 apache/datafusion-sqlparser-rs 的全部 Issue
相似的 Issue
-
area:schema documentation
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
ElectronicWave/Elemental#252 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
dekobon/big-code-analysis#1887 ·
維護者通常 1 天內回覆
-
Shell中文符号输入异常未關閉bug
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 82/100
維護者通常 1 天內回覆