Table version clause (`AT(...)`, `FOR SYSTEM_TIME AS OF`, `VERSION AS OF`) is displayed after the alias and doesn't reparse

Abierto
  • ¿Algo no está bien?
#2,804 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust, sql
Área
compilers

Línea de trabajo

The parse order is in parse_table_factor, where maybe_parse_table_version runs before maybe_parse_table_alias. The write order is in the TableFactor::Table arm of Display, which emits alias, index hints and WITH (...) before the version. Read the dialect trait methods and the existing version tests first, then check PR #2486 for overlap. Done means a round-trip check passes for the Snowflake, MsSql, Databricks and BigQuery inputs, with the position chosen per dialect.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

BigQuery Databricks Prolific Author Snowflake SQL Server

The parser reads the version clause before the alias and table hints, but Display writes it after them, so the output doesn't parse:

Snowflake:  SELECT * FROM my_table AT(OFFSET => -60*5) AS T WHERE T.flag = 'valid'
  -> displays as: SELECT * FROM my_table AS T AT(OFFSET => -60 * 5) WHERE T.flag = 'valid'
  -> reparse: Expected: identifier, found: ( at Line: 1, Column: 31

MsSql:      SELECT * FROM t FOR SYSTEM_TIME AS OF '2014-01-01' AS x WITH (NOLOCK)
  -> displays as: SELECT * FROM t AS x WITH (NOLOCK) FOR SYSTEM_TIME AS OF '2014-01-01'
  -> reparse: Expected: one of UPDATE or SHARE, found: SYSTEM_TIME at Line: 1, Column: 40

Databricks: SELECT * FROM events VERSION AS OF 123 AS e
  -> displays as: SELECT * FROM events AS e VERSION AS OF 123
  -> reparse: Expected: end of statement, found: VERSION at Line: 1, Column: 27

The Snowflake input is the example from https://docs.snowflake.com/en/sql-reference/constructs/at-before. SQL Server documents table_or_view_name [ FOR SYSTEM_TIME <system_time> ] [ [ AS ] table_alias ] ... [ WITH ( <table_hint> ... ) ] (https://learn.microsoft.com/en-us/sql/t-sql/queries/from-transact-sql), and Databricks puts the temporal spec in table_name, before table_alias (https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-qry-select-table-reference).

BigQuery documents the opposite order, table_name [ as_alias ] [ FOR SYSTEM_TIME AS OF ... ] (https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#from_clause), and with BigQueryDialect SELECT * FROM t AS x FOR SYSTEM_TIME AS OF '2020-01-01' is rejected (Expected: one of UPDATE or SHARE, found: SYSTEM_TIME), while the other order parses and displays as the rejected form. So the right position seems to be dialect dependent.

Parser: maybe_parse_table_version runs before maybe_parse_table_alias in parse_table_factor. Display: the TableFactor::Table arm writes alias, index hints, WITH (...), then the version. The open PR #2486 mentions this in passing and leaves it for a separate change.

Tested on main ce12f1f6 (also 0.63.0; on 0.58.0 the Databricks input is a parse error).

Found with a property-based fuzzer (round trip check); I used AI assistance for triage and verified every case above.

Lenguaje dominante
Rust
Estrellas
3.5k
Forks
805
Merge medio
2 d 3 h
PR fusionados (30 d)
116

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/datafusion-sqlparser-rs

Todos los issues de apache/datafusion-sqlparser-rs

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.