ng add @angular/ssr fails with TypeError when an NgModule in the app module file has no bootstrap array

未關閉 適合新手
#34,761 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@0z5a 已經在處理了。

開始於 2026年11月19日。

  • #34762 來自 @0z5a —— 未關閉

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
90/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
angular, typescript

研究方向

從 packages/schematics/angular/utility/standalone/app_component.ts 中的 resolveNgModuleBasedData 開始,檢查它如何處理沒有 bootstrap 欄位的 @NgModule 裝飾器。閱讀附近現有的檢查,接著查看 server/index_spec.ts 中 server schematic 的測試涵蓋情況。當沒有 bootstrap 的裝飾器被略過、回報的兩種情況如描述般運作,且針對性測試通過時,即算完成。

由索引模型根據 Issue 內容生成。

描述

area: @schematics/angular
Command

add

Is this a regression?
  • Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was

I think before the server schematic started inferring the app component name (commit ea1143dd, April 2025). I have not run an older release to confirm.

Description

ng add @angular/ssr (and ng generate server) crashes on an NgModule-based app when one of the @NgModule decorators in the file that main.ts bootstraps has no bootstrap array. The cases I hit:

  1. The root module uses ngDoBootstrap() instead of bootstrap: [...] (Angular Elements apps, AngularJS hybrid apps that bootstrap through UpgradeModule).
  2. The file declares another @NgModule without bootstrap (for example a small shared module) before the root module.

In packages/schematics/angular/utility/standalone/app_component.ts, resolveNgModuleBasedData loops over the module's @NgModule decorators and does:

const bootstrapProp = getMetadataField(node, 'bootstrap').find(...);
const componentIdentifier = (bootstrapProp?.initializer as ts.ArrayLiteralExpression)
  .elements[0] as ts.Identifier | undefined;

When bootstrapProp is undefined, the optional chain stops at initializer and .elements is read from undefined. The function is meant to return null in that case: the caller in server/index.ts already falls back to App / AppModule when nothing is found. So the schematic stops with a TypeError instead of using the fallback (case 1) or the right module (case 2).

Minimal Reproduction
  1. ng new demo --no-standalone
  2. In src/app/app-module.ts, remove bootstrap: [App] and add ngDoBootstrap() {} to AppModule.
  3. ng add @angular/ssr

Or, for case 2, keep bootstrap: [App] and put this above AppModule in the same file:

@NgModule({ exports: [] })
export class SharedModule {}

I reproduced this with SchematicTestRunner against @schematics/angular 22.3.0 (workspace -> application --standalone=false -> edit the module -> server and ssr schematics). Both schematics throw for case 1, and server throws for case 2. The unmodified app works.

Exception or Error
TypeError: Cannot read properties of undefined (reading 'elements')
    at resolveNgModuleBasedData (node_modules/@schematics/angular/utility/standalone/app_component.js:65:14)
Your Environment
@schematics/angular 22.3.0
@angular-devkit/schematics 22.3.0
Node.js 22.23.5
Anything else relevant?

Skipping decorators that have no bootstrap field (continue, like the ts.isObjectLiteralExpression check just above it) is enough to fix both cases: case 2 then finds AppModule, and case 1 falls through to the existing fallback. I have a patch with two tests in server/index_spec.ts and can open a PR.

主要語言
TypeScript
星號
27k
分支
11.8k
平均合併
1 天 2 小時
30 天內合併 PR
225

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

angular/angular-cli 的其他 Issue

查看 angular/angular-cli 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。