Angular SSR can crash `AngularAppEngine` servers with a single aborted request (22.2.6 regression)

未關閉
#34,754 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@SkyZeroZx 已經在處理了。

開始於 2026年11月19日。

  • #34755 來自 @SkyZeroZx —— 未關閉

評估

難度
4/5
預估耗時
3-5 天
新手友好度
20/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
angular, bun, deno, node.js, typescript
領域
backend, security

研究方向

Start by reviewing the linked change in packages/angular/ssr/src/utils/ng.ts and the reported bootstrap and error handling paths in Angular core. Reproduce the abort with the linked minimal reproduction, especially its pending initializer and firstValueFrom() cases. Done means an aborted render no longer crashes an AngularAppEngine server while preserving the render cancellation behavior.

由索引模型根據 Issue 內容生成。

描述

area: @angular/ssr
Is this a regression?
  • Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was

22.2.5

Description

Since @angular/ssr 22.2.6, a client that disconnects while a page is still rendering can kill the server process when it runs on AngularAppEngine: plain node:http, Hono, H3, srvx, Deno or Bun. The Express server from ng new --ssr is fine, because AngularNodeAppEngine installs process-wide error handlers.

#34568 made renderAngular() destroy the platform when request.signal aborts:

https://github.com/angular/angular-cli/blob/72f44d79cb577821bbfa849f5bb3b41eee87c2ab/packages/angular/ssr/src/utils/ng.ts#L126-L129

The host still gets the usual AbortError and handles it. What kills the process is the work that was still running. The clearest case is an app initializer: once it settles, bootstrap() reads the destroyed injector, and the internal error handler rethrows the NG0205 from a setTimeout because the injector is destroyed. Neither the app nor the host's try/catch can catch that, so it doesn't matter how the initializer is written:

Pending when the client disconnects, on AngularAppEngine Process
provideAppInitializer from its usage notes exit 1
the same wrapped in try/catch exit 1
an initializer that only waits on a 100 ms timer exit 1
PendingTasks.run() as the zoneless guide shows it, awaiting an HttpClient call exit 1
firstValueFrom(http.get(...)) in async ngOnInit() (zoneless) exit 1
subscribe(), resolvers, guards, httpResource, resource() alive
the try/catch initializer on 22.2.5, or on AngularNodeAppEngine alive

The ngOnInit row is the other path: FetchBackend completes without a value once the app is destroyed, so firstValueFrom() rejects with EmptyError and nobody holds that promise. PendingTasks.run() passes that error to the same internal error handler, so it's rethrown from a setTimeout too.

It doesn't take precise timing. Every abort that arrived while the server was waiting on its backend killed it, 310 out of 310 with backends from 1 ms to 1 s, and nginx with its default config passes the abort on. The other pages that were rendering go down too. With Docker's restart: always, one aborted request every two seconds left the site serving 312 pages a minute instead of 5,584.

#34568 is right to stop the render, but the platform shouldn't be destroyed while that work is still pending, so the abort stays inside the promise handle() returns, the way it did on 22.2.5. AngularAppEngine is meant for platforms other than Node.js, so it can't count on process.on() handlers like AngularNodeAppEngine does.

Minimal Reproduction

https://github.com/SkyZeroZx/angular-ssr-abort-crash-lab

ng new --ssr with provideHttpClient(), RenderMode.Server on **, the SSR guide's non-Node entry on node:http, and a component that waits for its data during the render (api.mjs answers in 100 ms):

async ngOnInit() {
  const { name } = await firstValueFrom(
    this.http.get<{ name: string }>('http://127.0.0.1:4400/profile'),
  );
  this.profile.set(name);
}
npm ci && npx ng build
node api.mjs &
node dist/aborted-render-process/server/server.mjs &
sleep 2
curl -sS -o /dev/null -w "%{http_code}\n" http://localhost:4000/
curl -sS -m 0.05 http://localhost:4000/
sleep 1
curl -sS http://localhost:4000/
200
curl: (28) Operation timed out after 55 milliseconds with 0 bytes received
curl: (7) Failed to connect to localhost:4000 after 0 ms: Could not connect to server

The initializer version is in variants/initializer-trycatch, and cd docker && sh variants.sh initializer-trycatch builds and runs it. The README has the rest.

Exception or Error
The try/catch initializer, development build:

dist/aborted-render-process/server/main.server.mjs:4818
            throw e;
            ^

RuntimeError: NG0205: Injector has already been destroyed. Find more at https://v22.angular.dev/errors/NG0205
    at assertNotDestroyed (dist/aborted-render-process/server/main.server.mjs:3546:11)
    at R3Injector.get (dist/aborted-render-process/server/main.server.mjs:3303:5)
    at dist/aborted-render-process/server/main.server.mjs:26095:38
    at async renderAngular (dist/aborted-render-process/server/main.server.mjs:43273:24)


The ngOnInit repro, development build:

node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^
Error
    at new EmptyErrorImpl (dist/aborted-render-process/server/main.server.mjs:1783:3)
    at Object.complete (dist/aborted-render-process/server/main.server.mjs:1802:18) {
  message: 'no elements in sequence'
}
Your Environment
@angular/ssr      22.2.7
@angular/core     22.2.6, also 22.3.0
Node.js           24.16.0 on Windows 11, 24.22.3 in Docker
Also tried        Hono 4.13, H3 2.0, srvx 1.0, Deno 2.9.8, Bun 1.4.4, nginx 1.30
Anything else relevant?

I think this is a vulnerability according to the SECURITY.md, which says:

DoS attacks which waste server resources significantly beyond the cost of the attacker's request may be security issues.

Here a single request crashes the server.

主要語言
TypeScript
星號
27k
分支
11.8k
平均合併
1 天 2 小時
30 天內合併 PR
225

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

angular/angular-cli 的其他 Issue

查看 angular/angular-cli 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。