SSR route redirects drop the query string on relative `redirectTo`
維護者通常 1 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 45/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- express, nodejs, typescript
研究方向
Start in packages/angular/ssr/src/app.ts around lines 168-176, where the 302 Location is built from the stored redirectTo and url.search is never read. The reporter notes that redirectTo is already absolute by then, so the code must keep track of whether the redirect was relative, and the router's recognize.ts keeps the original query for relative redirects. Done means the relative case returns the query in Location, the absolute case is unchanged, and the curl command from the report shows /search/results?q=x.
由索引模型根據 Issue 內容生成。
描述
Command
other
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
When a request matches a route with a string redirectTo, @angular/ssr answers with a 302 built from the route config, without running the router. For a relative redirectTo, the query string of the request is dropped.
The Angular router keeps it: a relative redirect only rewrites the matched segments and continues with the rest of the URL. So /search?q=x with { path: '', redirectTo: 'results' } under search ends up at /search/results?q=x with in-app navigation, but at /search/results on a full page load (direct link, reload, link from an email).
For absolute redirects the router drops the query as well, so these already agree.
Minimal Reproduction
npx @angular/[email protected] new repro-app --ssr --defaults
cd repro-app
src/app/app.routes.ts:
import { Component } from '@angular/core';
import { Routes } from '@angular/router';
@Component({ template: 'Results page' })
class Results {}
export const routes: Routes = [
{
path: 'search',
children: [
{ path: '', redirectTo: 'results', pathMatch: 'full' },
{ path: 'results', component: Results },
],
},
];
src/app/app.routes.server.ts (server rendering, so the request reaches the redirect handling instead of a prerendered redirect page):
import { RenderMode, ServerRoute } from '@angular/ssr';
export const serverRoutes: ServerRoute[] = [{ path: '**', renderMode: RenderMode.Server }];
npx ng build
NG_ALLOWED_HOSTS=localhost PORT=4000 node dist/repro-app/server/server.mjs
curl -si 'localhost:4000/search?q=x' | grep -i '^location'
Expected: location: /search/results?q=x (where the router navigates). Actual: location: /search/results.
Exception or Error
$ curl -si 'localhost:4000/search?q=x' | head -3
HTTP/1.1 302 Found
X-Powered-By: Express
location: /search/results
Your Environment
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI : 22.2.2
Angular : 22.2.2
Node.js : 24.18.0
Package Manager : npm 11.16.0
Operating System : linux x64
┌───────────────────────────┬───────────────────┬───────────────────┐
│ Package │ Installed Version │ Requested Version │
├───────────────────────────┼───────────────────┼───────────────────┤
│ @angular/build │ 22.2.2 │ ^22.2.2 │
│ @angular/cli │ 22.2.2 │ ^22.2.2 │
│ @angular/common │ 22.2.2 │ ^22.2.0 │
│ @angular/compiler │ 22.2.2 │ ^22.2.0 │
│ @angular/compiler-cli │ 22.2.2 │ ^22.2.0 │
│ @angular/core │ 22.2.2 │ ^22.2.0 │
│ @angular/forms │ 22.2.2 │ ^22.2.0 │
│ @angular/platform-browser │ 22.2.2 │ ^22.2.0 │
│ @angular/platform-server │ 22.2.2 │ ^22.2.0 │
│ @angular/router │ 22.2.2 │ ^22.2.0 │
│ @angular/ssr │ 22.2.2 │ ^22.2.2 │
│ rxjs │ 7.8.2 │ ~7.8.0 │
│ typescript │ 6.0.3 │ ~6.0.2 │
└───────────────────────────┴───────────────────┴───────────────────┘
Anything else relevant?
app.ts#L168-L176 builds Location from the stored redirectTo and never uses url.search. By then redirectTo has already been resolved to an absolute path, so whether it was relative is no longer known.
Router side: for a relative redirect, recognize.ts keeps only the segments of the new tree and continues with the original URL tree, so the query is kept. An absolute redirect throws AbsoluteRedirect(newTree), whose query comes from redirectTo only. Render-time redirects (guards, router.navigate) already keep the query (#31883).
I have a fix with tests and will open a PR for it.
Not browser specific. Seen with the default Express server.ts generated by ng new --ssr; the redirect comes from AngularNodeAppEngine.handle(), not from Express itself.
- 主要語言
- TypeScript
- 星號
- 27k
- 分支
- 11.8k
- 平均合併
- 1 天 32 分鐘
- 30 天內合併 PR
- 138
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
angular/angular-cli 的其他 Issue
-
area: @angular/cli
難度 2/5 1-3 小時 新手友好度 78/100
angular/angular-cli#34307 ·
維護者通常 1 天內回覆
-
area: @angular/build gemini-triaged
難度 2/5 1-3 小時 新手友好度 74/100
angular/angular-cli#33955 ·
維護者通常 1 天內回覆
-
area: @angular/cli gemini-triaged
難度 2/5 1-3 小時 新手友好度 72/100
angular/angular-cli#33055 · 1 則留言 · 3 個 reaction ·
維護者通常 1 天內回覆
-
SSR resolves relative `redirectTo` against the wrong base when the route path has several segments可能已有人在做 @bschaeublin 於 2 天前認領。 未關閉area: @angular/ssr
難度 3/5 1-2 天 新手友好度 45/100
angular/angular-cli#34300 ·
維護者通常 1 天內回覆
-
area: @angular/build
難度 4/5 3-5 天 新手友好度 25/100
angular/angular-cli#34292 ·
維護者通常 1 天內回覆
查看 angular/angular-cli 的全部 Issue
相似的 Issue
-
area:tui enhancement platform:macos
難度 2/5 1-3 小時 新手友好度 66/100
anthropics/claude-code#101490 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 66/100
netlify/netlify-mcp#75 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
atlassian-labs/compiled#1960 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 75/100
pnp/cli-microsoft365#7639 ·
維護者通常 2 天內回覆
-
nextjs-tracking
難度 2/5 1-3 小時 新手友好度 74/100
cloudflare/vinext#3887 ·
維護者通常 1 天內回覆