SSR route redirects drop the query string on relative `redirectTo`
Mantenedores costumam responder em até 1 dia
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 45/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- express, nodejs, typescript
Direção de pesquisa
Start in packages/angular/ssr/src/app.ts around lines 168-176, where the 302 Location is built from the stored redirectTo and url.search is never read. The reporter notes that redirectTo is already absolute by then, so the code must keep track of whether the redirect was relative, and the router's recognize.ts keeps the original query for relative redirects. Done means the relative case returns the query in Location, the absolute case is unchanged, and the curl command from the report shows /search/results?q=x.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Command
other
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
When a request matches a route with a string redirectTo, @angular/ssr answers with a 302 built from the route config, without running the router. For a relative redirectTo, the query string of the request is dropped.
The Angular router keeps it: a relative redirect only rewrites the matched segments and continues with the rest of the URL. So /search?q=x with { path: '', redirectTo: 'results' } under search ends up at /search/results?q=x with in-app navigation, but at /search/results on a full page load (direct link, reload, link from an email).
For absolute redirects the router drops the query as well, so these already agree.
Minimal Reproduction
npx @angular/[email protected] new repro-app --ssr --defaults
cd repro-app
src/app/app.routes.ts:
import { Component } from '@angular/core';
import { Routes } from '@angular/router';
@Component({ template: 'Results page' })
class Results {}
export const routes: Routes = [
{
path: 'search',
children: [
{ path: '', redirectTo: 'results', pathMatch: 'full' },
{ path: 'results', component: Results },
],
},
];
src/app/app.routes.server.ts (server rendering, so the request reaches the redirect handling instead of a prerendered redirect page):
import { RenderMode, ServerRoute } from '@angular/ssr';
export const serverRoutes: ServerRoute[] = [{ path: '**', renderMode: RenderMode.Server }];
npx ng build
NG_ALLOWED_HOSTS=localhost PORT=4000 node dist/repro-app/server/server.mjs
curl -si 'localhost:4000/search?q=x' | grep -i '^location'
Expected: location: /search/results?q=x (where the router navigates). Actual: location: /search/results.
Exception or Error
$ curl -si 'localhost:4000/search?q=x' | head -3
HTTP/1.1 302 Found
X-Powered-By: Express
location: /search/results
Your Environment
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI : 22.2.2
Angular : 22.2.2
Node.js : 24.18.0
Package Manager : npm 11.16.0
Operating System : linux x64
┌───────────────────────────┬───────────────────┬───────────────────┐
│ Package │ Installed Version │ Requested Version │
├───────────────────────────┼───────────────────┼───────────────────┤
│ @angular/build │ 22.2.2 │ ^22.2.2 │
│ @angular/cli │ 22.2.2 │ ^22.2.2 │
│ @angular/common │ 22.2.2 │ ^22.2.0 │
│ @angular/compiler │ 22.2.2 │ ^22.2.0 │
│ @angular/compiler-cli │ 22.2.2 │ ^22.2.0 │
│ @angular/core │ 22.2.2 │ ^22.2.0 │
│ @angular/forms │ 22.2.2 │ ^22.2.0 │
│ @angular/platform-browser │ 22.2.2 │ ^22.2.0 │
│ @angular/platform-server │ 22.2.2 │ ^22.2.0 │
│ @angular/router │ 22.2.2 │ ^22.2.0 │
│ @angular/ssr │ 22.2.2 │ ^22.2.2 │
│ rxjs │ 7.8.2 │ ~7.8.0 │
│ typescript │ 6.0.3 │ ~6.0.2 │
└───────────────────────────┴───────────────────┴───────────────────┘
Anything else relevant?
app.ts#L168-L176 builds Location from the stored redirectTo and never uses url.search. By then redirectTo has already been resolved to an absolute path, so whether it was relative is no longer known.
Router side: for a relative redirect, recognize.ts keeps only the segments of the new tree and continues with the original URL tree, so the query is kept. An absolute redirect throws AbsoluteRedirect(newTree), whose query comes from redirectTo only. Render-time redirects (guards, router.navigate) already keep the query (#31883).
I have a fix with tests and will open a PR for it.
Not browser specific. Seen with the default Express server.ts generated by ng new --ssr; the redirect comes from AngularNodeAppEngine.handle(), not from Express itself.
- Linguagem predominante
- TypeScript
- Estrelas
- 27k
- Forks
- 11.8k
- Merge médio
- 1d 1h
- PRs com merge (30d)
- 161
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de angular/angular-cli
-
area: @angular/build gemini-triaged
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100
angular/angular-cli#33955 ·
Mantenedores costumam responder em até 1 dia
-
area: @angular/cli gemini-triaged
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
angular/angular-cli#33055 · 1 comentário · 3 reações ·
Mantenedores costumam responder em até 1 dia
-
SSR resolves relative `redirectTo` against the wrong base when the route path has several segmentsTalvez já em andamento @bschaeublin assumiu há 1 dia. Abertaarea: @angular/ssr
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 45/100
angular/angular-cli#34300 ·
Mantenedores costumam responder em até 1 dia
-
area: @angular/build
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 25/100
angular/angular-cli#34292 ·
Mantenedores costumam responder em até 1 dia
-
dev-server: es2016 prebundle target for zone.js apps lowers private fields and breaks dependenciesAbertaarea: @angular/build
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 48/100
angular/angular-cli#34280 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de angular/angular-cli
Issues semelhantes
-
effort:S priority:P2
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
cameri/nostream#811 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
dam-agents/dam#4562 ·
Mantenedores costumam responder em até 1 dia
-
bug p3 triaged
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
Mantenedores costumam responder em até 1 dia
-
bug javascript P2-medium python release:v3.1
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
adrirubio/claude-deck#546 ·
Mantenedores costumam responder em até 1 dia