Initial subset rejection loops in useLiveSuspenseQuery instead of reaching ErrorBoundary
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 57/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- react, typescript
- 領域
- backend
研究方向
Start with packages/react-db/src/useLiveSuspenseQuery.ts, especially SuspenseBinding.resolve and the zero-delay retry-entry release described in the issue. Reproduce with the supplied Vite fixture and ?fail, then trace how the failed resource is retained through React’s retry and collection cleanup. Done when one failed load reaches the surrounding ErrorBoundary without repeated loader calls, while cleanup and recovery behavior remain correct.
由索引模型根據 Issue 內容生成。
描述
Describe the bug
A rejected initial loadSubset under useLiveSuspenseQuery + DbProvider can repeatedly recreate the query and call the failing loader instead of reaching the surrounding ErrorBoundary.
This reproduction only returns Promise.reject(error). It does not call sync.fail, configure retries, use short gcTime, or perform a refetch. It therefore also affects query-local first-load errors.
Expected / actual
- Expected: one failed initial acquisition, followed by the ErrorBoundary receiving
Subset denied. - Actual: the fallback stays visible and loads repeat. The included isolated browser run made 5,864 loader calls in about one second, with no boundary output. Exact counts vary with machine speed.
- Retaining the failed Suspense resource until normal collection cleanup gives one loader call and the expected ErrorBoundary.
Reproduction
Use a Vite React/TypeScript app with @tanstack/[email protected], @tanstack/[email protected], [email protected], and [email protected]. Replace src/main.tsx with the code below. The HTML should contain <div id="root"></div>.
No router, external service, persistence adapter, fragments, React Compiler, or application-specific code is required. The two URL modes share a fixture so they can also act as controls.
Complete main.tsx
import { collectionOptions, DbClient, eq } from '@tanstack/db';
import { DbProvider, useLiveSuspenseQuery } from '@tanstack/react-db';
import { Component, Suspense, useLayoutEffect, useState, type ReactNode } from 'react';
import { createRoot } from 'react-dom/client';
// Run ?fail for the rejection case; omit it for synchronous cached queries.
const fail = new URLSearchParams(location.search).has('fail');
const metrics = { loads: 0, fallbacks: 0, rendered: 0, start: 0, elapsed: 0 };
const items = collectionOptions({
id: 'items',
getKey: (row: { id: string; title: string }) => row.id,
syncMode: 'on-demand',
sync: {
sync: ({ begin, write, commit, markReady }) => {
begin();
for (let i = 0; i < 20; i++) {
write({ type: 'insert', value: { id: String(i), title: `Item ${i}` } });
}
void commit();
markReady();
return {
loadSubset: () => {
metrics.loads++;
return fail ? Promise.reject(new Error('Subset denied')) : true;
},
};
},
},
});
const client = new DbClient();
const source = client.collection(items);
await source.preload();
function Detail({ id }: { id: string }) {
metrics.rendered++;
const { data } = useLiveSuspenseQuery(q =>
q.from({ item: source })
.where(({ item }) => eq(item.id, id))
.select(({ item }) => ({ title: item.title }))
.findOne(),
);
useLayoutEffect(() => {
metrics.elapsed = performance.now() - metrics.start;
console.log('committed', { ...metrics });
}, [id]);
return <output data-testid="result">{data?.title}</output>;
}
function Pending() {
useLayoutEffect(() => { metrics.fallbacks++; }, []);
return <p data-testid="pending">Pending</p>;
}
class Boundary extends Component<{ children: ReactNode }, { error?: string }> {
state: { error?: string } = {};
static getDerivedStateFromError(error: Error) { return { error: error.message }; }
render() {
return this.state.error
? <p data-testid="error">{this.state.error}</p>
: this.props.children;
}
}
function ReadyExample() {
// A mounted inventory query already holds the source rows.
useLiveSuspenseQuery(q => q.from({ item: source }).select(({ item }) => ({ id: item.id })));
const [id, setId] = useState<number>();
return <>
<button onClick={() => {
metrics.start = performance.now();
setId(previous => (previous ?? -1) + 1);
}}>Select cached row</button>
{id !== undefined && <Suspense key={id} fallback={<Pending />}>
<Detail id={String(id)} />
</Suspense>}
</>;
}
const root = createRoot(document.getElementById('root')!);
root.render(<DbProvider client={client}>
<Boundary>
<Suspense fallback={<Pending />}>
{fail ? <Detail id="0" /> : <ReadyExample />}
</Suspense>
</Boundary>
</DbProvider>);
Reflect.set(window, 'repro', {
metrics,
close: async () => { root.unmount(); await client.cleanup(); },
});
Open with ?fail. Read window.repro.metrics.loads, inspect the pending/error elements, and call window.repro.close() or close the page afterward to stop the loop.
Suspected cause
SuspenseBinding.resolve in packages/react-db/src/useLiveSuspenseQuery.ts evicts the retry entry with setTimeout(release, 0) when the collection becomes error or crashed. The failed resource can disappear before React retries the initially suspended render. That retry creates a fresh resource, which starts the same failing load again.
Keeping that entry through the React retry, and releasing it on the collection's ordinary cleaned-up event, fixes this reproduction. It still needs to respect explicit cleanup/recovery and abandoned-query lifetime; the proposal is not to keep failures forever.
Related: #1343 was closed after error forwarding was fixed. This appears to be a remaining resource-lifetime case, rather than missing observer-error forwarding. #2396 uses the success mode of the same small fixture for a separate synchronous-readiness problem.
Versions
@tanstack/db / @tanstack/react-db 1.0.0-rc.1.4, React / React DOM 19.3.0, Chromium on macOS ARM64. The zero-delay eviction remains on current main. No router, React Compiler, application adapter, or persistence is involved.
- 主要語言
- TypeScript
- 星號
- 4k
- 分支
- 286
- 平均合併
- 1 天 8 小時
- 30 天內合併 PR
- 105
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
TanStack/db 的其他 Issue
-
extractSimpleComparisons returns value: null when the right side of a comparison isn't a literal未關閉
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
`avg`, `min`, `max` and `sum` treat `null` values as `0`可能已有人在做 @oyobbeb 於 11 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
`Collection.currentStateAsChanges` JSDoc examples don’t match `CurrentStateAsChangesOptions`可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉
難度 1/5 1-3 小時 新手友好度 88/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
Two @tanstack/db tests time out under CPU load because a cold module import counts against the 5 s default timeout可能已有人在做 @jp-knj 於 23 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
fb55/htmlparser2#2579 ·
維護者通常 1 天內回覆
-
bug good first issue needs-review
難度 1/5 1-3 小時 新手友好度 83/100
維護者通常 1 天內回覆
-
documentation public
難度 1/5 1-3 小時 新手友好度 68/100
midnightntwrk/umbradb#65 ·
維護者通常 2 天內回覆
-
area/channels kind/bug priority/medium
難度 2/5 1-3 小時 新手友好度 78/100
nanocoai/nanoclaw#4501 · 1 則留言 ·
維護者通常 1 天內回覆
-
needs verification
難度 2/5 1-3 小時 新手友好度 74/100
維護者通常 13 天內回覆