Rebind keys per seat for two-player modes
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 55/100
- Issue 類型
- 功能
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- typescript, vite
研究方向
Start with PLAYER_KEYS and resolveDefaults in shared/controls.ts, then read the sanitizing and clash handling in shared/settings.ts (around lines 239-255). The settings panel is in src/hub/settings-panel.ts, and shared/settings.test.ts is where the new tests belong. Run npm test; done means seat bindings persist, can be changed and restored on the hub, and clash checks cover them.
由索引模型根據 Issue 內容生成。
描述
Summary
Let players rebind the keyboard keys for player 1 and player 2 in two-player modes.
Where
shared/controls.ts:42-49(PLAYER_KEYS: WASD + Space/Shift, arrows + Enter/Ctrl)shared/controls.ts:97-115(resolveDefaultsignores custom bindings for seats, except Pause and Mute)shared/settings.ts:239-255(clash handling covers only Pause and Mute)
Details
The two keyboard halves are fixed. The gamepad rebinding work (#71) deliberately left per-seat keys out.
Proposal
Add seatBindings: { 1?: ..., 2?: ... } to Settings (sanitized like bindings), have resolveDefaults prefer it over PLAYER_KEYS, add a "Player 1 / Player 2 keys" section to the hub settings panel that reuses the existing capture and clash checks, and include seat keys in the clash set sharedKeyCodes uses.
Who benefits
Players on non-QWERTY layouts (AZERTY moves A and W), laptops without a right Ctrl, or keyboards that drop some key combinations, in Snake versus, Pong versus and Siege co-op.
Acceptance criteria
- Each seat's keys can be changed and restored on the hub.
-
shared/settings.test.tscovers sanitizing and clashes for seat bindings.
Getting started
- Relevant files:
shared/controls.ts,shared/settings.ts,src/hub/settings-panel.ts - How to run tests:
npm test - Related: #63, #71
Filed by repo-audit/full-audit at de2b25b. Severity: low. Effort: M. audit-key: enhancement|shared/controls.ts|PLAYER_KEYS
- 主要語言
- TypeScript
- 星號
- 3
- 分支
- 3
- 平均合併
- 10 小時 22 分鐘
- 30 天內合併 PR
- 6
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
TMHSDigital/GH-Arcade 的其他 Issue
-
good first issue performance severity: low
難度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/GH-Arcade#141 ·
維護者通常 1 天內回覆
-
enhancement help wanted severity: low
難度 4/5 3-5 天 新手友好度 55/100
TMHSDigital/GH-Arcade#139 ·
維護者通常 1 天內回覆
-
enhancement help wanted severity: medium
難度 4/5 3-5 天 新手友好度 56/100
TMHSDigital/GH-Arcade#127 ·
維護者通常 1 天內回覆
-
enhancement help wanted severity: medium
難度 4/5 3-5 天 新手友好度 48/100
TMHSDigital/GH-Arcade#126 · 1 則留言 ·
維護者通常 1 天內回覆
-
accessibility enhancement severity: low
難度 4/5 3-5 天 新手友好度 40/100
TMHSDigital/GH-Arcade#114 ·
維護者通常 1 天內回覆
查看 TMHSDigital/GH-Arcade 的全部 Issue
相似的 Issue
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
難度 2/5 1-3 小時 新手友好度 76/100
openclaw/openclaw#203385 · 1 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
nwverse/persona#12800 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 80/100
維護者通常 1 天內回覆
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未關閉
難度 2/5 1-3 小時 新手友好度 62/100
microsoft/playwright#44289 ·
維護者通常 1 天內回覆
-
good first issue
難度 2/5 半天 新手友好度 65/100
維護者通常 1 天內回覆