Agent-mode npm `vex` hashes only the first installed copy of a package, so it attests not_affected while another nested copy of the same name@version is unpatched
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Read crates/socket-patch-cli/src/commands/vex.rs:556 and ecosystem_dispatch.rs:401, then review the verification table in crates/socket-patch-cli/CLI_CONTRACT.md:390. Run the supplied npm reproduction to observe the incorrect not_affected result. Done means agent-mode attestation accounts for every installed copy of the PURL and matches the documented not_applied or hash_mismatch behavior when any copy is unpatched.
由索引模型根據 Issue 內容生成。
描述
[agent] Found by the scheduled npm bug-hunt routine (ledger #302).
Summary
In agent mode, vex checks only the first installed copy of each manifest PURL (crates/socket-patch-cli/src/commands/vex.rs:556, let package_paths = collapse_to_first(copies.clone());). Hosted-basis PURLs are checked against every copy (vex_consumed::hosted_consumed_copies), but agent records are not. When an npm tree holds several nested copies of the same name@version and only some of them are patched, the verdict depends on crawl order:
- first copy patched, another copy unpatched →
not_affected(wrong); - first copy unpatched, another copy patched →
not_applied(right, by luck).
The Deno routine found this (handover on #302). I confirmed it with plain npm, where the trigger is common: apply patches every copy present, and a later npm install of a new dependent extracts a fresh, unpatched nested copy while leaving the patched one alone.
Impact
The VEX document says not_affected while an unpatched copy of the vulnerable code is still in node_modules and gets loaded by its dependent (is-accessor-descriptor here). apply is fine: re-running it patches the new copy. Only the attestation is wrong.
Repro (real npm, Linux, main 61cfb9b)
SP=/path/to/target/release/socket-patch
mkdir npmdup && cd npmdup && echo '{"name":"npmdup","version":"1.0.0"}' > package.json
npm install [email protected] [email protected] # nests [email protected] under is-number
# Hand-stage .socket/manifest.json + .socket/blobs with a patch for pkg:npm/[email protected]
# that changes package/index.js (beforeHash = pristine, afterHash = pristine + a comment line),
# with one vulnerability carrying a CVE. Any free patch works too.
$SP apply --offline # 1 of 1 targeted patch applied
npm install [email protected] # adds is-accessor-descriptor/node_modules/[email protected], unpatched
$SP vex --offline -O v.json; echo $? # exit 0, 1 statement: not_affected
State after the second install:
node_modules/is-number/node_modules/kind-of 3.2.2 patched
node_modules/is-accessor-descriptor/node_modules/kind-of 3.2.2 UNPATCHED
node_modules/kind-of 6.0.3 (not targeted)
vex output: Wrote OpenVEX document with 1 statement to v.json, status not_affected.
Crawl-order check on the same tree: restore the is-number copy to pristine and patch the is-accessor-descriptor copy instead, and vex omits the PURL (not_applied) and exits with "No applied patches with vulnerability metadata to attest."
Expected vs actual
- Expected: CLI_CONTRACT.md's verification table (
crates/socket-patch-cli/CLI_CONTRACT.md:390) says an agent record is verified against "the installed tree". An attestation should hold only when every installed copy the crawler finds for that PURL hashes to the patched bytes, as the hosted path already requires. Otherwise the PURL should be omitted (not_applied/hash_mismatch). - Actual: only the first copy is hashed, and
not_affectedis emitted with exit 0.
Matrix
| OS | npm | Node | main 61cfb9b |
v4.0.0 (with setup.manual: ["npm"]) |
|---|---|---|---|---|
| Linux | 8.19.4 | 22.22 | reproduces | not run |
| Linux | 10.9.4 | 22.22 | reproduces (2/2) | reproduces |
| Linux | 12.2.0 | 22.22 | reproduces | not run |
| macOS / Windows | — | — | not probed (the logic isn't OS-specific) | — |
First bad version
This isn't a v5 regression: v4.0.0 emits the same single not_affected statement once setup.manual is set. I didn't bisect further.
Suspect code
crates/socket-patch-cli/src/commands/vex.rs:556:collapse_to_first(copies.clone())feedsapplied_patches_with_vendor, which hashes one path per PURL for agent records.crates/socket-patch-cli/src/ecosystem_dispatch.rs:401:collapse_to_first.
The same pattern probably hits every npm-family layout that can hold several copies of one version (yarn classic and bun hoisted, Deno's hoisted linker, pnpm peer variants), but this issue covers npm only.
Related but different: #325 (bundled copies, hosted in-run --vex), #435 (pnpm global), #405 (bun isolated).
- 主要語言
- Rust
- 星號
- 8
- 分支
- 1
- 平均合併
- 17 小時 5 分鐘
- 30 天內合併 PR
- 557
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
SocketDev/socket-patch 的其他 Issue
-
agent:triaged bug bughunt pm:npm priority:p3 ux
難度 2/5 1-3 小時 新手友好度 75/100
SocketDev/socket-patch#1072 · 2 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:yarn-berry priority:p1
難度 2/5 1-3 小時 新手友好度 73/100
SocketDev/socket-patch#783 · 1 則留言 ·
維護者通常 1 天內回覆
-
Vendored cargo warns cargo_multi_version_old_cargo ("declares no rust-version") when the root package inherits rust-version from [workspace.package]可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉agent:triaged bug bughunt pm:cargo priority:p2
難度 2/5 1-3 小時 新手友好度 84/100
SocketDev/socket-patch#651 · 3 則留言 ·
維護者通常 1 天內回覆
-
bug bughunt pm:npm
難度 4/5 1-2 天 新手友好度 45/100
SocketDev/socket-patch#1534 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:bundler priority:p1
難度 4/5 3-5 天 新手友好度 35/100
SocketDev/socket-patch#1531 · 1 則留言 ·
維護者通常 1 天內回覆
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
bytecodealliance/rustix#1703 ·
維護者通常 3 天內回覆
-
bug discussion
難度 2/5 1-3 小時 新手友好度 70/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 74/100
farion1231/cc-switch#8298 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 74/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
ajeetdsouza/zoxide#1323 ·
維護者通常 1 天內回覆