Nightly mode_migration_vlt red: vendor tests predate #1648 eject
維護者通常 1 天內回覆
已經有一個關聯 PR 被合併了。
- #1775 來自 @mikolalysenko —— 已合併
評估
研究方向
Start in crates/socket-patch-cli/tests/mode_migration_vlt.rs at the three assertion blocks named: lines 310-313, 360-363, and 385-388. Compare them with the eject contract already asserted in mode_migration_bun.rs after #1648, then update the vlt migration tests to expect eject_planned and no vendor_takeover_reverted_redirect/vendor_would_revert_redirect. Run the vlt_pinned_matrix tests or the nightly e2e-extended leg for mode_migration_vlt to confirm the stale advisory assertions are gone.
由索引模型根據 Issue 內容生成。
描述
[agent] Filed by the CI-lane fixer.
The nightly CI run on main (40639505834, head b787454) fails e2e-extended (mode_migration_vlt, *, --include-ignored vlt_pinned_matrix) on every vlt leg (vlt 0.0.0-32, 1.0.0-rc.14, 1.2.0 on Linux, plus the Windows/macOS legs):
thread 'vlt_pinned_matrix_migration_hosted_then_vendored' panicked at crates/socket-patch-cli/tests/mode_migration_vlt.rs:312:9:
vendor: exit 0
... "errorCode": "vendor_prebuilt_downloaded" ... "vendor_vlt_reinstall_required" ...
failures:
vlt_pinned_matrix_migration_dry_run_parity
vlt_pinned_matrix_migration_hosted_then_vendored
Root cause: #1648 made plain vendor with a hosted pin in scope an eject (dry run reports eject_planned, the wet run no longer emits vendor_takeover_reverted_redirect). It updated the PR-tier migration suites (mode_migration_bun.rs, _npm, _cargo, _pypi) but missed mode_migration_vlt.rs, whose tests are #[ignore] (real vlt) and run only in the nightly e2e-extended legs. The vendor runs themselves succeed; only the stale advisory assertions fail:
mode_migration_vlt.rs:310-313(hosted_then_vendored,vendordriver) expectsvendor_takeover_reverted_redirect.mode_migration_vlt.rs:360-363(dry_run_parity) expectsvendor_would_revert_redirectfromvendor --dry-run.mode_migration_vlt.rs:385-388(dry_run_parity) expectsvendor_takeover_reverted_redirectfrom the wetvendor.
Fix (test-only): assert the eject contract the bun suite now asserts. Sibling of #1770 (same #1648 fallout in e2e_bun_lockb.rs).
Generated by Claude Code
- 主要語言
- Rust
- 星號
- 8
- 分支
- 2
- 平均合併
- 19 小時 12 分鐘
- 30 天內合併 PR
- 709
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
SocketDev/socket-patch 的其他 Issue
-
agent:triaged arch-audit priority:p3 refactor
難度 2/5 1-3 小時 新手友好度 83/100
SocketDev/socket-patch#1860 ·
維護者通常 1 天內回覆
-
agent:triaged arch-audit priority:p3 refactor
難度 2/5 1-3 小時 新手友好度 78/100
SocketDev/socket-patch#1838 ·
維護者通常 1 天內回覆
-
Share one scoped env-var test guard: EnvGuard is copy-pasted 11 times across core unit and integration tests可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged arch-audit priority:p3 refactor
難度 4/5 3-5 天 新手友好度 55/100
SocketDev/socket-patch#1889 · 2 則留言 ·
維護者通常 1 天內回覆
-
Memoize env-keyed subprocess probes through one helper: composer, python and ruby each define the same env key and drifted on when an answer is kept可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged arch-audit priority:p1 refactor
難度 4/5 1-2 天 新手友好度 25/100
SocketDev/socket-patch#1888 · 3 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged arch-audit priority:p3 refactor
難度 4/5 1-2 天 新手友好度 55/100
SocketDev/socket-patch#1887 · 1 則留言 ·
維護者通常 1 天內回覆
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 76/100
Y-ASLant/ElegantClipboard#178 ·
-
難度 2/5 1-3 小時 新手友好度 82/100
linxiv-dev/linXiv#384 · 1 則留言 ·
維護者通常 1 天內回覆
-
bug drawings ui
難度 2/5 1-3 小時 新手友好度 82/100
userFRM/egui-charts#1595 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
smoltcp-rs/smoltcp#1235 ·
維護者通常 1 天內回覆
-
scope:core type:security
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 1 天內回覆