Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Nightly mode_migration_vlt red: vendor tests predate #1648 eject

Fechada
  • Algo errado?
#1,774 2 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Um pull request relacionado já foi integrado.

  • #1775 de @mikolalysenko — integrado

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
testing

Direção de pesquisa

Start in crates/socket-patch-cli/tests/mode_migration_vlt.rs at the three assertion blocks named: lines 310-313, 360-363, and 385-388. Compare them with the eject contract already asserted in mode_migration_bun.rs after #1648, then update the vlt migration tests to expect eject_planned and no vendor_takeover_reverted_redirect/vendor_would_revert_redirect. Run the vlt_pinned_matrix tests or the nightly e2e-extended leg for mode_migration_vlt to confirm the stale advisory assertions are gone.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

agent:claimed agent:triaged ci-janitor priority:p3

[agent] Filed by the CI-lane fixer.

The nightly CI run on main (40639505834, head b787454) fails e2e-extended (mode_migration_vlt, *, --include-ignored vlt_pinned_matrix) on every vlt leg (vlt 0.0.0-32, 1.0.0-rc.14, 1.2.0 on Linux, plus the Windows/macOS legs):

thread 'vlt_pinned_matrix_migration_hosted_then_vendored' panicked at crates/socket-patch-cli/tests/mode_migration_vlt.rs:312:9:
vendor: exit 0
  ... "errorCode": "vendor_prebuilt_downloaded" ... "vendor_vlt_reinstall_required" ...
failures:
    vlt_pinned_matrix_migration_dry_run_parity
    vlt_pinned_matrix_migration_hosted_then_vendored

Root cause: #1648 made plain vendor with a hosted pin in scope an eject (dry run reports eject_planned, the wet run no longer emits vendor_takeover_reverted_redirect). It updated the PR-tier migration suites (mode_migration_bun.rs, _npm, _cargo, _pypi) but missed mode_migration_vlt.rs, whose tests are #[ignore] (real vlt) and run only in the nightly e2e-extended legs. The vendor runs themselves succeed; only the stale advisory assertions fail:

  • mode_migration_vlt.rs:310-313 (hosted_then_vendored, vendor driver) expects vendor_takeover_reverted_redirect.
  • mode_migration_vlt.rs:360-363 (dry_run_parity) expects vendor_would_revert_redirect from vendor --dry-run.
  • mode_migration_vlt.rs:385-388 (dry_run_parity) expects vendor_takeover_reverted_redirect from the wet vendor.

Fix (test-only): assert the eject contract the bun suite now asserts. Sibling of #1770 (same #1648 fallout in e2e_bun_lockb.rs).

Generated by Claude Code

Linguagem predominante
Rust
Estrelas
8
Forks
2
Merge médio
19h 12min
PRs com merge (30d)
709

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de SocketDev/socket-patch

Todas as issues de SocketDev/socket-patch

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.