Nightly e2e_bun_lockb red: offline takeover test predates #1648
維護者通常 1 天內回覆
已經有一個關聯 PR 被合併了。
- #1771 來自 @mikolalysenko —— 已合併
評估
研究方向
Start at crates/socket-patch-cli/tests/e2e_bun_lockb.rs:928 in native_binary_hosted_vendored_takeover_roundtrip, where the assertion still expects redirect_revert_failed. Run that test with bun 1.0.36 on main to see vendor --offline --dry-run exit 1 with the top-level offline_eject_unavailable error, then update the step to assert that error, exit code 1, and no files written. Check the remaining roundtrip assertions still hold. Note PR #1771 is already open against this, so coordinate before starting.
由索引模型根據 Issue 內容生成。
描述
[agent] The nightly e2e-extended legs e2e_bun_lockb (bun 1.0.36 and 1.1.45) have been red on main since #1648 merged.
Evidence
- Run https://github.com/SocketDev/socket-patch/actions/runs/40639505834 (schedule, main
b787454, 2026-10-28), jobs 122654524514 and 122654524565. native_binary_hosted_vendored_takeover_roundtrippanics atcrates/socket-patch-cli/tests/e2e_bun_lockb.rs:928:expected redirect_revert_failed, butvendor --offline --dry-runnow returns the top-level erroroffline_eject_unavailable("ejecting 1 hosted package needs 1 patch record(s) from the Socket API, and this run is offline; re-run without --offline").- Reproduces locally with bun 1.0.36 on
origin/main.
Cause
#1648 (vendor hosted patches directly from lockfiles) made vendor --offline refuse up front whenever a hosted pin is in scope, which its description records as the chosen behaviour. This test still expects the older per-pin redirect_revert_failed event. It only runs on the bun 1.0/1.1 legs, which are nightly-only, so the PR and merge-queue runs never exercised it.
Fix
Update the test's offline-refusal step to the new contract (exit 1, offline_eject_unavailable, nothing written), and check that the rest of the roundtrip still holds.
Generated by Claude Code
- 主要語言
- Rust
- 星號
- 8
- 分支
- 2
- 平均合併
- 19 小時 31 分鐘
- 30 天內合併 PR
- 686
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
SocketDev/socket-patch 的其他 Issue
-
bug bughunt pm:npm
難度 4/5 3-5 天 新手友好度 53/100
SocketDev/socket-patch#1827 · 1 則留言 ·
維護者通常 1 天內回覆
-
Go apply, apply --check and vex treat a module that is only another module's replace target as built, so the patch is reported applied and attested while go builds the unpatched code可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged bug bughunt pm:go priority:p2
難度 4/5 3-5 天 新手友好度 48/100
SocketDev/socket-patch#1823 · 3 則留言 ·
維護者通常 1 天內回覆
-
Vendored gem mode writes the rewired `gem` line of a CRLF Gemfile with an LF ending, leaving the Gemfile with mixed line endings可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged bug bughunt pm:bundler priority:p1
難度 3/5 1-2 天 新手友好度 25/100
SocketDev/socket-patch#1821 · 3 則留言 ·
維護者通常 1 天內回覆
-
CI perf: workflow_dispatch of CI — Windows-only janitor fixes re-run the full Linux + macOS nightly matrix (~100 min/day, ~30 macOS)可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged ci-perf priority:p3
難度 4/5 3-5 天 新手友好度 1/100
SocketDev/socket-patch#1818 · 3 則留言 ·
維護者通常 1 天內回覆
-
Nightly Windows: 3 Go workspace unit tests fail (Unix-only GOWORK paths)可能已有人在做 @mikolalysenko 今天認領。 未關閉agent:claimed agent:triaged ci-janitor priority:p3
難度 3/5 1-2 天 新手友好度 35/100
SocketDev/socket-patch#1815 · 2 則留言 ·
維護者通常 1 天內回覆
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
swc-project/swc-next#1165 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 73/100
Alive24/shea-symphony#574 ·
-
bug tests Windows
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
documentation good first issue help wanted
難度 2/5 1-3 小時 新手友好度 74/100
dev-five-git/devup-ui#879 ·
維護者通常 11 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 77/100
farion1231/cc-switch#9038 · 1 則留言 ·
維護者通常 1 天內回覆