Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

`apply --check` drift report tells you to run `socket-patch apply` without the `-g` / `--global-prefix` / `--cwd` it was given, so following it patches nothing and exits 0

未關閉 適合新手
  • 哪裡不對？
#1,219 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@mikolalysenko 已經在處理了。

開始於 2026年10月9日。

  • #1325 來自 @mikolalysenko —— 未關閉

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
72/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
python, rust
領域
cli

研究方向

錯誤的修復方式是 crates/socket-patch-cli/src/commands/apply.rs 中 run_check 內、約第 674 行處寫死的 eprintln!，它忽略了 args.common（global、global_prefix、cwd、manifest_path、ecosystems）。請以 #777 修復中 scan -g 使用的 report_only_hint 輔助函式為範本，並用相同的範圍參數建構 apply 指令。當輸出的修復指令在 issue 的重現步驟之後原樣執行，能夠修復副本，且之後的 apply --check 以結束碼 0 結束時，即為完成。

由索引模型根據 Issue 內容生成。

描述

agent:triaged bug bughunt pm:pipenv priority:p1

[agent] Found by the scheduled Pipenv bug-hunt routine (ledger #313).

Summary

When apply --check finds drift, the human report always ends with the fixed line:

Error: Patches are OUT OF SYNC:
  pkg:pypi/[email protected]: patch not applied (an installed copy is still unpatched)
Run `socket-patch apply` to regenerate them.

The suggested command drops every scope flag the check ran with. The check itself is correct (exit 1 on the stale copy), but running the remedy as printed targets a different tree:

  • apply --check -g --global-prefix <site-packages> (the Docker pipenv install --system shape): plain socket-patch apply crawls the cwd project, prints 0 of 1 targeted patch applied, … 1 not found on disk, and exits 0. The global copy stays unpatched. apply -g without the prefix patches the default system interpreter instead. In the sandbox that was the distro's /usr/lib/python3/dist-packages/six.py, which isn't the tree that was checked.
  • apply --check --cwd app (CI running from a parent directory): plain socket-patch apply prints No patch manifest found; nothing to apply. and exits 0. The Pipenv venv stays unpatched.

This is the same class as #464 (the report-only scan -g hint dropped -g), which was fixed in #777. The apply --check report wasn't covered by that fix.

Impact

apply --check is the CI / GitHub-App audit gate (CLI_CONTRACT apply --check row). A user or CI job that follows its remedy gets exit 0 and believes the drift is fixed. The next apply --check fails again, and the installed copy keeps running unpatched bytes in the meantime. There's no false VEX: this is a misleading remedy, not a wrong verdict.

Repro (Linux, main f3c6313, Pipenv 2026.8.0, local mock of the patch API serving a patched six-1.16.0 wheel)

# global / Docker `pipenv install --system` shape
G=$(mktemp -d)/sys; python3.11 -m venv "$G"; SPK=$G/lib/python3.11/site-packages
"$G/bin/pip" install six==1.16.0
cd my-pipenv-project                       # Pipfile + Pipfile.lock pinning six==1.16.0
socket-patch scan -g --global-prefix "$SPK" --mode agent --yes      # patches $SPK/six.py
"$G/bin/pip" install --force-reinstall --no-deps six==1.16.0       # image rebuilt / reinstall
socket-patch apply --check -g --global-prefix "$SPK"               # exit 1, "Run `socket-patch apply` to regenerate them."
socket-patch apply                                                 # the remedy verbatim: exit 0, "1 not found on disk"
head -1 "$SPK/six.py"                                              # still the upstream bytes

# --cwd shape (agent mode, Pipenv WORKON_HOME venv)
socket-patch scan --cwd app --mode agent --yes
(cd app && pipenv run pip install --force-reinstall --no-deps six==1.16.0)
socket-patch apply --check --cwd app       # exit 1, same remedy line
socket-patch apply                         # exit 0, "No patch manifest found; nothing to apply."

I reproduced the -g --global-prefix lane 3 times and the --cwd lane once. In both, the remedy with the original flags (apply -g --global-prefix "$SPK", apply --cwd app) heals the tree, and the next --check exits 0.

Expected vs actual

  • Expected: the remedy names the command that fixes what the check just reported. That means the same scope as the check: -g, --global-prefix <dir>, --cwd <dir>, and --manifest-path / --ecosystems when given. That's how #464 / #777 fixed the scan -g hint. CLI_CONTRACT's apply --check row specifies the Error: Patches are OUT OF SYNC: report, and its purpose is to be acted on.
  • Actual: a fixed string with no scope flags. Following it exits 0 and patches nothing, or patches a different interpreter (-g without the prefix).

OS × version

OS Pipenv Shape Result
Linux 2026.8.0 apply --check -g --global-prefix (pip-installed six, install --system shape) reproduces (×3)
Linux 2026.8.0 apply --check --cwd app (WORKON_HOME venv) reproduces
macOS / Windows not probed the line is a constant string expected to be the same

This isn't Pipenv- or PyPI-specific: every ecosystem's apply --check goes through the same branch.

Suspect code

crates/socket-patch-cli/src/commands/apply.rs:674, in run_check: eprintln!("Run \socket-patch apply` to regenerate them.");doesn't consultargs.common (global, global_prefix, cwd, manifest_path, ecosystems). Compare report_only_hint` after #777.

主要語言
Rust
星號
8
分支
0
平均合併
22 小時 30 分鐘
30 天內合併 PR
329

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

SocketDev/socket-patch 的其他 Issue

查看 SocketDev/socket-patch 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。