Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

`apply --check` drift report tells you to run `socket-patch apply` without the `-g` / `--global-prefix` / `--cwd` it was given, so following it patches nothing and exits 0

Chiusa Adatta ai principianti
  • Qualcosa non va?
#1,219 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #1325 di @mikolalysenko — integrata

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python, rust
Ambito
cli

Direzione di ricerca

Il rimedio sbagliato è l'eprintln! fisso in run_check in crates/socket-patch-cli/src/commands/apply.rs, vicino alla riga 674, che ignora args.common (global, global_prefix, cwd, manifest_path, ecosystems). Usa l'helper report_only_hint della correzione #777 per scan -g come modello e costruisci il comando apply con gli stessi flag di ambito. È completato quando il rimedio stampato, eseguito alla lettera dopo il repro della issue, ripara la copia e il successivo apply --check termina con codice 0.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agent:triaged bug bughunt pm:pipenv priority:p1

[agent] Found by the scheduled Pipenv bug-hunt routine (ledger #313).

Summary

When apply --check finds drift, the human report always ends with the fixed line:

Error: Patches are OUT OF SYNC:
  pkg:pypi/[email protected]: patch not applied (an installed copy is still unpatched)
Run `socket-patch apply` to regenerate them.

The suggested command drops every scope flag the check ran with. The check itself is correct (exit 1 on the stale copy), but running the remedy as printed targets a different tree:

  • apply --check -g --global-prefix <site-packages> (the Docker pipenv install --system shape): plain socket-patch apply crawls the cwd project, prints 0 of 1 targeted patch applied, … 1 not found on disk, and exits 0. The global copy stays unpatched. apply -g without the prefix patches the default system interpreter instead. In the sandbox that was the distro's /usr/lib/python3/dist-packages/six.py, which isn't the tree that was checked.
  • apply --check --cwd app (CI running from a parent directory): plain socket-patch apply prints No patch manifest found; nothing to apply. and exits 0. The Pipenv venv stays unpatched.

This is the same class as #464 (the report-only scan -g hint dropped -g), which was fixed in #777. The apply --check report wasn't covered by that fix.

Impact

apply --check is the CI / GitHub-App audit gate (CLI_CONTRACT apply --check row). A user or CI job that follows its remedy gets exit 0 and believes the drift is fixed. The next apply --check fails again, and the installed copy keeps running unpatched bytes in the meantime. There's no false VEX: this is a misleading remedy, not a wrong verdict.

Repro (Linux, main f3c6313, Pipenv 2026.8.0, local mock of the patch API serving a patched six-1.16.0 wheel)

# global / Docker `pipenv install --system` shape
G=$(mktemp -d)/sys; python3.11 -m venv "$G"; SPK=$G/lib/python3.11/site-packages
"$G/bin/pip" install six==1.16.0
cd my-pipenv-project                       # Pipfile + Pipfile.lock pinning six==1.16.0
socket-patch scan -g --global-prefix "$SPK" --mode agent --yes      # patches $SPK/six.py
"$G/bin/pip" install --force-reinstall --no-deps six==1.16.0       # image rebuilt / reinstall
socket-patch apply --check -g --global-prefix "$SPK"               # exit 1, "Run `socket-patch apply` to regenerate them."
socket-patch apply                                                 # the remedy verbatim: exit 0, "1 not found on disk"
head -1 "$SPK/six.py"                                              # still the upstream bytes

# --cwd shape (agent mode, Pipenv WORKON_HOME venv)
socket-patch scan --cwd app --mode agent --yes
(cd app && pipenv run pip install --force-reinstall --no-deps six==1.16.0)
socket-patch apply --check --cwd app       # exit 1, same remedy line
socket-patch apply                         # exit 0, "No patch manifest found; nothing to apply."

I reproduced the -g --global-prefix lane 3 times and the --cwd lane once. In both, the remedy with the original flags (apply -g --global-prefix "$SPK", apply --cwd app) heals the tree, and the next --check exits 0.

Expected vs actual

  • Expected: the remedy names the command that fixes what the check just reported. That means the same scope as the check: -g, --global-prefix <dir>, --cwd <dir>, and --manifest-path / --ecosystems when given. That's how #464 / #777 fixed the scan -g hint. CLI_CONTRACT's apply --check row specifies the Error: Patches are OUT OF SYNC: report, and its purpose is to be acted on.
  • Actual: a fixed string with no scope flags. Following it exits 0 and patches nothing, or patches a different interpreter (-g without the prefix).

OS × version

OS Pipenv Shape Result
Linux 2026.8.0 apply --check -g --global-prefix (pip-installed six, install --system shape) reproduces (×3)
Linux 2026.8.0 apply --check --cwd app (WORKON_HOME venv) reproduces
macOS / Windows not probed the line is a constant string expected to be the same

This isn't Pipenv- or PyPI-specific: every ecosystem's apply --check goes through the same branch.

Suspect code

crates/socket-patch-cli/src/commands/apply.rs:674, in run_check: eprintln!("Run \socket-patch apply` to regenerate them.");doesn't consultargs.common (global, global_prefix, cwd, manifest_path, ecosystems). Compare report_only_hint` after #777.

Lingua principale
Rust
Stelle
8
Fork
0
Merge medio
19h 21m
PR unite (30g)
421

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SocketDev/socket-patch

Tutte le issue di SocketDev/socket-patch

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.