Possible change / correction of Field export affecting four packages
還沒有人認領這個 Issue。
評估
研究方向
Review the existing field-exporter fix behind its #define and the before/after reverse-depends results described in the issue. Investigate the remaining failures in carat and perccal, then clarify the compatible API behavior, fallback requirements, and timeline before implementation.
由索引模型根據 Issue 內容生成。
描述
Issue https://github.com/RcppCore/RcppArmadillo/issues/263, opened quite some time ago by @coatless, demonstrated that we had a bug stacked away in dealing with a field exporter which dropped a dimension. I worked a bit on that in November and committed a fix albeit behind a #define. I had meant to come back to this and had time last week to run two sets of 'before' and 'after' reverse-depends checks to assess how costly it would be to enable this unconditionally.
It turns out that four (out of 950 total (!!)) packages then fail tests:
- AlphaSimR by @gaynorr et al -- already addressed in version 1.1.2 on CRAN
- carat by @yexiaoqingruc et al
- odpc by @esmucler -- will revert to old behavior, see #3, #4, addressed in version 2.0.5 on CRAN
- perccal by Dan McCarthy (not on GH, emailed 2022-02-13)
I have not yet had time to look into patches or changes. We probably want to fix this, and worst case can offer a #define to allow these four packages (and other uses like them) to get the old behavior back (in the sense of 'we published an API so we need to honor that contract') but otherwise offer 'better' code.
So "just" opening this issue to see if we can start a dialogue about what would be a suitable timeline to make the change. Maybe in three months? Too soon?
- 主要語言
- C++
- 星號
- 211
- 分支
- 54
- 平均合併
- 5 分鐘
- 30 天內合併 PR
- 1
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
RcppCore/RcppArmadillo 的其他 Issue
-
難度 5/5 一週以上 新手友好度 25/100
RcppCore/RcppArmadillo#454 · 3 則留言 ·
-
難度 4/5 3-5 天 新手友好度 35/100
RcppCore/RcppArmadillo#299 · 6 則留言 ·
-
難度 4/5 3-5 天 新手友好度 20/100
RcppCore/RcppArmadillo#268 · 3 個 reaction ·
-
enhancement help wanted
難度 4/5 3-5 天 新手友好度 35/100
RcppCore/RcppArmadillo#263 · 3 則留言 · 2 個 reaction ·
-
enhancement help wanted
難度 4/5 3-5 天 新手友好度 35/100
RcppCore/RcppArmadillo#250 · 1 則留言 ·
查看 RcppCore/RcppArmadillo 的全部 Issue
相似的 Issue
-
upstream update
難度 2/5 1-3 小時 新手友好度 75/100
conan-io/conan-center-index#31098 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 86/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
ml-explore/mlx-c#136 ·
-
bug chart-audit
難度 1/5 1 小時以內 新手友好度 92/100
維護者通常 1 天內回覆